- 29 Apr, 2019 26 commits
-
-
Sean McGivern authored
This will fail in a few ways: 1. We might end up having a path (not a URL) starting with `//`, which will be interpreted by browsers as a protocol-relative URL. 2. Issue, MR, snippet, etc. reference parsing will look for URLs at `http://gitlab.example.com//project/...`, with the double slash preventing single slashes from working. In general, it doesn't seem like there's a valid case for this.
-
Fatih Acet authored
Internationalisation of groups directory See merge request gitlab-org/gitlab-ce!27679
-
Brandon Labuschagne authored
This is one of many MRs opened in order to improve the overall internationalisation of the GitLab codebase. i18n documentation https://docs.gitlab.com/ee/development/i18n/externalization.html
-
Sean McGivern authored
Fix slow performance with compiling HAML templates Closes gitlab-ee#11198 See merge request gitlab-org/gitlab-ce!27782
-
Stan Hu authored
-
Stan Hu authored
In Rails 5, including `ActionView::Context` can have a significant and hidden performance penalty because this module also includes `ActionView::CompiledTemplates`. This means that any module that includes ActionView::Context becomes a descendant of `CompiledTemplates`. When a partial is rendered for the first time, it runs `ActionView::CompiledTemplates#module_eval`, which will evaluate a string that defines a new method for that partial. For example, the source of partial might be this string: ``` def _app_views_project_show_html_haml___12345(local_assigns, output) "hello world" end ``` When this string is evaluated, the Ruby interpreter will define the method and clear the global method cache for all descendants of `ActionView::CompiledTemplates`. Previous to this change, we inadvertently made a number of modules fall into this category: * GroupChildEntity * NoteUserEntity * Notify * MergeRequestUserEntity * AnalyticsCommitEntity * CommitEntity * UserEntity * Kaminari::Helpers::Paginator * CurrentUserEntity * ActionView::Base * ActionDispatch::DebugExceptions::DebugView * MarkupHelper * MergeRequestPresenter After this change: * Kaminari::Helpers::Paginator * ActionView::Base * ActionDispatch::DebugExceptions::DebugView Each time a partial is rendered for the first time, all methods for those modules will have to be redefined. This can exact a significant performance penalty. How bad is this penalty? Using the following benchmark script, we can use DTrace to sample the Ruby interpreter: ``` Benchmark.bm do |x| x.report do 1000.times do ActionView::CompiledTemplates.module_eval("def testme\nend") end end end ``` This revealed a 11x jump in the time spent in `core#define_method` alone. Rails 6 fixes this behavior by moving the `include CompiledTemplates` into ActionView::Base so that including `ActionView::Context` doesn't quietly affect other modules in this way. Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11198
-
Marcia Ramos authored
Fix text based on example See merge request gitlab-org/gitlab-ce!27787
-
Evan Read authored
-
James Lopez authored
Fix links to wiki pages with subdirectories in search Closes #56234 See merge request gitlab-org/gitlab-ce!27400
-
khm authored
This commit contains the patch suggested by @fjsanpedro in the issue covering broken links in wiki search results. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/56234
-
Kushal Pandya authored
Upgrade CI images to use Chrome V73 See merge request gitlab-org/gitlab-ce!27762
-
Douwe Maan authored
Port changes for design management to CE See merge request gitlab-org/gitlab-ce!27555
-
Douwe Maan authored
Resolve "Deployment jobs broken as of 11.10.0" Closes #60821 See merge request gitlab-org/gitlab-ce!27687
-
Sanad Liaquat authored
Fix GitHub oAuth test Closes gitlab-org/quality/nightly#98 See merge request gitlab-org/gitlab-ce!27736
-
Douwe Maan authored
Load environment metrics only for JSON endpoint See merge request gitlab-org/gitlab-ce!27743
-
Peter Leitzen authored
When showing the HTML version of the environment metrics we don't need to fetch their metrics because we don't use them anymore on the HTML version. We use additional_metrics.json endpoint now.
-
Marcia Ramos authored
Avoid links requiring permissions Closes #59653 See merge request gitlab-org/gitlab-ce!27797
-
Evan Read authored
-
Filipa Lacerda authored
Init MR Popovers on system note mounted Closes #60855 See merge request gitlab-org/gitlab-ce!27747
-
Sean McGivern authored
Fix Profiler to work with Rails 5.1 Closes #61051 See merge request gitlab-org/gitlab-ce!27774
-
Ash McKenzie authored
Add gitaly session id & catfile-cache feature flag See merge request gitlab-org/gitlab-ce!27472
-
John Cai authored
-
Ash McKenzie authored
Quarantine failing test See merge request gitlab-org/gitlab-ce!27799
-
Bob Van Landuyt authored
This ports the changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10462/ to CE
-
Mark Lapierre authored
-
Heinrich Lee Yu authored
-
- 28 Apr, 2019 13 commits
-
-
Evan Read authored
Add email clarification See merge request gitlab-org/gitlab-ce!27645
-
Cynthia Ng authored
-
Evan Read authored
Add clarification on namespace creation See merge request gitlab-org/gitlab-ce!27772
-
Evan Read authored
fix include example See merge request gitlab-org/gitlab-ce!27571
-
Evan Read authored
Docs: Environments Documentation review See merge request gitlab-org/gitlab-ce!27215
-
Marcel Amirault authored
-
Evan Read authored
Merge branch 'docs/60785-docs-feedback-masked-variables-is-not-clear-what-unescaped-characters-means' into 'master' Clarify masked variables docs Closes #60785 See merge request gitlab-org/gitlab-ce!27580
-
Steve Azzopardi authored
- Add note that must contain only letters, numbers, underscore - Add example of escape characters - Add regex used for validation closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60785
-
-
Kamil Trzciński authored
Resolve "Masked Variable still printed in log output on gitlab.com" Closes #60945 See merge request gitlab-org/gitlab-ce!27768
-
Stan Hu authored
-
Stan Hu authored
Attempt to solve issues such as https://gitlab.com/gitlab-org/gitlab-ce/issues/60953.
-
Grzegorz Bizon authored
Create dashboards endpoint & setup dashboard post-processing Closes #60383 See merge request gitlab-org/gitlab-ce!27405
-
- 27 Apr, 2019 1 commit
-
-
Ramya Authappan authored
Refactor quarantine helper See merge request gitlab-org/gitlab-ce!27766
-