- 04 Nov, 2019 22 commits
-
-
Reuben Pereira authored
- ETag caching will help reduce the load from polling the API. - Query parameters are not supported with ETag caching since the middleware only looks at the request path. Modify the frontend to work with path params We've changed the pod logs API to use path params instead of query params in order to support ETag caching. Simpify api replacing patterns - Use a single object as a parameter - Remove some code - Update specs Separate out html and json logs endpoints - Create separate APIs for the logs HTML page and the JSON endpoint that returns k8s logs. - Also correct the route for the JSON endpoint by adding the resource names to the route.
-
Jan Provaznik authored
Setup postgres for graphql-reference-verify Closes #35518 See merge request gitlab-org/gitlab!19540
-
Jan Provaznik authored
Create lib to read internal Prometheus address from config See merge request gitlab-org/gitlab!19503
-
Reuben Pereira authored
- Create the lib since it needs to be called in PrometheusService as well as the current SelfMonitoring::Project::CreateService.
-
Mike Greiling authored
Metrics: Save changes in the panels in dashboard to vuex store See merge request gitlab-org/gitlab!18862
-
Ramya Authappan authored
Quarantine flaky add file template specs See merge request gitlab-org/gitlab!19541
-
Evan Read authored
Update rspec guidelines for aggregating failures See merge request gitlab-org/gitlab!19512
-
Doug Stull authored
- Typically when we write tests, we try to only use one expectation per test. However, that isn't always optimal. So in those cases where we have more than one expectation, we should try to use :aggregate_failures in order to see all the failures in a test block at once and not have to piecemeal through it as we get each to pass.
-
Mike Greiling authored
Merge branch '34418-admin-setting-integrations-incorrectly-report-validation-errors-in-ui' into 'master' Remove unrelated errors from individual integrations Closes #34418 See merge request gitlab-org/gitlab!18814
-
Doug Stull authored
- before when any of the integrations had a form error, all of them would display that message block. - now we have contained those error messages to the areas they affect.
-
Ramya Authappan authored
Disable autodevops in Secure MR tests See merge request gitlab-org/gitlab!19516
-
-
Evan Read authored
Rename terminal_max_retention_time to session_timeout See merge request gitlab-org/gitlab!19349
-
Evan Read authored
docs - Sort variables' reference in ascending order See merge request gitlab-org/gitlab!19156
-
Juan Gascon authored
-
Ray Paik authored
Docs: Fix typo in visual_review_discussions.md title - properly display it is from starter only See merge request gitlab-org/gitlab!19522
-
Riccardo Padovani authored
-
Ray Paik authored
Docs: Remove typo See merge request gitlab-org/gitlab!19534
-
Ray Paik authored
Docs: Add comma after introductory phrase. See merge request gitlab-org/gitlab!19528
-
Heinrich Lee Yu authored
Increase certmanager install timeout See merge request gitlab-org/gitlab!19447
-
Hordur Freyr Yngvason authored
We have been getting reports from users that the cluster issuer is not ready prior to timing out, failing the installation. Since this time is primarily spent on the cluster and not in Sidekiq, we can probably afford to wait a bit longer. See e.g. https://gitlab.com/gitlab-org/gitlab/issues/33186
-
Heinrich Lee Yu authored
-
- 03 Nov, 2019 9 commits
-
-
Mark Lapierre authored
Quarantine Jenkins build status spec See merge request gitlab-org/gitlab!19499
-
Nailia Iskhakova authored
Issue https://gitlab.com/gitlab-org/gitlab/issues/35370 Spec fails on staging.
-
Russell Dickenson authored
Reduce use of note style in contiguous blocks of text See merge request gitlab-org/gitlab!19336
-
Evan Read authored
-
Mark Lapierre authored
Quarantine cluster health spec See merge request gitlab-org/gitlab!19505
-
-
Philipp C. H authored
-
Stan Hu authored
Improve cleanup of gpg-homedirs See merge request gitlab-org/gitlab!19311
-
Bob Van Landuyt authored
The `gpg-agent` that could have been spawned here dies when it sees it's socket disappear. However, sometimes it seems like we fail to delete the homedir, causing the `gpg-agent` to live on forever. We've noticed that the deletion failed in http://gitlab.com/gitlab-org/gitlab-foss/issues/36998: there was a race condition during the deletion where `gpg-agent` would still be modifying files while we've already called `FileUtils.remove_entry`. This will attempt to delete the directory multiple times, at least 0.1 seconds apart. This is a naive way of trying to make sure we clean up the homedir and count on `gpg-agent` to see that and make itself go away. On a web node we'll attempt for at most 0.5 seconds to clean up the directory before failing. In a sidekiq process we'll attempt the deletion for up to 2 seconds. When the cleanup fails, we will now track that exception in Sentry to gain some visibility. This also adds counters for the creation and deletion of tmp keychains, which we should be able to correlate to the nubmer of zombie `gpg-agent` processes.
-
- 02 Nov, 2019 9 commits
-
-
Philipp C. H authored
-
Jan Provaznik authored
Allow emojis to have links Closes #24891 See merge request gitlab-org/gitlab!18014
-
Heinrich Lee Yu authored
Regenerate graphql schema files Closes #35462 See merge request gitlab-org/gitlab!19526
-
Jan Provaznik authored
-
Harish Ramachandran authored
-
Harish Ramachandran authored
-
Harish Ramachandran authored
-
Harish Ramachandran authored
-
Harish Ramachandran authored
-