- 27 May, 2020 1 commit
-
-
Dylan Griffith authored
This introduces the same pattern of instrumentation [we use for Redis](https://gitlab.com/gitlab-org/gitlab/-/blob/b16db2726d7b429d740ef3642dda13b528fc4fda/lib/gitlab/instrumentation/redis.rb). This MR also adds the instrumentation details to sidekiq logs like we do with Redis. This instruments at the lowest level by instrumenting the elasticsearch-transport gem which is used by the elasticsearch-rails gem and elasticsearch-api gem which are the higher level abstractions used by GitLab. This has been tested to log requests coming from both places. Other options considered for this solution involved following a similar pattern to https://github.com/elastic/elasticsearch-rails/blob/1c3226d8186af6e8446fa5091f5b27760c29f896/elasticsearch-rails/lib/elasticsearch/rails/instrumentation/log_subscriber.rb which would extend the log subscriber pattern to be more than just searches in the context of the elasticsearch-rails gem but this seemed more convoluted than the approach I took since it requires monkey patching to publish a message then a separate class to subscribe and store those messages and so the pattern didn't seem to be beneficial unless you plan to have multiple subscribers. Additionally I considered using Faraday middleware to track this since the Elasticsearch gem uses Faraday by default but again I opted not to do that since it seemed trickier to manipulate the client config following https://github.com/elastic/elasticsearch-ruby/tree/master/elasticsearch-transport#transport-implementations and implement the required middleware etc. than just prepending the method following the same pattern as Redis.
-
- 26 May, 2020 11 commits
-
-
Dylan Griffith authored
Decouple reCAPTCHA from conditional allow See merge request gitlab-org/gitlab!32805
-
Dylan Griffith authored
Modify "Remove Rubocop::Cop::InjectEnterpriseEditionModule" to allow multiple injects Closes #207745 See merge request gitlab-org/gitlab!32747
-
Dylan Griffith authored
Add top_level_only option to Groups API Closes #26248 See merge request gitlab-org/gitlab!32870
-
Dylan Griffith authored
Add tags to queue selector attributes See merge request gitlab-org/gitlab!32651
-
Marcel Amirault authored
Demonstrate that YAML anchors can include multiple list items See merge request gitlab-org/gitlab!32915
-
Ben Bodenmiller authored
-
Marcel Amirault authored
Docs: add a table for language formality Closes #28724 See merge request gitlab-org/gitlab!32810
-
Russell Dickenson authored
Add docs for making ZAP artifacts CI Job Artifacts See merge request gitlab-org/gitlab!32402
-
Thong Kuah authored
Gracefully handle exception in importing a specific Jira issue See merge request gitlab-org/gitlab!32673
-
charlie ablett authored
Merge branch '217830-insert-gitlab-codeowners-validationservice-into-file-webide-merge-routine' into 'master' Apply codeowner validation when creating/updating a blob in the UI See merge request gitlab-org/gitlab!32341
-
Kerri Miller authored
-
- 25 May, 2020 28 commits
-
-
Russell Dickenson authored
Add documentation for new DAST env vars Closes #12652 See merge request gitlab-org/gitlab!32484
-
Philip Cunningham authored
-
Evan Read authored
Adds section about migrate rake command See merge request gitlab-org/gitlab!32837
-
Alexander Tanayno authored
-
Mayra Cabrera authored
Save repository storages in application settings with weights See merge request gitlab-org/gitlab!31645
-
Thong Kuah authored
Memoise database load balancing status Closes #218966 See merge request gitlab-org/gitlab!32964
-
John Cai authored
Add repository_storages_weighted field to the ApplicationSetting model. repository_storages_weighted is like repository_storages, except it allows a value per storage that will be used to store a weight from 0 to 100.
-
Andrew Fontaine authored
Remove prepend-left-2 CSS rule See merge request gitlab-org/gitlab!32883
-
Denys Mishunov authored
Update dependency @gitlab/ui to v15 See merge request gitlab-org/gitlab!32971
-
Enrique Alcántara authored
Update dependency @sourcegraph/code-host-integration to v0.0.47 See merge request gitlab-org/gitlab!32680
-
Douglas Barbosa Alexandre authored
Use wiki instead of project_wiki in Banzai See merge request gitlab-org/gitlab!32675
-
Russell Dickenson authored
Added missing "Introduced in" block See merge request gitlab-org/gitlab!23371
-
Russell Dickenson authored
-
Jan Provaznik authored
Add tags_count to container registry api and controller See merge request gitlab-org/gitlab!32141
-
Nicolò Maria Mezzopera authored
- source - tests Co-authored-by: Steve Abrams <sabrams@gitlab.com> Co-authored-by: Nick Kipling <nkipling@gitlab.com>
-
Peter Leitzen authored
Fix undefined error in Gitlab::Git::Diff See merge request gitlab-org/gitlab!32967
-
Peter Leitzen authored
Clarify merging MRs from a fork See merge request gitlab-org/gitlab!32969
-
Markus Koller authored
-
Jose Vargas authored
This removes the prepend-left-2 CSS rule and replaces it for the gl-ml-` utility class from GitLab-ui
-
GitLab Bot authored
-
Douglas Barbosa Alexandre authored
Revert "Merge branch 'mc/feature/expose-artifacts-locked' into 'master'" See merge request gitlab-org/gitlab!32986
-
Vasilii Iakliushin authored
*Problem* Gitaly::CommitDelta does not have a `#patch` attribute. It leads to the problem that calls to methods `#too_large?`, `#collapsed?`, `#has_binary_notice?` and `#to_hash` raise an exception. Here is an example of the exception: ``` Failure/Error: @too_large = @diff.bytesize >= self.class.patch_hard_limit_bytes NoMethodError: undefined method `bytesize' for nil:NilClass ``` *Solution* I explicitly set `@diff` to have an empty string value if the provided payload does not implement `#patch` method.
-
Andrew Fontaine authored
Abort DAG app init if selector doesn't exist See merge request gitlab-org/gitlab!32966
-
Matija Čupić authored
This reverts merge request !32787
-
Douglas Barbosa Alexandre authored
Added terraform state and Vulnerability exports to Geo limitations See merge request gitlab-org/gitlab!32954
-
Fabian Zimmer authored
-
Douglas Barbosa Alexandre authored
Consider artifact locking when exposing artifact information See merge request gitlab-org/gitlab!32787
-
Sean McGivern authored
Fix location of VSA feature flag spec - RUN AS-IF-FOSS See merge request gitlab-org/gitlab!32978
-