- 19 Dec, 2019 3 commits
-
-
James Fargher authored
-
James Fargher authored
Previously submitting a review that used `/submit_review` would recursively submit reviews until timeout
-
James Fargher authored
Allows submitting draft notes while posting a comment
-
- 18 Dec, 2019 37 commits
-
-
Robert Speicher authored
Automatically fixed EmptyLineAfterFinalLet in model and controller specs See merge request gitlab-org/gitlab!21872
-
Robert Speicher authored
Productivity Analytics: Add deep links (BE only) See merge request gitlab-org/gitlab!21031
-
Thong Kuah authored
13495-a: Create DesignAtVersion model See merge request gitlab-org/gitlab!21119
-
Dmitriy Zaporozhets authored
Resolve "Routing under `-` causes issues" See merge request gitlab-org/gitlab!22034
-
Annabel Dunstone Gray authored
Remove buttons in epic tree have weird focus state See merge request gitlab-org/gitlab!21785
-
Allen Lai authored
-
Kamil Trzciński authored
Reduce CommitIsAncestor RPCs with environments Closes #29562 See merge request gitlab-org/gitlab!21778
-
Mayra Cabrera authored
Updates security release issue template See merge request gitlab-org/gitlab!21571
-
Mayra Cabrera authored
Related to https://gitlab.com/groups/gitlab-com/gl-infra/-/epics/121
-
Mayra Cabrera authored
Updates Security Release MR template See merge request gitlab-org/gitlab!21576
-
Mayra Cabrera authored
As part of https://gitlab.com/groups/gitlab-com/gl-infra/-/epics/121, Security Release MR template was updated to not mention dev.gitlab.org, and point out to GitLab Security (gitlab-org/security/gitlab) instead. It also re-arranges some steps to make them more clear
-
Oswaldo Ferreira authored
-
Rémy Coutable authored
Add dashboard activity to events api See merge request gitlab-org/gitlab!19816
-
Douglas Barbosa Alexandre authored
Don't use cached node objects for geo:set_secondary_as_primary task See merge request gitlab-org/gitlab!22021
-
Sean McGivern authored
Extract list_projects into a separate controller See merge request gitlab-org/gitlab!21645
-
Martin Wortschack authored
Resolve "Move Analytics out of "More" in top navbar" See merge request gitlab-org/gitlab!21112
-
Brandon Labuschagne authored
This MR also adds a navbar item for analytics which takes a user to the merged analytics space.
-
Alessio Caiazza authored
This reverts commit 1578bae2, reversing changes made to 849b2c77.
-
Alessio Caiazza authored
This reverts merge request !20455
-
Vitali Tatarintev authored
Some routes can use a shorter version of a helper. That allows skipping a namespace object. The two following helpers produce the same result. ``` app.namespace_project_error_tracking_projects_path( @project.namespace, @project ) app.project_error_tracking_projects_path( @project ) ``` More info here https://gitlab.com/gitlab-org/gitlab /-/blob/v12.5.0-ee/config/application.rb#L279-291
-
Ray Paik authored
Added Japanese proofreader See merge request gitlab-org/gitlab!21942
-
Jan Provaznik authored
Use ISO time format with 3 fraction digits See merge request gitlab-org/gitlab!21835
-
Natalia Tepluhina authored
Resolve "Follow-up from "Finalise vue packages list app"" Closes #36652 See merge request gitlab-org/gitlab!21490
-
Nicolò Maria Mezzopera authored
- updated snapshots
-
Valery Sizov authored
It can cause some weird behaviour, AR objects are generally not condsidered to work like that
-
Natalia Tepluhina authored
Enable ESLint rule no-jquery/no-sizzle See merge request gitlab-org/gitlab!21875
-
Winnie Hellmann authored
-
Natalia Tepluhina authored
Introduced snippet_title component See merge request gitlab-org/gitlab!21941
-
Denys Mishunov authored
The component is responsible for rendering title, description and "Edited" information on a snippet view.
-
Walmyr Lima e Silva Filho authored
Quarantine auto devops e2e test See merge request gitlab-org/gitlab!21994
-
Sean McGivern authored
Extract Design Management System Note Service See merge request gitlab-org/gitlab!18162
-
Alex Kalderimis authored
This adds a new model entity `DesignManagement::DesignAtVersion`, which wraps a design and an associated version. Mechanisms are provided for lazy-finding and validation. These do not have mutable properties, and validate the important constraint that they share an issue Finding DesignManagement::DesignAtVersion objects requires querying both the designs and the versions tables, and is at present more expensive than a single fetch. It also returns an Array instead of a relation, since this is not a ActiveModel object. We validate invariants in find, this ensures we never fetch invalid objects. * Validations: - checking that there is both a design and a version - checking that the design and the version have the same issue - checking that both the design and the version have an issue These validations are checked during `find` and when calling `instantiate` * ID It is important for GraphQL and the front-end that the model has an ID that can be used to lookup each combination, and be used to store this identity on the client. * deleted? and status methods These supplement their analogues in DesignManagement::Design with an awareness of the current version. Thus a DesignManagement::DesignAtVersion as of a version in which is was deleted will respond to `deleted?` appropriately. Callers should be be careful to distinguish between `dav.state == :current` and `!dav.deleted?` - as of a version before a design has been created it will respond with: * `#deleted? == false` * `#status == :not_created_yet` Reflecting the fact that this is not deleted because it has not been created yet. This requires changes to the design and version factories to be able to create valid objects with nil issues, a condition that is found when these objects are being imported.
-
Alex Kalderimis authored
-
Alex Kalderimis authored
-
Alex Kalderimis authored
-
Alex Kalderimis authored
Also includes more namespacing for better readibility and determinism. The presence of a diff_refs method on Version allows us to have better code in Design that does not violate the laws of Demeter so much.
-
Alex Kalderimis authored
This adds a new scope `by_sha` to DesignManagement::Version, and allows it to be used in the version finder.
-