An error occurred fetching the project authors.
  1. 30 Apr, 2019 1 commit
    • Stan Hu's avatar
      Allow a member to have an access level equal to parent group · 77ddd0cd
      Stan Hu authored
      Suppose you have this configuration:
      
      1. Subgroup `hello/world`
      2. Subgroup `hello/mergers`.
      3. Project `hello/world/my-project` has invited group `hello/world` to
      access protected branches.
      4. The rule allows the group to merge but no one can push.
      5. User `newuser` has Owner access to the parent group `hello`.
      
      Previously, there was no way for the user `newuser` to be added to the
      `hello/mergers` group since the validation only allowed a user to be
      added at a higher access level.
      
      Since membership in a subgroup confers certain access rights, such as
      being able to merge or push code to protected branches, we have to
      loosen the validation and allow someone to be added at an equal level
      granted by the parent group.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11323
      77ddd0cd
  2. 01 Apr, 2019 1 commit
  3. 06 Dec, 2018 1 commit
  4. 11 Jul, 2018 2 commits
  5. 24 Jan, 2018 2 commits
  6. 22 Dec, 2017 2 commits
  7. 07 Oct, 2017 1 commit
    • Jacopo's avatar
      Replaces `tag: true` into `:tag` in the specs · 0ce67858
      Jacopo authored
      Replaces all the explicit include metadata syntax in the specs (tag:
      true) into the implicit one (:tag).
      Added a cop to prevent future errors and handle autocorrection.
      0ce67858
  8. 05 Sep, 2017 1 commit
    • Rubén Dávila's avatar
      Optimize SQL queries used in Groups::GroupMembersController#create · 66cfb901
      Rubén Dávila authored
      The following optimizations were performed:
      
      - Add new association to GroupMember and ProjectMember
      
        This new association will allow us to check if a user is a member of a
        Project or Group through a single query instead of two.
      
      - Optimize retrieving of Members when adding multiple Users
      66cfb901
  9. 02 Aug, 2017 2 commits
  10. 27 Jul, 2017 2 commits
  11. 26 Jul, 2017 2 commits
  12. 21 Jun, 2017 2 commits
  13. 28 Apr, 2017 1 commit
  14. 21 Apr, 2017 2 commits
  15. 23 Feb, 2017 4 commits
  16. 10 Feb, 2017 1 commit
  17. 26 Jan, 2017 1 commit
  18. 18 Nov, 2016 1 commit
  19. 11 Nov, 2016 1 commit
  20. 03 Oct, 2016 1 commit
  21. 28 Sep, 2016 1 commit
    • Rémy Coutable's avatar
      Allow Member.add_user to handle access requesters · ec0061a9
      Rémy Coutable authored
      Changes include:
      
      - Ensure Member.add_user is not called directly when not necessary
      - New GroupMember.add_users_to_group to have the same abstraction level as for Project
      - Refactor Member.add_user to take a source instead of an array of members
      - Fix Rubocop offenses
      - Always use Project#add_user instead of project.team.add_user
      - Factorize users addition as members in Member.add_users_to_source
      - Make access_level a keyword argument in GroupMember.add_users_to_group and ProjectMember.add_users_to_projects
      - Destroy any requester before adding them as a member
      - Improve the way we handle access requesters in Member.add_user
        Instead of removing the requester and creating a new member,
        we now simply accepts their access request. This way, they will
        receive a "access request granted" email.
      - Fix error that was previously silently ignored
      - Stop raising when access level is invalid in Member, let Rails validation do their work
      Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
      ec0061a9
  22. 22 Sep, 2016 1 commit
  23. 08 Sep, 2016 1 commit
    • Nick Thomas's avatar
      Exclude some pending or inactivated rows in Member scopes · 9521edb4
      Nick Thomas authored
      An unapproved access request should not give access rights, and blocked users
      should not be considered members of anything.
      
      One visible outcome of this behaviour is that owners and masters of a group or
      project may be blocked, yet still receive notification emails for access
      requests. This commit prevents this from happening.
      9521edb4
  24. 19 Aug, 2016 1 commit
  25. 10 Aug, 2016 1 commit
  26. 02 Aug, 2016 1 commit
  27. 27 Jul, 2016 1 commit
  28. 01 Jul, 2016 1 commit
  29. 18 Jun, 2016 1 commit