- 17 Jul, 2020 40 commits
-
-
Mark Florian authored
These no-op default exports have served one or both of these purposes: 1. Preventing `babel-plugin-rewire` from generating an invalid default during karma tests; 1. Working around the `import/prefer-default-export` ESLint rule for files which only have one named export. As we recently finished migrating all relevant specs from Karma to Jest, the first purpose is no longer necessary (with two exceptions, see below). The second purpose will become unnecessary once the [RFC][1] to prefer named exports to default exports is implemented. As such, this commit removes almost all no-op default exports, and adds explicit `eslint-disable-next-line` directives (which can be removed once the RFC is implemented). --- This work was achieved in a few steps. First, the default exports explicitly marked as `babel-plugin-rewire` workarounds were removed. This was achieved via this command: rg --color=never -l0 "// prevent babel-plugin-rewire" \ | xargs -0 \ perl -0pi -e \ 's/\n+\/\/ prevent babel-plugin-rewire[^\n]*tests'\ '(?:\nexport default \(\) => {};)?//mgs' The documentation describing this workaround was then removed by hand. Unfortunately, two files still participate in Karma tests, and still need this workaround, so these were reverted manually. Those files (at the time of writing) are: app/assets/javascripts/monitoring/stores/actions.js app/assets/javascripts/monitoring/stores/getters.js Then, all additional no-op default exports were removed with this command: rg --color=never -l0 -F "export default () => {};" \ | xargs -0 perl -0pi -e 's/\n+export default \(\) => {};//mgs' Since the `import/prefer-default-export` ESLint rule is still in place, the files violating it have to disable it explicitly. With the [RFC][1] to prefer named exports to default exports receiving wide approval, it makes sense to mark these current violations _explicitly_ with `eslint-disable-next-line` directives, rather than _implicitly_ via the no-op default export hack. The benefit of this approach is that when we disable the `import/prefer-default-export` rule globally for the RFC, ESLint will warn about all of these now-unnecessary directives. This will make it much easier to address all of them (perhaps even automatically, via `--fix`!). [1]: https://gitlab.com/gitlab-org/frontend/rfcs/-/issues/20
-
Mark Florian authored
UI for "Coverage-guided fuzzing results download" See merge request gitlab-org/gitlab!36676
-
Marcia Ramos authored
Added a feature flag mention to design docs See merge request gitlab-org/gitlab!37185
-
Natalia Tepluhina authored
-
Marcel Amirault authored
Documentation for upgrading chart See merge request gitlab-org/gitlab!36789
-
Kushal Pandya authored
Fixed issue with discussion not linking to in file-by-file See merge request gitlab-org/gitlab!37104
-
Marcel Amirault authored
-
Shinya Maeda authored
-
Shinya Maeda authored
-
Shinya Maeda authored
This commit adds documentation for upgrading chart
-
Kushal Pandya authored
Autocomplete confidential only epics & issues See merge request gitlab-org/gitlab!36687
-
Olena Horal-Koretska authored
Merge branch '229155-clarify-checking-ability-to-merge-automatically-message-on-mr-widget' into 'master' Change loading message for merge widget Closes #229155 See merge request gitlab-org/gitlab!37181
-
Kushal Pandya authored
Add pagination to iterations list See merge request gitlab-org/gitlab!37052
-
Simon Knox authored
Basically completely copied from issues list. Not ideal but simple and better than no pagination
-
Heinrich Lee Yu authored
Use memoized start/finish for metrics based on issues table Closes #224602 See merge request gitlab-org/gitlab!37155
-
Bob Van Landuyt authored
Redis latency monitoring: focus on slower requests See merge request gitlab-org/gitlab!37098
-
Kushal Pandya authored
Removing remaining instances of multiple_clusters Closes #225837 See merge request gitlab-org/gitlab!35927
-
Serena Fang authored
Since multiple clusters moving to core, we can remove any remaining references to has_multiple_clusters, as discussed in the comments of the parent MR.
-
Rajat Jain authored
Passing `confidential_only=true` as a query param in the autocomplete endpoints. Enabling the backend to only fetch confidential epics and confidential issues.
-
Martin Wortschack authored
Add Store for Creating a User List See merge request gitlab-org/gitlab!37005
-
Marcel van Remmerden authored
-
Achilleas Pipinellis authored
Update 3k reference architecture Closes #217852 See merge request gitlab-org/gitlab!34194
-
Igor Drozdov authored
Revert "Merge branch '214104-versioning' into 'master'" See merge request gitlab-org/gitlab!37179
-
Achilleas Pipinellis authored
Add missing rate and concurrency limits See merge request gitlab-org/gitlab!37117
-
Joshua Lambert authored
-
Bob Van Landuyt authored
Revert !36944 - Add include_parent_milestones to milestones API See merge request gitlab-org/gitlab!37177
-
Marcia Ramos authored
Add good for 1st time contributors to beginners See merge request gitlab-org/gitlab!36950
-
Phil Hughes authored
Don't show MLC form on thread replies Closes #229596 See merge request gitlab-org/gitlab!37139
-
Justin Boyson authored
-
Natalia Tepluhina authored
Support multiple files when editing snippets See merge request gitlab-org/gitlab!37079
-
Denys Mishunov authored
See https://gitlab.com/gitlab-org/gitlab/-/issues/220785#note_378854721 for more details
-
Achilleas Pipinellis authored
Docs: Polish "Pages on separate server" setup Closes gitlab-com/support/support-team-meta#2469 See merge request gitlab-org/gitlab!36282
-
Mark Chao authored
This reverts merge request !36686
-
Eugenia Grieff authored
- Revert changes that added the param include_parent_milestones to project milestones
-
Achilleas Pipinellis authored
Make note about trigger hover behavior See merge request gitlab-org/gitlab!37176
-
Igor Drozdov authored
Use native Gitaly pagination for Branch list API See merge request gitlab-org/gitlab!35819
-
David Kim authored
Pagination by Kaminari is slow because it requests all branches and paginate after receiving results from Gitaly. It's a first iteration to implement native pagination with Gitaly.
-
Marcel Amirault authored
-
Martin Wortschack authored
Replace prepend-left-10 class See merge request gitlab-org/gitlab!36610
-