- 22 Oct, 2018 24 commits
-
-
Robert Speicher authored
EE: Move Project#rename_repo to a service class See merge request gitlab-org/gitlab-ee!8028
-
Yorick Peterse authored
This moves the logic of Project#rename_repo and all methods _only_ used by this method into a new service class: Projects::AfterRenameService. By moving this code into a separate service class we can more easily refactor it, and we also get rid of some RuboCop "disable" statements automatically. During the refactoring of this code, I removed most of the explicit logging using Gitlab::AppLogger. The data that was logged would not be useful when debugging renaming issues, as it does not add any value on top of data provided by users. I also removed a variety of comments that either mentioned something the code does in literal form, or contained various grammatical errors. Instead we now resort to more clearly named methods, removing the need for code comments. This method was chosen based on analysis in https://gitlab.com/gitlab-org/release/framework/issues/28. In this issue we determined this method has seen a total of 293 lines being changed in it. We also noticed that RuboCop determined the ABC size (https://www.softwarerenovation.com/ABCMetric.pdf) was too great.
-
Douglas Barbosa Alexandre authored
[QA] Move epic-related method to EE class See merge request gitlab-org/gitlab-ee!7988
-
Nick Thomas authored
[QA] Fix verbose? being renamed to debug? See merge request gitlab-org/gitlab-ee!8033
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Marcia Ramos authored
Port from CE - update repo mirroring documentation See merge request gitlab-org/gitlab-ee!7790
-
Evan Read authored
-
Rémy Coutable authored
CE upstream - 2018-10-20 00:21 UTC Closes gitlab-ce#52916, gitlab-ce#52918, gitlab-runner#3642 et #8062 See merge request gitlab-org/gitlab-ee!8022
-
Nick Thomas authored
Fix review apps cleanup Closes #7657 and gitlab-ce#52112 See merge request gitlab-org/gitlab-ee!7772
-
Rémy Coutable authored
Fixed link in README.md See merge request gitlab-org/gitlab-ee!8020
-
Rémy Coutable authored
QA: Use strings for context descriptions Closes #8015 See merge request gitlab-org/gitlab-ee!7984
-
Nick Thomas authored
[EE] QA: Log page actions See merge request gitlab-org/gitlab-ee!7803
-
Nick Thomas authored
-
Nick Thomas authored
-
Nick Thomas authored
-
Nick Thomas authored
Add approve quick action Closes #1873 See merge request gitlab-org/gitlab-ee!7989
-
Phil Hughes authored
EE port of Frontend: Review app changes See merge request gitlab-org/gitlab-ee!8014
-
Filipa Lacerda authored
-
Filipa Lacerda authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
The job needed an `environment` declared in order to be able to communicate with the Kubernetes cluster. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Michael Kozono authored
To avoid confusion with tags.
-
Rémy Coutable authored
Geo: SSH push to secondary specs See merge request gitlab-org/gitlab-ee!7791
-
- 20 Oct, 2018 1 commit
-
-
GitLab Bot authored
# Conflicts: # app/assets/javascripts/jobs/components/job_app.vue # doc/api/groups.md # doc/user/group/index.md # spec/models/project_spec.rb [ci skip]
-
- 19 Oct, 2018 15 commits
-
-
Mark Lapierre authored
Override page object methods to log the actions taken by the methods before or after the action, as appropriate. Allow page object action logging to be turned on via a QA_DEBUG env var. Unlike CHROME_HEADLESS (and the soon to arrive VERBOSE), QA_DEBUG is false by default. QA_DEBUG is used instead of just DEBUG because that enables Selenium debug logging. Mask passwords entered into fields with a QA selector with 'password' in the name. Doesn't mask sensitive data entered into any other field.
-
Douwe Maan authored
Audit log: Add audit events for group setting changes Closes #8051 See merge request gitlab-org/gitlab-ee!7987
-
Douwe Maan authored
Merge branch '52772-assign-me-quick-action-doesn-t-work-if-there-is-extra-white-space' into 'master' Resolve "/assign me quick action doesn't work if there is extra white space" Closes #52772 See merge request gitlab-org/gitlab-ce!22402
-
Cindy Pallares 🦉 authored
-
Steffen authored
-
Robert Speicher authored
QA: Add basic e2e test for codeowners display in file blob See merge request gitlab-org/gitlab-ee!7368
-
Stan Hu authored
This adds audit logging for permission changes (e.g. who can create projects, 2FA enforcement, etc.) Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/8051
-
Robert Speicher authored
CE backport of changes to suppport group file templates See merge request gitlab-org/gitlab-ce!22310
-
Robert Speicher authored
Implement group file templates Closes #5987 See merge request gitlab-org/gitlab-ee!7391
-
Robert Speicher authored
Document how GitLab keeps its tests pristine Closes #42396 See merge request gitlab-org/gitlab-ce!22481
-
Nick Thomas authored
-
Stan Hu authored
Improve mirroring repositories UI See merge request gitlab-org/gitlab-ee!7899
-
Clement Ho authored
Allow to configure cache path for webpack See merge request gitlab-org/gitlab-ce!22497
-
Kamil Trzciński authored
-
Kamil Trzciński authored
Rename "scheduled" label/badge of delayed jobs to "delayed" Closes #52130 See merge request gitlab-org/gitlab-ce!22245
-