- 05 Jan, 2019 2 commits
-
-
Stan Hu authored
Mixing and matching the use of Rack::Request and ActionDispatch::Request in Rails 5 is bad, particularly if you have middleware that manipulates or accesses environment variables. `Gitlab::Middleware::Multipart` attempts to rewrite request parameters to the proper values (e.g. replacing `data_file` with `UploadedFile`). It does this by calling `Rack::Request#update_params`, which essentially updates `env['rack.request.form_hash']`. By changing to `ActionDispatch::Request`, the Go middleware was causing the request parameters to be stored inside `env['action_dispatch.request.request_parameters']`. Later calls to `Rack::Request#update_params` would not have any effect because it would attempt to update `env['rack.request.form_has']` instead of `env['action_dispatch.request.request_parameters']`. As a result, the controller still saw the old parameters. Since the Go middleware appears to be using `ActionDispatch::Request` for authorization methods, we can switch the multipart middleware to use it too. Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/9035
-
Stan Hu authored
Fix broken master api_variables test See merge request gitlab-org/gitlab-ce!24165
-
- 04 Jan, 2019 38 commits
-
-
GitLab Release Tools Bot authored
[ci skip]
-
Michael Kozono authored
-
Stan Hu authored
Merge branch '4553-geo-hashed-storage-migration-failure-does-not-log-to-sentry-or-geo-log-well-ee' into 'master' Backport of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8926 See merge request gitlab-org/gitlab-ce!24129
-
Kamil Trzciński authored
Support new report syntax for common vulnerabilities (CE backport) See merge request gitlab-org/gitlab-ce!23962
-
Marcia Ramos authored
Update serverless extension to yml See merge request gitlab-org/gitlab-ce!24163
-
danielgruesso authored
-
Valery Sizov authored
Backport of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8926
-
Mike Lewis authored
Fixes broken link See merge request gitlab-org/gitlab-ce!24161
-
Robert Speicher authored
Fix deprecation: returning false in Active Record and Active Model callbacks See merge request gitlab-org/gitlab-ce!24134
-
Marcia Ramos authored
-
Kamil Trzciński authored
This MR also removes other reports and uses one common set of fixtures for all test types.
-
Marcia Ramos authored
Add project code view permissions See merge request gitlab-org/gitlab-ce!24158
-
Robert Speicher authored
Don't ignore conflicts in db/schema.rb See merge request gitlab-org/gitlab-ce!24152
-
Douwe Maan authored
Expose `CI_API_V4_URL` CI/CD variable Closes #54621 See merge request gitlab-org/gitlab-ce!23936
-
Cindy Pallares 🦉 authored
-
Marcia Ramos authored
Improve documentation about only except default values Closes #55699 See merge request gitlab-org/gitlab-ce!24016
-
Kamil Trzciński authored
Include templates Closes #53445 See merge request gitlab-org/gitlab-ce!23495
-
Yorick Peterse authored
It's not entirely clear to me why we were ignoring db/schema.rb in the first place, but this should not be done now that we merge CE into EE automatically. Doing so can lead to changes being thrown away in the event of a conflict, which can then lead to EE pipelines failing.
-
Yorick Peterse authored
Don't ingore the `gitlab.pot` in ee_compat_check See merge request gitlab-org/gitlab-ce!24151
-
Stan Hu authored
Guarantee visually correct order of runners on the "Admin Area > Runners" page Closes #49791 See merge request gitlab-org/gitlab-ce!21627
-
Grzegorz Bizon authored
-
Marcia Ramos authored
Documentation for Release page MVC Closes #41766 See merge request gitlab-org/gitlab-ce!23901
-
-
Bob Van Landuyt authored
If there are new strings in CE, they need to be added to EE manually. As the `locale/gitlab.pot` file can't be merged automatically during the upstream merge.
-
Kamil Trzciński authored
This rewrites a syntax to allow include of templates. This also normalises the syntax used by include: feature
-
Kamil Trzciński authored
Support asset links creation in `POST /projects/:id/release` See merge request gitlab-org/gitlab-ce!24056
-
Achilleas Pipinellis authored
Mark references to openshift template as deprecated See merge request gitlab-org/gitlab-ce!24092
-
Balasankar "Balu" C authored
-
Clement Ho authored
Update @gitlab/svgs to latest version See merge request gitlab-org/gitlab-ce!24148
-
Shinya Maeda authored
-
Shinya Maeda authored
-
Shinya Maeda authored
-
Shinya Maeda authored
-
Shinya Maeda authored
Fix coding style Improve coding style Decouple UPDATE and DELETE operations of asset links Rename links_attributes to assets:links Rename exposed param and updated spec
-
Shinya Maeda authored
Fix spec for mysql unique validation failure
-
Shinya Maeda authored
Releases::Source and Releases::Link are covered by tests
-
Shinya Maeda authored
-
Shinya Maeda authored
- Add Releases::Links model - Expose it in release API - Add integration tests
-