- 06 Sep, 2021 34 commits
-
-
Patrick Steinhardt authored
The file size check checks each newly pushed blob's size to see whether it's bigger than a configured threshold and, if so, rejects the ref update. This is an expensive check though: we need to go both through all preexisting as well as all new refs in order to find out new blobs via a graph walk. As such, this check doesn't only scale with the number of changes, but also with the repository size itself. Now that `#new_blobs` knows to handle multiple new revisions at once in a single RPC call to Gitaly, we can convert this check to use a single bulk-load of new blobs. While this doesn't help much with walking the positive side of the graph walk, it does amortize the negative walk of all preexisting refs and will thus in most cases result in a significant speedup if multiple changes are to be checked. Ideally, we'd go even further and enumerate new blobs directly via the quarantine directory: we wouldn't have to do a graph walk at all in this case, but can just directly look up all new blobs. While this would be as fast as we can get, the downside is that we wouldn't have blob paths available anymore given that these blobs wouldn't have been walked via a tree object. We would still be able to at least present the blob ID to the user, but the user experience is definitely worse in this case. We may still at a later point decide to go this step given that it si a huge performance win (e.g. on gitlab-org/gitlab, we're talking about 10ms vs 30s). But for now, this commit only does the uncontroversial part of batch-computing new blobs. Changelog: performance
-
Patrick Steinhardt authored
Let `#new_blobs` accept multiple new revisions such that it's possible to compute new blobs across multiple changes instead of having to load blobs per changed ref.
-
Patrick Steinhardt authored
In 0d5df6f0 (repository: Implement `#new_blobs` via `#list_blobs`, 2021-08-25), we have introduced an alternative implementation of `#new_blobs` which uses `ListBlobs()` instead of `ListNewBlobs()`. While there wasn't yet any change in behaviour, this conversion allows us to convert `#new_blobs` to receive multiple new revisions as arguments such that we can batch-load new blobs in a single call instead of having to do so once per change. Remove the feature flag that has been guarding this new implementation such that we can continue with the conversion. While the new code has only been tested in production for one day at the time of writing this commit, there haven't been any issues. Furthermore, the risk of this change was low from the beginning. So removing the feature flag this quickly shouldn't be much of a concern. Changelog: added
-
Jan Provaznik authored
Exclude eslint as a SAST analyzer See merge request gitlab-org/gitlab!69512
-
Marcel Amirault authored
Improve Vale badge capitalization rule See merge request gitlab-org/gitlab!69511
-
Jonston Chan authored
-
Jarka Košanová authored
Revert out eager loading for ExpirePipelineCacheWorker See merge request gitlab-org/gitlab!69519
-
Matthias Käppler authored
Roll back support for caching encoding detection See merge request gitlab-org/gitlab!69581
-
release-tools approver bot authored
Update Gitaly version See merge request gitlab-org/gitlab!69611
-
Alex Pooley authored
Allow user owns_runner? callsite See merge request gitlab-org/gitlab!69527
-
Jarka Košanová authored
Eanble sort_by_project_users_by_project_authorizations_user_id FF See merge request gitlab-org/gitlab!69431
-
GitLab Release Tools Bot authored
-
Russell Dickenson authored
Remove four-stages diagram from flow page See merge request gitlab-org/gitlab!69516
-
Amy Qualls authored
-
Albert Salim authored
Adjust Feature Flag Audit Test to be Flexible See merge request gitlab-org/gitlab!69475
-
Sanad Liaquat authored
Enable SAST spec performance improvement See merge request gitlab-org/gitlab!68975
-
Patrick Bajao authored
Splits up auto_cancelable_pipelines query and adds limit for pipelines See merge request gitlab-org/gitlab!68585
-
Evan Read authored
Add warning message about metadata See merge request gitlab-org/gitlab!69541
-
Emily Chang authored
-
Sanad Liaquat authored
Improve flaky snippet_index_page_spec test See merge request gitlab-org/gitlab!69424
-
Evan Read authored
Describe how to add comments in the style guide See merge request gitlab-org/gitlab!69601
-
Adam Cohen authored
-
Dylan Griffith authored
Fix compilation of deprecations doc, and test it in CI See merge request gitlab-org/gitlab!69358
-
Marcel Amirault authored
-
Dylan Griffith authored
Add data migration to remove duplicate DastSiteTokens with same token See merge request gitlab-org/gitlab!69020
-
Marcos Rocha authored
-
Krasimir Angelov authored
Merge branch '338059-address-the-primary-key-overflow-risk-for-the-ci_sources_pipelines-table-step-3-drop' into 'master' Resolve "Address the Primary Key Overflow risk for the ci_sources_pipelines table - Step 3: Drop temporary columns and triggers" See merge request gitlab-org/gitlab!69281
-
Tiger Watson authored
Split diff commit migrations into smaller chunks See merge request gitlab-org/gitlab!69392
-
Mark Lapierre authored
Quarantine 2 tests awaiting a bug fix See merge request gitlab-org/gitlab!69594
-
Thong Kuah authored
Reschedule 'ExtractProjectTopicsIntoSeparateTable' background migration See merge request gitlab-org/gitlab!69199
-
dfrazao-gitlab authored
- Ignore source_job_id_convert_to_bigint column - Remove trigger_8485e97c00e3 trigger Related to https://gitlab.com/gitlab-org/gitlab/-/issues/338059 Changelog: added
-
Tiger Watson authored
Add locked column to Ci::JobArtifact See merge request gitlab-org/gitlab!68893
-
Russell Dickenson authored
Add java keytool workaround See merge request gitlab-org/gitlab!69122
-
Igor Frenkel authored
-
- 05 Sep, 2021 6 commits
-
-
Dmitriy Zaporozhets (DZ) authored
Use active status in metrics generator template See merge request gitlab-org/gitlab!69438
-
Dmitriy Zaporozhets (DZ) authored
Allow runner_matchers callsite See merge request gitlab-org/gitlab!69444
-
Mark Lapierre authored
-
Evan Read authored
Update permissions table for last topics See merge request gitlab-org/gitlab!69259
-
Marcel Amirault authored
-
Evan Read authored
Docs: Clarify what user API search searches for See merge request gitlab-org/gitlab!69565
-