- 09 Mar, 2021 40 commits
-
-
Mark Florian authored
Add support for new CAPTCHA modal to issue updates See merge request gitlab-org/gitlab!53941
-
Vitaly Slobodin authored
Move to btn-confirm from btn-success in admin/application_settings directory See merge request gitlab-org/gitlab!55263
-
Bob Van Landuyt authored
Fix: No such file or directory for pager_duty/validator See merge request gitlab-org/gitlab!55725
-
Vitali Tatarintev authored
https://gitlab.com/gitlab-org/gitlab/-/issues/322901 Fixes: No such file or directory lib/pager_duty/validator/schemas/message.json
-
Kamil Trzciński authored
Fix retried value for commit statuses [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!54300
-
Ramya Authappan authored
Enable PAT resource to use the admin PAT creation API See merge request gitlab-org/gitlab!53739
-
Savas Vedova authored
Update column width See merge request gitlab-org/gitlab!55716
-
Fernando Arias authored
* Adjust response styles Tweak alignment for solution text
-
Patrick Bajao authored
Resolve project from branch repository See merge request gitlab-org/gitlab!55694
-
Illya Klymov authored
Added an example of testing the rendered template to guidelines See merge request gitlab-org/gitlab!55979
-
Natalia Tepluhina authored
-
Enrique Alcántara authored
Update approvers dropdown to use new endpoint See merge request gitlab-org/gitlab!53781
-
Samantha Ming authored
Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/28902 Use "/projects/:id/groups" endpoint
-
Phil Hughes authored
Remove information alert about waf feature See merge request gitlab-org/gitlab!55927
-
Dmytro Zaporozhets (DZ) authored
Remove project_transactionless_destroy flag [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!55795
-
Rémy Coutable authored
Update doc dangerfile to point to metadata See merge request gitlab-org/gitlab!56028
-
Mike Jang authored
-
🤖 GitLab Bot 🤖 authored
Update Gitaly version See merge request gitlab-org/gitlab!56082
-
Rémy Coutable authored
Reduce DB load when resetting CI minute notifications See merge request gitlab-org/gitlab!55765
-
Matija Čupić authored
-
Etienne Baqué authored
Merge branch '321185-experiment-cleanup-invite_members_version_a-add-invite-members-to-assignees-dropdown' into 'master' Cleanup invite_members_version_a experiment [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!55178
-
yo authored
Update btn-confirm-admin-application-settings.yml Update app/views/admin/application_settings/_performance_bar.html.haml
-
Marcel Amirault authored
Fix double slashes in relative URL See merge request gitlab-org/gitlab!56077
-
Andreas Brandl authored
Support auto-batching background migrations See merge request gitlab-org/gitlab!54628
-
GitLab Release Tools Bot authored
-
Sean McGivern authored
Return attachment plus the filename in the Content-Disposition header [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!55066
-
Athar Hameed authored
Return attachment plus the filename in the Content-Disposition header [RUN ALL RSPEC] [RUN AS-IF-FOSS]
-
David Fernandez authored
Make sure that CI jobs are preloaded See merge request gitlab-org/gitlab!55841
-
Alper Akgun authored
Update Growth experiment cleanup issue See merge request gitlab-org/gitlab!55960
-
Vitaly Slobodin authored
Fix diff comment hidden dropdown See merge request gitlab-org/gitlab!56072
-
Nicolò Maria Mezzopera authored
Move to confirm variant from success in 2fa codes component See merge request gitlab-org/gitlab!55729
-
Yogi authored
-
Chad Woolley authored
Switch to new modern captcha modal which uses Pajamas modal and handles all CAPTCHA rendering on the client. This introduces new, more decoupled approach of using axios interceptors to handle captcha modal hooks. The backend now returns a 409 CONFLICT with a spam_log_id and captcha_site_key. On the frontend side we, the aforementioned interceptor detects this error, opens a modal asking the user to solve the captcha. If the captcha is solved successfully, it re-issues the request, attaching the captchaResponse. If it isn't solved, it will throw an `UnresolvedCaptchaError` instead. The application can choose to gracefully handle this error, or treat it as any other axios request error. For now the interceptors only support PATCH, POST and PUT. Future iterations might want to switch to using HTTP headers instead, which would mean we could extend the approach to the other HTTP methods as well. In this commit we are converting the issue update captcha to use this methodology. Before using an axios interceptor we needed to track the state of the captcha in the application and the logic looked something like this: ```mermaid sequenceDiagram participant U as User participant V as Vue Application participant G as GitLab API U->>V: Save issue V->>G: Request G--xV: Response with Error and Captcha Data V->>U: Please solve Captcha U->>V: Captcha Solution V->>G: Resend Request with solved Captcha Data G-->>V: Response with Success ``` Now we are doing this: ```mermaid sequenceDiagram participant U as User participant V as Vue Application participant A as Axios Interceptor participant G as GitLab API U->>V: Save issue V->>G: Request G--xA: Response with Error and Captcha Data A->>U: Please solve Captcha U->>A: Captcha Solution A->>G: Resend Request with solved Captcha Data G-->>A: Response with Success A-->>V: Response with Success ``` This way we have decoupled the Captcha handling from our Vue Application. For all the Vue Application knows, it is just a request that takes a bit longer than usual. This has the benefit that adding captcha support to new Vue endpoints is as easy as: ```js registerCaptchaModalInterceptor(axios); ``` Co-authored-by: Lukas Eipert <leipert@gitlab.com>
-
Jacques Erasmus authored
Add UploadButton component for project details See merge request gitlab-org/gitlab!56071
-
Nicolò Maria Mezzopera authored
Move to confirm variant from success in badges component See merge request gitlab-org/gitlab!55730
-
Yogi authored
-
Achilleas Pipinellis authored
-
jerasmus authored
Fixed the hidden dropdown by removing `gl-overflow-hidden`
-
Brandon Labuschagne authored
This component will be used in the project details overview. It's an upload button which links to an UploadBlobModal.
-
Russell Dickenson authored
docs: Fix secret detection variable reference See merge request gitlab-org/gitlab!55768
-