- 18 Mar, 2021 1 commit
-
-
charlie ablett authored
This changes our GraphQL code to use the built-in `#authorize` methods to handle permissions. We originally implemented this functionality with a field-extension, but this is no longer necessary. This commit replaces that unnecessary field extension with implementations of `BaseObject#authorize` that use our policy framework. Significant changes included here: - field authorization now works as per the library specification: it authorizes against the current object, not the resolved value. To apply permissions to the resolved value, use the type permissions. - we allow resolvers to do the same (opt-in). - we extend authorization to enums (currently no enums use authorization). Note on enums: We don't actually have any authorization on enums, but we need to detect that efficiently. By supporting `ObjectAuthorization`, we can skip redaction now, and support it later (if we add enum members that require special authorization to see). Removals: - The ManualAuthorization temporary class - The synchronized_object method on BaseResolver - Field.authorize DSL method Changes: The error raised when there is no auth becomes an internal server error (ConfigurationError) since it cannot be caused by the client, and represents a programming mistake. The board issue move mutation has unnecessary logic removed, and the test for this is adjusted to verify the correctness of this change. Co-authored-by: Alex Kalderimis <akalderimis@gitlab.com> Co-authored-by: Charlie Ablett <cablett@gitlab.com>
-
- 17 Mar, 2021 39 commits
-
-
Sean McGivern authored
API JSON caching for tags endpoint [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!54975
-
Enrique Alcántara authored
Move to confirm variant from success in javascripts/alert_management directory See merge request gitlab-org/gitlab!56206
-
Yogi authored
-
Mike Jang authored
Fixes typo in Frontend Guide docs See merge request gitlab-org/gitlab!56853
-
Arturo Herrero authored
Support newlines for the chatops "run" command See merge request gitlab-org/gitlab!56668
-
Mark Florian authored
Replace blank state component with gitlab-ui See merge request gitlab-org/gitlab!56651
-
Vitaly Slobodin authored
Exclude the pipeline configuration path from form submission if it is disabled See merge request gitlab-org/gitlab!56740
-
Amy Qualls authored
Add documentation for Jira Issue Detail page See merge request gitlab-org/gitlab!56182
-
Amy Qualls authored
Update formatting re: marketing emails See merge request gitlab-org/gitlab!56804
-
Amy Qualls authored
Fix the formatting - because part of what was on the page was incorrectly styled - and cross-link between the API and the page describing the UI feature.
-
Mark Florian authored
Remove tabindex from navigation skip link See merge request gitlab-org/gitlab!55756
-
Jeremy Elder authored
* Since it’s the first focusable item in the DOM it doesn’t need `tabindex`. * The use of a positive `tabindex` isn’t recommended and can negatively impact focus management.
-
Mikołaj Wawrzyniak authored
Update Metrics definitions for recording_ce_finished_at See merge request gitlab-org/gitlab!56382
-
Vitaly Slobodin authored
Add skipped state to duration cell See merge request gitlab-org/gitlab!56669
-
Peter Leitzen authored
Implement wildcard support for file searching in repository See merge request gitlab-org/gitlab!55871
-
Furkan Ayhan authored
Gitaly client and Git repository now support regexp searching. However, Repository model now supports wildcard searching.
-
Victor authored
-
Vitali Tatarintev authored
Expose dismissal reason and dismissal descriptions in Vulnerability details view See merge request gitlab-org/gitlab!55525
-
Markus Koller authored
Catch network errors when testing integration See merge request gitlab-org/gitlab!56457
-
Shubham Kumar authored
-
Phil Hughes authored
Move to confirm variant from success in javascripts/pipeline_editor directory See merge request gitlab-org/gitlab!56200
-
Yogi authored
-
Mark Florian authored
Use provide/inject for groupFullPath instead of props See merge request gitlab-org/gitlab!56472
-
Daniel Tian authored
-
Phil Hughes authored
Move from btn-success to btn-confirm in pipeline_schedules directory See merge request gitlab-org/gitlab!56201
-
Yogi authored
-
charlie ablett authored
Change array representation of events in YAML list syntax See merge request gitlab-org/gitlab!56480
-
Jan Provaznik authored
Add GraphQL mutation to delete release asset link See merge request gitlab-org/gitlab!56417
-
Nathan Friend authored
This commit adds a new mutation - `releaseAssetLinkDelete` - that deletes a release asset link.
-
Shinya Maeda authored
Update android template to default branch See merge request gitlab-org/gitlab!56738
-
Marcel Amirault authored
-
Mikołaj Wawrzyniak authored
Improve metric docs See merge request gitlab-org/gitlab!56673
-
charlie ablett authored
Replace delegated predicate methods with boolean-returning methods See merge request gitlab-org/gitlab!56420
-
James Lopez authored
Enable api_fuzzing_configuration_ui by default See merge request gitlab-org/gitlab!56548
-
Albert Salim authored
Simplify the triggerring of 'gitlab-docs' Review App pipelines See merge request gitlab-org/gitlab!53361
-
Mikołaj Wawrzyniak authored
Modify epic usage ping key to organise into separate file See merge request gitlab-org/gitlab!56724
-
🤖 GitLab Bot 🤖 authored
Update Gitaly version See merge request gitlab-org/gitlab!56834
-
Robert Hunt authored
If the pipeline config is enabled, it is added to the submission params otherwise we won't send it. This needs to change because the backend now expects the value to not be sent if the feature is disabled
-
Sanad Liaquat authored
Fix file commit error for system cancels merge train spec See merge request gitlab-org/gitlab!55219
-