- 24 Aug, 2020 40 commits
-
-
GitLab Bot authored
-
Jose Ivan Vargas authored
Merge branch '219781-replace-gl-deprecated-button-with-gl-button-in-ee-app-assets-javascripts-subscriptions-new' into 'master' Replace <gl-deprecated-button> with <gl-button> in subscriptions/new/components/checkout/confirm_order.vue See merge request gitlab-org/gitlab!40119
-
Sarah Groff Hennigh-Palermo authored
Remove Icon component from vue_shared See merge request gitlab-org/gitlab!38777
-
Sean McGivern authored
Include Redis in Workhorse-in-test-suite integration Closes #209245 See merge request gitlab-org/gitlab!40276
-
Fabio Pitino authored
Fix missing pipeline e-mails when job logs moved to object storage See merge request gitlab-org/gitlab!40075
-
Stan Hu authored
As discussed in https://gitlab.com/gitlab-org/gitlab/-/issues/195430, it's possible that a race condition occurs when a build finishes and a failed pipeline email goes out. This is what was happening before: 1. Build finishes and causes a pipeline failure. The pipeline failure transition causes the pipeline to run `PipelineNotificationWorker`, which schedules an `ActiveJob` to e-mail a user with a failed pipeline ID. 2. `BuildFinishedWorker` schedules `ArchiveTraceWorker` to move the job log, stored locally on a filesystem, to object storage. 3. The `ActiveJob` runs and loads the pipeline and failed build logs. Some builds have been moved to object storage, but the `ActiveJob` has a stale record and attempts to load the file from the filesystem. 4. The file doesn't exist, an `Errno::ENOENT` exception is raised. To fix this, we now attempt a refresh the job from the database if we encounter this exception.
-
Rémy Coutable authored
Spell out priority and severity labels See merge request gitlab-org/gitlab!40280
-
Lin Jen-Shin authored
-
Sean McGivern authored
Removes close issues step from security template See merge request gitlab-org/gitlab!40286
-
Stan Hu authored
Make highlighting limits stricter See merge request gitlab-org/gitlab!39934
-
Mayra Cabrera authored
Starting with 13.3, we're early merging security merge requests targeting master, but backports are still merged during the Security Release process. Because of it, security issues should still be opened until the Security Release finishes Related to https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/1106
-
Lukas Eipert authored
We have replaced all of the usages of the icon component from vue_shared with GlIcon. It is time to remove it!
-
Douglas Barbosa Alexandre authored
Remove unnecessary db calls in label_finder_spec See merge request gitlab-org/gitlab!40252
-
Lukas Eipert authored
The collapsible sidebar is not utilizing the icon component at all. During a refactor it was removed in 9fe79221, but due to a usage of the dynamic component `<component>`, eslint doesn't complain.
-
Lukas Eipert authored
The vue_shared/mixins/related_issuable_mixin.js exposed a component import to the mixin consumers. This is a bad pattern, as there is a disconnect between templates of the components utilizing the mixin and the components they import. This is moving the import to the actual components.
-
Stan Hu authored
This merge request was originally introduced in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/40026 but reverted in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/40245. We fix the issue it caused by using `Gitlab::Redis::SharedState.url`, which handles the differences between the GDK and CI `resque.yml` configuration formats. We started using Workhorse in feature tests, but no `config.toml` was provided. As a result, we missed a startup issue that could have been caught by testing the config loading. A small subset of Workhorse functionality also relies on Workhorse and Rails sharing a Redis database. If we configure it here, we can enhance the runner API testing in rails to ensure it behaves as expected. Closes https://gitlab.com/gitlab-org/gitlab/-/issues/209245
-
Douglas Barbosa Alexandre authored
Add search filter to issue boards resolver See merge request gitlab-org/gitlab!40076
-
Dan Davison authored
Add status issue links for Package and Release e2e tests See merge request gitlab-org/gitlab!40063
-
-
Sarah Groff Hennigh-Palermo authored
Utilize GitLab UI icon component: vue_shared See merge request gitlab-org/gitlab!40261
-
Jan Provaznik authored
Optimize requests/api/merge_requests_spec.rb spec See merge request gitlab-org/gitlab!40111
-
Mike Jang authored
docs: Use GitLab internal link instead of third-party hosting on docs See merge request gitlab-org/gitlab!40217
-
Takuya Noguchi authored
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
-
Mike Jang authored
Docs: Fix thoughtbot link in testing guide See merge request gitlab-org/gitlab!40228
-
Sarah Groff Hennigh-Palermo authored
Utilize GitLab UI icon component: ee/ See merge request gitlab-org/gitlab!40267
-
Sarah Groff Hennigh-Palermo authored
Utilize GitLab UI icon component: pipelines to vue_merge_request_widget See merge request gitlab-org/gitlab!40266
-
Sarah Groff Hennigh-Palermo authored
Utilize GitLab UI icon component: badges to diffs See merge request gitlab-org/gitlab!40263
-
Sarah Groff Hennigh-Palermo authored
Utilize GitLab UI icon component: environments to performance_bar See merge request gitlab-org/gitlab!40264
-
Sarah Groff Hennigh-Palermo authored
Utilize GitLab UI icon component: Web IDE See merge request gitlab-org/gitlab!40262
-
Rémy Coutable authored
Remove async_update_pages_config feature flag See merge request gitlab-org/gitlab!39984
-
Nathan Friend authored
Merge branch '12870-environments-dashboard-indicate-to-users-that-removing-adding-a-project-from-one-dashboard' into 'master' Add text indicating removing project affects operation dashboard Closes #12870 See merge request gitlab-org/gitlab!39450
-
Rayana Verissimo authored
-
Lukas Eipert authored
This replaces all the usages of ~/vue_shared/components/icon.vue with the corresponding GitLab UI component for all remaining ee/ components. In a previous MR [0] we already replaced the internal implementation with the GitLab UI component. This should allow us to migrate all usages without any test failures relating to the differences in their implementation. The actual deletion of the file will be done in a follow-up in case we have missed an instance or someone introduces a new one in the meanwhile. [0]: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/38778
-
Lukas Eipert authored
This replaces all the usages of ~/vue_shared/components/icon.vue with the corresponding GitLab UI component for all components from pipelines to vue_merge_request_widget (alphabetically). In a previous MR [0] we already replaced the internal implementation with the GitLab UI component. This should allow us to migrate all usages without any test failures relating to the differences in their implementation. The actual deletion of the file will be done in a follow-up in case we have missed an instance or someone introduces a new one in the meanwhile. [0]: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/38778
-
Shinya Maeda authored
Extract Gitlab::Ci::Lint class See merge request gitlab-org/gitlab!39692
-
Lukas Eipert authored
This replaces all the usages of ~/vue_shared/components/icon.vue with the corresponding GitLab UI component for all components from environments to performance_bar (alphabetically). In a previous MR [0] we already replaced the internal implementation with the GitLab UI component. This should allow us to migrate all usages without any test failures relating to the differences in their implementation. The actual deletion of the file will be done in a follow-up in case we have missed an instance or someone introduces a new one in the meanwhile. [0]: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/38778
-
Martin Wortschack authored
Fix Roadmap buffered rendering See merge request gitlab-org/gitlab!40243
-
Lukas Eipert authored
This replaces all the usages of ~/vue_shared/components/icon.vue with the corresponding GitLab UI component for all components from badges to diffs (alphabetically). In a previous MR [0] we already replaced the internal implementation with the GitLab UI component. This should allow us to migrate all usages without any test failures relating to the differences in their implementation. The actual deletion of the file will be done in a follow-up in case we have missed an instance or someone introduces a new one in the meanwhile. [0]: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/38778
-
Lukas Eipert authored
This replaces all the usages of ~/vue_shared/components/icon.vue with the corresponding GitLab UI component within the Web IDE In a previous MR [0] we already replaced the internal implementation with the GitLab UI component. This should allow us to migrate all usages without any test failures relating to the differences in their implementation. The actual deletion of the file will be done in a follow-up in case we have missed an instance or someone introduces a new one in the meanwhile. [0]: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/38778
-
Lukas Eipert authored
This replaces all the usages of ~/vue_shared/components/icon.vue with the corresponding GitLab UI component within the `vue_shared` directory. In a previous MR [0] we already replaced the internal implementation with the GitLab UI component. This should allow us to migrate all usages without any test failures relating to the differences in their implementation. The actual deletion of the file will be done in a follow-up in case we have missed an instance or someone introduces a new one in the meanwhile. [0]: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/38778
-