1. 10 Dec, 2019 30 commits
  2. 09 Dec, 2019 10 commits
    • Paul Slaughter's avatar
      Merge branch 'license-list-page' into 'master' · c0914223
      Paul Slaughter authored
      Add license list to "Security and Compliance" nav section - Add license list, modals, and links
      
      See merge request gitlab-org/gitlab!18934
      c0914223
    • Fernando Arias's avatar
      Add license list to nav · 13901b15
      Fernando Arias authored
      * Add feature flag and permissions check
      * Add controller, route, and nav entries
      
      Fix typo
      
      Refactor routes and feature flag
      
      * Change from license_list to licenses_list
      * Change from /security/license-list to /licenses
      
      Fix pipeline errors
      
      * remove controller file whitesspace
      * regenerate pot file
      
      Fix specs and linter
      
      Update project_nav_tab? call
      
      Add missing new line
      
      Fix haml linter
      
      Code review changes
      
      Update to License Compliance
      
      Update page header
      
      Remove unecessary before action
      
      Remove database.yml.example
      
      Creation of app and component directories
      
      * Refactor app bootstrap
      
      Add store
      
      * Add Actions, Getters, Mutations and state
      
      Save Changes
      
      Working license fetch
      
      Migrate to Vuex Module
      
      Add table
      
      Render table and row first pass
      
      Add component column logic and modal
      
      Update pagination rednering conditions
      
      Add pipeline link/text and timeago text
      
      Add question mark
      
      Fix unconfigured state SVG
      
      Remove empty files and add action spec
      
      Update action spec and add mutation specs
      
      Add getters spec
      
      Run prettier and linter
      
      Add changelog
      
      Tweak specs and add pagianted license list spec
      
      Add license table spec and snapshots
      
      Fix question icon alignment and mobile column name
      
      Add licence table row spec and snapshots
      
      Add component link specs
      
      Run prettier and linter
      
      Run prettier and linter
      
      Namespace translatons and update pot file
      
      Tweak icon markup
      
      Code feedback tweaks
      
      Refactor i18n translations
      
      Use gl-icon
      
      Fix header tag
      
      Update to hasJobSetup
      
      Update to hasLicenses
      
      Change to hasJobFailed
      
      First batch of maintainer review changes
      
      * Move changelog to EE
      * Change h5 to h3 for accessibility
      * Line-wrap haml template for vue app container
      
      Move LICENSE_LIST constant out of module
      
      * Refactor imports
      
      Move changelog to EE and revert to isJobSetUp
      
      Code review changes
      
      * Update license copy and update POT file
      * Remove unused class
      * Remove icon size
      
      Refactor modal and spec
      
      * Remove wrapping div
      * Update unit tests
      * Update remainingComponentsCount function to use Math.max
      
      Fix potential security issues
      
      * Sanitize url path
      * Secure link with rel="noopener noreferrer"
      * Update to rowheader
      
      Remove unused getters
      
      Refactor getters
      
      * Refactor simple getters to use mapState
      
      Remove unused empty file
      
      Apply suggestion to pipeline_info.vue
      
      Apply suggestion to mutation_types.js
      
      Apply suggestion to actions.js
      
      Apply suggestion to license_component_links_spec.js
      
      More fixes
      
      * Fall back to using array index as key :-(
      * Fix typo in unit test
      * Reorder imports
      
      Add mh-vh-50 utility class and scrollable modal
      
      * Add utility class for half the viewport height
      * Make scrollable area half the viewport height
      
      Simplify licenses_table_row_spec factory
      
      Update licenses_table_spec factory
      
      * Remove optional parameter
      * Update snapshot
      
      Clean up paginated_licenses_table_spec
      
      * Remove duplicate scenarios
      * Clean up factory
      
      Clean up action spec
      
      * Remove uneeded payload
      * Convert describe iterator into normal describe
      
      Run pretttier and linter
      
      Fix unit tests and run prettier
      
      Fix action spec
      
      * Update to test for rejected promise
      * Update pot file
      
      Additional code review changes
      
      * Refactor height class max-vh-50
      * Add mb-1 class to license compliance header
      * Remove unit test, test case that isn't possible
      * Add test case for license compliance job status
      
      Update utility class name
      
      Fix license compliance route
      
      * Undo route change that originally put it under
      projects/-/licenses
      
      Apply suggestion to
      app/assets/stylesheets/utilities.scss
      
      Apply suggestion to
      ee/app/views/projects/licenses/show.html.haml
      13901b15
    • Takuya Noguchi's avatar
      Update eslint-plugin-import from 2.16.0 to 2.18.2 · 34e7ff16
      Takuya Noguchi authored
      only for EE-specific contents under /ee/spec/javascripts/[a-e]*
      
      To improve import order rules
      
      Set import/order, import/no-cycle, and import/no-unresolved
      as warn to make this update smoother.
      34e7ff16
    • Mike Greiling's avatar
      Merge branch '38260-add-type-by-tasks-chart-feature-flag' into 'master' · f8292c71
      Mike Greiling authored
      Add tasks by type feature flag
      
      See merge request gitlab-org/gitlab!21294
      f8292c71
    • Ezekiel Kigbo's avatar
      Check for the :task_by_type_chart feature flag · 0ebfc34c
      Ezekiel Kigbo authored
      Pushes the feature flag to the frontend
      and ensures we check the flag before requesting
      the data needed.
      0ebfc34c
    • Clement Ho's avatar
      Merge branch 'add-feature-flag-toggle--edit' into 'master' · 9e7db9b1
      Clement Ho authored
      Add Feature Flag Toggle to Edit Page
      
      See merge request gitlab-org/gitlab!20860
      9e7db9b1
    • Paul Slaughter's avatar
      Merge branch 'jdb-remove-sticky-monitor-diff-file-header' into 'master' · 74abc282
      Paul Slaughter authored
      Remove stickyMonitor from diff_file_head.vue
      
      See merge request gitlab-org/gitlab!21076
      74abc282
    • Justin Boyson's avatar
      Remove stickyMonitor from diff_file_head.vue · ffb01a13
      Justin Boyson authored
      In this scenario stickyMonitor only add the class `is-stuck`
      to diff_file_header. On large diffs this almost doubles the
      render time.
      
      All the `is-stuck` class does is set border-radiust to 0.
      I believe the performance impact is not worth the trade
      off.
      ffb01a13
    • Mike Greiling's avatar
      4ad0a98c
    • ddavison's avatar
      Add data-qa-title attribute to milestone title · 7b84905b
      ddavison authored
      Change validation to use milestone_link rather than title
      Change has_milestone? to check for new data-qa-title
      rather than text
      Remove milestone_title from sidebar
      Unquarantine failing spec
      7b84905b