- 09 Jan, 2020 40 commits
-
-
Craig Miskell authored
Rather than stubbing out some internal methods of the test subject, use known good values for pid (the current process, and negative values) Much better code coverage test that way
-
Craig Miskell authored
Adds critical clarifying comments about the meaning of signal 0, which is effectively a liveness/existence (and permissions) check See http://man7.org/linux/man-pages/man2/kill.2.html for a discussion of that
-
Craig Miskell authored
In https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/8511 and https://gitlab.com/gitlab-com/gl-infra/production/issues/1309 we have seen cases where sidekiq-cluster has been asked to restart, but it has left one or more sidekiq worker processes in a stuck/hung state burning CPU. With this, sidekiq-cluster now waits for the worker processes to terminate themselves cleanly (and push jobs back onto the queue) and another few seconds beyond, then if any processes remain, kills them hard (:KILL signal) before exiting as usual (allowing whater process monitor is in place to restart sidekiq-cluster)
-
Stan Hu authored
One-button review app creation (backend) See merge request gitlab-org/gitlab!22085
-
Phil Hughes authored
Increase size of issue boards sidebar collapse button Closes #27427 See merge request gitlab-org/gitlab!22610
-
James Lopez authored
Add Is using seat badge to admin user overview See merge request gitlab-org/gitlab!21497
-
Phil Hughes authored
Resolve "Unable to create feature flags with userIds" Closes #194130 See merge request gitlab-org/gitlab!22528
-
Heinrich Lee Yu authored
Speed up link generation for project_id and namespace_id params Closes #194144 See merge request gitlab-org/gitlab!22426
-
Rémy Coutable authored
Add types to the E2E style guide See merge request gitlab-org/gitlab!22453
-
Mark Lapierre authored
`_placeholder` refers to a temporary element that appears while content is loading. For example, the elements that are displayed instead of discussions while the discussions are being fetched. `_container` refers to an element that includes other elements, but might not include any visible content itself. E.g., an element that has a third-party editor inside it, but which isn't the editor itself and so doesn't include the editor's content. `_modal` refers to a popup modal dialog, e.g., a confirmation prompt.
-
Heinrich Lee Yu authored
Extract list_issues from Sentry::Client class See merge request gitlab-org/gitlab!22615
-
Adam Hegyi authored
Modify ActionDispatch::Journey::Formatter#missing_keys method to prevent rebuilding large regular expressions on each url generation call.
-
Jan Provaznik authored
Add remaining project services to usage ping See merge request gitlab-org/gitlab!21843
-
Kushal Pandya authored
Add "Show last" Threat Monitoring filter See merge request gitlab-org/gitlab!22487
-
Mark Florian authored
Part of [WAF statistics reporting][1]. This adds the "Show last" filter dropdown to the UI, allowing for statistics over different time ranges to be displayed. [1]: https://gitlab.com/gitlab-org/gitlab/issues/14707
-
Natalia Tepluhina authored
Remove incorrect localVue usage in ee/spec/frontend/dependencies Closes #195844 See merge request gitlab-org/gitlab!22616
-
Natalia Tepluhina authored
Remove incorrect localVue usage in spec/frontend/monitoring Closes #195867 See merge request gitlab-org/gitlab!22618
-
Natalia Tepluhina authored
Custom snowplow events for alerts Closes #36955 See merge request gitlab-org/gitlab!21963
-
Dhiraj Bodicherla authored
Added custom snowplow events for alert related user actions in monitoring dashboard
-
Natalia Tepluhina authored
Update maxIssueCount in boards store See merge request gitlab-org/gitlab!22540
-
Scott Stern authored
-
Kushal Pandya authored
Fix Markdown table paste not working with GitHub code Closes #195479 See merge request gitlab-org/gitlab!22546
-
Kushal Pandya authored
Decouple time window specs for the monitoring dashboard Closes #35936 See merge request gitlab-org/gitlab!21866
-
Miguel Rincon authored
- Move the checks to internal date picker component - Add events to capture when dates are not valid - Communicate error via events - Ensure the dashboard can load, even with invalid dates
-
Kushal Pandya authored
Remove incorrect localVue usage in ee/spec/frontend/billings Closes #121593 See merge request gitlab-org/gitlab!22590
-
Etienne Baqué authored
Update ProjectPresenter. Added rspec accordingly. Removed changelog file.
-
Kushal Pandya authored
Remove incorrect localVue usage in spec/frontend/vue_shared Closes #121746 See merge request gitlab-org/gitlab!22576
-
Sanad Liaquat authored
Refactor `wait` and `retry_*` methods See merge request gitlab-org/gitlab!21804
-
Mark Lapierre authored
This is the first step in refactoring the Waiter and Retrier modules * Moves wait into the Retrier module as wait_until, and renames the max parameter to max_duration, to convey that its purpose is similar to retry_until. * Combines the loop logic into a single private method that the different public wait/retry methods use. * Allows retry_until to retry up to a certain maximum time limit, like wait_until, as well as the original funtionality of waiting until a specified condition is met. * Adds a retry_on_exception parameter to so that it's not necessary to nest wait/retry blocks if you want to do both. * Adds a raise_on_failure parameter, which is the same as retry_until's exit_on_failure parameter, but now it can be used with wait_until. Code review change to improve error message
-
Etienne Baqué authored
-
Etienne Baqué authored
Added relevant tests for this file.
-
Etienne Baqué authored
Got rid off unnecessary refactoring.
-
Etienne Baqué authored
Used new serializer in Environments controller. Created review app snippet. Refactored project logic into a new module.
-
Etienne Baqué authored
-
Ash McKenzie authored
Implement application appearance API See merge request gitlab-org/gitlab!20674
-
Vitali Tatarintev authored
-
Stan Hu authored
Update Gitaly to v1.80.0 See merge request gitlab-org/gitlab!22654
-
Paul Okstad authored
-
Ash McKenzie authored
Refactor Akismet service See merge request gitlab-org/gitlab!22651
-
Evan Read authored
Docs for SSH Keys: Refine pasting from clipboard wording See merge request gitlab-org/gitlab!22188
-