- 06 Oct, 2021 40 commits
-
-
Stan Hu authored
As described in https://community.letsencrypt.org/t/production-chain-changes/150739, the LetsEncrypt DST Root CA X3 expired on September 30, 2021. Domains that needed to be renewed via PagesDomainSslWorker would fail with the error, "Certificate misses intermediates". Newly-issued certificates would come with this chain of trust: End-entity certificate (A) ← R3 (B) ← ISRG Root X1 (C) ← DST Root CA X3 Previously, this is what was happening: 1. LetsEncrypt returned a bundle containing A, B, and C. 2. `PagesDomain#has_intermediates?` took B and C and added them to the OpenSSL certificate store. 3. `OpenSSL::X509::Store#verify` returned `false` because C was a trusted certificate, but DST Root CA X3 had expired. The crux of the problem is that we aren't using `verify` properly: we should be passing in an untrusted chain and allow OpenSSL to verify that C is indeed trusted from the system store. This emulates the behavior of the `-untrusted` parameter in the `openssl` command-line: ``` All certificates (typically of intermediate CAs) are considered untrusted and may be used to construct a certificate chain from the target certificate to a trust anchor. ``` Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/342326 Changelog: fixed
-
Shinya Maeda authored
Avoid cross-joins in `PipelinesForMergeRequestFinder` See merge request gitlab-org/gitlab!68549
-
Kushal Pandya authored
Adds support for tertiary buttons inside of the widget extension See merge request gitlab-org/gitlab!71097
-
Phil Hughes authored
-
Diana Logan authored
Added guidance for and so on See merge request gitlab-org/gitlab!71766
-
Suzanne Selhorn authored
-
Nicolò Maria Mezzopera authored
Add sentry error handling to the job actions component See merge request gitlab-org/gitlab!71780
-
Jan Provaznik authored
Simplify SubscriptionsHelper API See merge request gitlab-org/gitlab!71703
-
Vitali Tatarintev authored
Prevent push_package event if Maven package file creation fails See merge request gitlab-org/gitlab!71618
-
Sean McGivern authored
Add user to Snowplow event See merge request gitlab-org/gitlab!71353
-
Nikolay Belokolodov authored
For more detailed analysis we need to track user id. As described at https://gitlab.com/gitlab-org/gitlab/-/issues/336779#considered-data-for-pseudonymization user_id should be pseudoanonymized. user_id emitting is disabled by default by a feature flag.
-
Sanad Liaquat authored
E2E: Reduce log verbosity of every api request See merge request gitlab-org/gitlab!71795
-
Sean McGivern authored
Update Application Setting API doc to include suggest_pipeline_enabled See merge request gitlab-org/gitlab!71702
-
Eugie Limpin authored
-
Angelo Gulina authored
Merge methods into one
-
Vitaly Slobodin authored
Improve UX for addons purchase See merge request gitlab-org/gitlab!71582
-
Diana Zubova authored
Improve addons purchase UX Changelog: fixed EE: true
-
Fiona Neill authored
Add docs for new registration features See merge request gitlab-org/gitlab!71632
-
Rajendra Kadam authored
-
Etienne Baqué authored
Use allowlist of allowed attributes for imported models (part 2) See merge request gitlab-org/gitlab!71046
-
Alan (Maciej) Paruszewski authored
-
Aleksei Lipniagov authored
Remove cluster applications usage data See merge request gitlab-org/gitlab!70341
-
Hordur Freyr Yngvason authored
-
release-tools approver bot authored
Update Gitaly version See merge request gitlab-org/gitlab!71812
-
Craig Norris authored
Update metadata on DORA pages See merge request gitlab-org/gitlab!71708
-
Dmitry Gruzd authored
Remove whitespace in sidebar when iterations disabled See merge request gitlab-org/gitlab!70754
-
Simon Knox authored
-
Olena Horal-Koretska authored
Move on-demand scans JavaScript assets See merge request gitlab-org/gitlab!71727
-
Paul Gascou-Vaillancourt authored
-
Bob Van Landuyt authored
Render gitaly-unavailable error for Tags page See merge request gitlab-org/gitlab!71078
-
GitLab Release Tools Bot authored
-
Vitali Tatarintev authored
-
Mark Florian authored
Update GitLab UI/SVG See merge request gitlab-org/gitlab!71751
-
Natalia Tepluhina authored
Remove v-html from repository preview See merge request gitlab-org/gitlab!70833
-
Rishabh Gupta authored
-
Rémy Coutable authored
Fix broken FF rollout issue See merge request gitlab-org/gitlab!71254
-
Dmitriy Zaporozhets (DZ) authored
Specify overriding for EE::Project#execute_hooks See merge request gitlab-org/gitlab!71759
-
Ramya Authappan authored
E2E: validate project migration for Gitlab migration functionality See merge request gitlab-org/gitlab!71637
-
Andrejs Cunskis authored
-
Hugo Ortiz authored
-