- 26 Feb, 2020 40 commits
-
-
Mark Florian authored
This refactors the new `vulnerability-details` component to explicitly render the markup for the various details of the vulnerability, without going through an unnecessary transformation stage. This is preferable (though more verbose) because different details are rendered in different ways. Before, the template resembled the [loop-switch sequence][2] anti-pattern, and adding special cases was awkward. The snapshot changes in this commit are simply whitespace changes and added/missing HTML comments, resulting from the different conditional rendering logic. This addresses [issue 32039][1]. [1]: https://gitlab.com/gitlab-org/gitlab/issues/32039 [2]: https://en.wikipedia.org/wiki/Loop-switch_sequence
-
Mark Florian authored
This swaps out the component factory functions which rendered the old `vulnerability-details` component, in each of the MR and Security Dashboard contexts, with a new factory function that renders only the new version of the component. The snapshot changes in this commit correspond to the expected changes: - the MR context now includes (if available): - the project the vulnerability belongs to - the report type of the vulnerability - the line number information for the `file` - the Security Dashboard context now includes (if available): - the method in which the vulnerability was detected
-
Mark Florian authored
This ports the existing tests for the old `vulnerability-details` component to the new one, since it now accepts a `vulnerability` prop rather than a `details` prop.
-
Mark Florian authored
This duplicates the existing `vulnerability-details` component, and replaces its `details` prop with a `vulnerability` prop. To achieve this, the data transformations which turned a `vulnerability` object into a `details` object have been naively copied into this new component. The main data transformation is copied mostly verbatim from the [SET_MODAL_DATA mutation][1] in the Security Dashboard store, rather than from [SET_ISSUE_MODAL_DATA][2] mutation in the security reports store in the Merge Request page. This is because the former is slightly more complete than the latter: - it includes the project the vulnerability belongs to - it includes the report type of the vulnerability - it includes line number information for the `file`, if it exists The latter, however, includes the method in which the vulnerability was detected, if it exists. All this is to say that in addition to rendering everything the old component did, the new component: - in the MR context: - includes the project the vulnerability belongs to (if available) - includes the report type of the vulnerability (if available) - includes line number information for the `file` (if available) - in the Security Dashboard context: - includes the method in which the vulnerability was detected (if available) The [secondary transformation `valuedFields`][3] is copied almost verbatim from the containing modal. [1]: https://gitlab.com/gitlab-org/gitlab/blob/v12.8.1-ee/ee/app/assets/javascripts/security_dashboard/store/modules/vulnerabilities/mutations.js#L76-158 [2]: https://gitlab.com/gitlab-org/gitlab/blob/v12.8.1-ee/ee/app/assets/javascripts/vue_shared/security_reports/store/mutations.js#L135-172 [3]: https://gitlab.com/gitlab-org/gitlab/blob/v12.8.1-ee/ee/app/assets/javascripts/vue_shared/security_reports/components/modal.vue#L123-138
-
Mark Florian authored
This adds snapshot tests for the `vulnerability-details` component as it currently exists in the two main contexts it appears in: - in Merge Requests - any Security Dashboard Snapshots for both contexts are created, because the data is processed in slightly (though very similar) ways in each. A relatively wide selection of real vulnerability findings is used in both contexts to ensure good coverage. The purpose is to establish a baseline to facilitate refactoring the component, and the data paths in both contexts, without changing the final rendered output.
-
Bob Van Landuyt authored
Use available? method for Elastic Stack availability See merge request gitlab-org/gitlab!25615
-
Adrien Kohlbecker authored
-
Bob Van Landuyt authored
Fix flaky wiki specs by waiting for the SVG to be loaded first Closes #27972, #27964, #27951, and #207817 See merge request gitlab-org/gitlab!25982
-
Achilleas Pipinellis authored
Add S3 warning to Package Docs See merge request gitlab-org/gitlab!24729
-
Sara Ahbabou authored
Change boolean value
-
Lin Jen-Shin authored
Separate ee entities into own class files See merge request gitlab-org/gitlab!25709
-
Kamil Trzciński authored
Refactor import_export Closes #207846 See merge request gitlab-org/gitlab!25623
-
Nick Thomas authored
Rename GitAccess::UnauthorizedError and align git returned error codes See merge request gitlab-org/gitlab!25936
-
Peter Leitzen authored
Replace set to let_it_be in spec/features See merge request gitlab-org/gitlab!25889
-
Stan Hu authored
Migrate the Gemfile Danger check to static-analysis instead Closes #202299 See merge request gitlab-org/gitlab!25986
-
Nick Thomas authored
Fix displaying blocked issues on the board See merge request gitlab-org/gitlab!25817
-
Vitali Tatarintev authored
Get rids of set in spec/features
-
Jarka Košanová authored
Quarantine a flaky test in spec/lib/gitlab/profiler_spec.rb See merge request gitlab-org/gitlab!25993
-
Yorick Peterse authored
Updates security MR template See merge request gitlab-org/gitlab!25919
-
Francisco Javier López authored
In this commit we rename GitAccess::UnauthorizedError to ForbiddenError to align it with the kind of returned error 403. Besides we also fix the error code returned through the internal api and align it to use 403 as well.
-
Nick Thomas authored
Fixes Vue file list for paths with non-ascii characters Closes #207499 See merge request gitlab-org/gitlab!25877
-
Natalia Tepluhina authored
Migrate gke_zone_dropdown_spec to Jest See merge request gitlab-org/gitlab!25813
-
Emily Ring authored
Migrated /gke_cluster/components/gke_zone_dropdown_spec.js file to migrate tests from karma to jest.
-
Nick Thomas authored
Update file content of an existing custom dashboard Closes #34525 See merge request gitlab-org/gitlab!25024
-
Kirstie Cook authored
Add update route to dashboard controller Add update action to dashboard controller Start adding specs for UpdateDashboardService Serve :bad_request when the file update fails Add test for path traversal Flesh out dashboard details and additional specs Run static analysis Fixing comment
-
Jan Provaznik authored
Use Label#scoped_label_key when determining scope See merge request gitlab-org/gitlab!25952
-
Rémy Coutable authored
Return 503 to Runner when object storage is unavailable See merge request gitlab-org/gitlab!25822
-
Martin Wortschack authored
Enforce max daterange on VSA See merge request gitlab-org/gitlab!25678
-
Kamil Trzciński authored
Keep the needs association on the retried jobs See merge request gitlab-org/gitlab!25888
-
Marius Bobin authored
Change needs in CLONE_ACCESSORS to needs_attributes because it was reassigning the needs relationship to the new build.
-
nmilojevic1 authored
- Move files to Project/* namespace - Move files to Group/* namespace - Fix specs
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Paul Slaughter authored
Quarantine flaky karma tests See merge request gitlab-org/gitlab!25983
-
Rémy Coutable authored
Related to https://gitlab.com/gitlab-org/gitlab/issues/206907. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Apply license to selected group Closes #207970 See merge request gitlab-org/gitlab!25895
-
Marius Bobin authored
-
Marius Bobin authored
-
Marius Bobin authored
Catch object storage errors and return 503 to the Runner for artifacts uploads.
-
Mark Florian authored
Fix weight not showing in linked issues See merge request gitlab-org/gitlab!25718
-
Imre Farkas authored
Improve project mirror API code quality See merge request gitlab-org/gitlab!25345
-