- 29 Apr, 2019 40 commits
-
-
Filipa Lacerda authored
Merge branch '10949-fix-the-following-style-lint-errors-and-warnings-for-ee-app-assets-stylesheets-pages-milestone-scss' into 'master' Resolve "Fix the following style-lint errors and warnings for `ee/app/assets/stylesheets/pages/milestone.scss`" Closes #10949 See merge request gitlab-org/gitlab-ee!11665
-
Annabel Dunstone Gray authored
Port of 55948-help-text-formatting-wiki to EE See merge request gitlab-org/gitlab-ee!11494
-
Dennis Tang authored
-
GitLab Bot authored
-
Fatih Acet authored
Prefer usage of helper `expanded_by_default?` See merge request gitlab-org/gitlab-ee!11671
-
Peter Leitzen authored
Stop using `Rails.env.test?` in views.
-
Phil Hughes authored
CE: Fixes EE differences for app/views/projects/new.html.haml See merge request gitlab-org/gitlab-ce!27617
-
Phil Hughes authored
Fixes EE differences for app/views/projects/new.html.haml Closes #11031 See merge request gitlab-org/gitlab-ee!11482
-
Douglas Barbosa Alexandre authored
Use keyword args for databuilder push See merge request gitlab-org/gitlab-ce!24088
-
GitLab Bot authored
-
John T Skarbek authored
-
John T Skarbek authored
-
GitLab Bot authored
-
Fatih Acet authored
Internationalisation of groups directory See merge request gitlab-org/gitlab-ce!27679
-
Brandon Labuschagne authored
This is one of many MRs opened in order to improve the overall internationalisation of the GitLab codebase. i18n documentation https://docs.gitlab.com/ee/development/i18n/externalization.html
-
Sean McGivern authored
Fix slow performance with compiling HAML templates Closes gitlab-ee#11198 See merge request gitlab-org/gitlab-ce!27782
-
Stan Hu authored
Fix license app with relative url Closes #11345 See merge request gitlab-org/gitlab-ee!11717
-
Stan Hu authored
-
GitLab Release Tools Bot authored
Disallow read user scope to read project events See merge request gitlab/gitlabhq!3067
-
Stan Hu authored
In Rails 5, including `ActionView::Context` can have a significant and hidden performance penalty because this module also includes `ActionView::CompiledTemplates`. This means that any module that includes ActionView::Context becomes a descendant of `CompiledTemplates`. When a partial is rendered for the first time, it runs `ActionView::CompiledTemplates#module_eval`, which will evaluate a string that defines a new method for that partial. For example, the source of partial might be this string: ``` def _app_views_project_show_html_haml___12345(local_assigns, output) "hello world" end ``` When this string is evaluated, the Ruby interpreter will define the method and clear the global method cache for all descendants of `ActionView::CompiledTemplates`. Previous to this change, we inadvertently made a number of modules fall into this category: * GroupChildEntity * NoteUserEntity * Notify * MergeRequestUserEntity * AnalyticsCommitEntity * CommitEntity * UserEntity * Kaminari::Helpers::Paginator * CurrentUserEntity * ActionView::Base * ActionDispatch::DebugExceptions::DebugView * MarkupHelper * MergeRequestPresenter After this change: * Kaminari::Helpers::Paginator * ActionView::Base * ActionDispatch::DebugExceptions::DebugView Each time a partial is rendered for the first time, all methods for those modules will have to be redefined. This can exact a significant performance penalty. How bad is this penalty? Using the following benchmark script, we can use DTrace to sample the Ruby interpreter: ``` Benchmark.bm do |x| x.report do 1000.times do ActionView::CompiledTemplates.module_eval("def testme\nend") end end end ``` This revealed a 11x jump in the time spent in `core#define_method` alone. Rails 6 fixes this behavior by moving the `include CompiledTemplates` into ActionView::Base so that including `ActionView::Context` doesn't quietly affect other modules in this way. Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11198
-
GitLab Bot authored
-
Marcia Ramos authored
Fix text based on example See merge request gitlab-org/gitlab-ce!27787
-
Evan Read authored
-
GitLab Bot authored
-
James Lopez authored
Fix links to wiki pages with subdirectories in search Closes #56234 See merge request gitlab-org/gitlab-ce!27400
-
khm authored
This commit contains the patch suggested by @fjsanpedro in the issue covering broken links in wiki search results. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/56234
-
GitLab Bot authored
-
Yorick Peterse authored
Extracted EE specific lines from system_hooks_service_spec.rb See merge request gitlab-org/gitlab-ee!11587
-
Liam McAndrew authored
-
Kushal Pandya authored
Upgrade CI images to use Chrome V73 See merge request gitlab-org/gitlab-ce!27762
-
Kushal Pandya authored
Upgrade CI images to use Chrome V73 See merge request gitlab-org/gitlab-ee!11829
-
Kushal Pandya authored
Fix documentation links for protected refs help See merge request gitlab-org/gitlab-ee!11651
-
GitLab Bot authored
-
Douwe Maan authored
Port changes for design management to CE See merge request gitlab-org/gitlab-ce!27555
-
Douwe Maan authored
Upload versioned designs through GraphQL See merge request gitlab-org/gitlab-ee!10462
-
Douwe Maan authored
Resolve "Deployment jobs broken as of 11.10.0" Closes #60821 See merge request gitlab-org/gitlab-ce!27687
-
Sanad Liaquat authored
Fix GitHub oAuth test Closes gitlab-org/quality/nightly#98 See merge request gitlab-org/gitlab-ce!27736
-
Douwe Maan authored
Load environment metrics only for JSON endpoint See merge request gitlab-org/gitlab-ce!27743
-
Peter Leitzen authored
When showing the HTML version of the environment metrics we don't need to fetch their metrics because we don't use them anymore on the HTML version. We use additional_metrics.json endpoint now.
-
James Lopez authored
Extract health data configuration into a helper See merge request gitlab-org/gitlab-ee!11715
-