- 06 Jul, 2017 12 commits
-
-
Timothy Andrew authored
- Don't use `request.env['omniauth.params']` if it isn't present. - Remove the `saml` section from the `gitlab.yml` test section. Some tests depend on this section not being initially present, so it can be overridden in the test. This MR doesn't add any tests for SAML, so we didn't really need this in the first place anyway. - Clean up the test -> omniauth section of `gitlab.yml`
-
Timothy Andrew authored
- Disable an ESLint check rather than work around it (by converting `OAuthRememberMe` from a regular class to a static class. - Scope `$` calls inside `OAuthRememberMe`
-
Timothy Andrew authored
- Change double quotes to single quotes. - Why is `OmniAuth.config.full_host` being reassigned in the integration test? - Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task - Other minor changes
-
Timothy Andrew authored
- The test for `rake gitlab:env:info` executed the rake task, which mutated the list of omniauth providers, breaking subsequent tests relying on this list. - I've changed the rake task to duplicate the providers list before modifying it.
-
Timothy Andrew authored
-
Timothy Andrew authored
-
Timothy Andrew authored
- I tried to get this to work by stubbing out portions of the config within the test. This didn't work as expected because Devise/Omniauth loaded before the stub could run, and the stubbed config was ignored. - I attempted to fix this by reloading Devise/Omniauth after stubbing the config. This successfully got Devise to load the stubbed providers, but failed while trying to access a route such as `user_gitlab_omniauth_authorize_path`. - I spent a while trying to figure this out (even trying `Rails.application.reload_routes!`), but nothing seemed to work. - I settled for adding this config directly to `gitlab.yml` rather than go down this path any further.
-
Timothy Andrew authored
- Added saml, authentiq, cas3, and auth0 - Crowd seems to be a special case that will be handled separately.
-
Timothy Andrew authored
-
Timothy Andrew authored
-
Timothy Andrew authored
- There was previously a test for `saml` login in `login_spec`, but this didn't seem to be passing. A lot of things didn't seem right here, and I suspect that this test hasn't been running. I'll investigate this further. - It took almost a whole working day to figure out this line: OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') } As always, it's obvious in retrospect, but it took some digging to figure out tests were failing and returning 404s during the callback phase. - Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
-
Timothy Andrew authored
- Pass a `remember_me` query parameter along with the initial OAuth request, and pick this parameter up during the omniauth callback from request.env['omniauth.params']`. - For 2FA-based login, copy the `remember_me` param from `omniauth.params` to `params`, which the 2FA process will pick up. - For non-2FA-based login, simply call the `remember_me` devise method to set the session cookie.
-
- 05 Jul, 2017 28 commits
-
-
Sean McGivern authored
[EE] Create and use project path helpers that only need a project, no namespace See merge request !2336
-
Robert Speicher authored
[EE] Disable RSpec/BeforeAfterAll and enable RSpec/ImplicitExpect cops See merge request !2305
-
Douwe Maan authored
-
Douwe Maan authored
-
Sean McGivern authored
Geo: Migrated checks to SystemChecks See merge request !2331
-
James Edwards-Jones authored
[ci skip]
-
James Edwards-Jones authored
[ci skip]
-
Sean McGivern authored
Use trigger(:click) instead of trigger to avoid a weird transient bug Closes #2843 See merge request !2340
-
Douwe Maan authored
Environment-specific variables Closes #2302 See merge request !2112
-
Douwe Maan authored
Revert "Merge branch '18000-remember-me-for-oauth-login-ee' into 'master'" See merge request !2345
-
Douwe Maan authored
Add a license check for group-webhooks Closes #2576 See merge request !2280
-
Sean McGivern authored
This reverts merge request !2175
-
Sean McGivern authored
Fix spec failure for squash in progress error handling See merge request !2343
-
Annabel Dunstone Gray authored
Fixed admin sidebar not showing all options in new navigation See merge request !2334
-
Annabel Dunstone Gray authored
Port of 32838-admin-panel-spacing to EE See merge request !2264
-
Gabriel Mazetto authored
-
Annabel Dunstone Gray authored
Show loading icon when retrieving Geo node status Closes #1977 See merge request !2309
-
Douwe Maan authored
Resolve EE conflicts for "Fix API Scoping" See merge request !2338
-
Toon Claes authored
-
Bob Van Landuyt authored
Similar to how we check project features.
-
Bob Van Landuyt authored
-
Bob Van Landuyt authored
- Hide the `webhooks` link from the group-settings page - All group-webhooks-pages render a 404 - Don't execute webhooks if the feature is disabled
-
Bob Van Landuyt authored
-
Sean McGivern authored
EE Port: Honor the "Remember me" parameter for OAuth-based login See merge request !2175
-
James Edwards-Jones authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-