This way we can reuse the safe setting

Because `connect_to_db?` already detects if the table exists or not

This replaces the use of fake_application_settings with
`::ApplicationSetting.build`_from_defaults. The reason is that
`fake_application_settings` doesn't have the custom accessors that
`ApplicationSetting` has, e.g. `#commit_email_hostname`, thus this
can lead to unexpected `nil` values which comes from the database
column instead of `.default_commit_email_hostname` returned by
`ApplicationSetting#commit_email_hostname`.

Using `::ApplicationSetting.build_from_defaults` should be safe as it
doesn't try to `INSERT` a DB record, in contrary to
`::ApplicationSetting.create_from_defaults` which we used to use, and
which created issues that the introduction of
`fake_application_settings` tried to resolve (575dced5).
Signed-off-by: Rémy Coutable <remy@rymai.me>

Fix calendar feed when sorted by priority

Closes #54146

See merge request gitlab-org/gitlab-ce!23870

Close #55534: link OTP auth less strictly to Google

Closes #55534

See merge request gitlab-org/gitlab-ce!23921

Specify the 'sync' policy for the external-dns deployments

See merge request gitlab-org/gitlab-ce!23912

Backport of 8810-fix-weight-sort

See merge request gitlab-org/gitlab-ce!23786

[Rails5.1] Update functional specs to use new keyword format

Closes #54062

See merge request gitlab-org/gitlab-ce!23095

Sort list of predefined variables in alphabetical order

See merge request gitlab-org/gitlab-ce!23834

Backfill project_repositories for legacy storage projects

See merge request gitlab-org/gitlab-ce!23920

Compress images

See merge request gitlab-org/gitlab-ce!23902

Adds a background migration that will ensure all projects that
are on legacy storage have a row in `project_repositories`.

Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`

Add a missing policy allowance in GroupPolicy

See merge request gitlab-org/gitlab-ce!23906

Load the devise initializer before metrics

Closes #55513

See merge request gitlab-org/gitlab-ce!23907

Reduce diff with EE in ProtectedRefsController

See merge request gitlab-org/gitlab-ce!23885

Signed-off-by: Rémy Coutable <remy@rymai.me>

Update/secpick

See merge request gitlab-org/gitlab-ce!23900

Remove feature flag for suggest changes feature

See merge request gitlab-org/gitlab-ce!23892

Metrics tries to initialize the `EventsFinder` to instrumnt it. The `EventsFinder` tries to load the `Event` model, which in turn loads the `User` model.

Loading the `User` model requires Devise to be initialized. So to avoid problems around this, we load devise before loading metrics.

Passing an argument to force an association to reload is now deprecated

See merge request gitlab-org/gitlab-ce!23894

Merge branch '53020-user-specific-profile-page-settings-fields-don-t-have-help-text-placeholders' into 'master'

Add explanatory help text to text inputs on user profile settings page

Closes #53020

See merge request gitlab-org/gitlab-ce!23673

Remove content disposition attachment displaying all ssh keys

See merge request gitlab-org/gitlab-ce!23882

Upgrade Gitaly to 1.9.0

See merge request gitlab-org/gitlab-ce!23865

Resolve "Enable Hashed Storage by default in development mode"

Closes #54719

See merge request gitlab-org/gitlab-ce!23889

Merge branch 'ce-6635-extract-ee-specific-files-lines-for-app-controllers-admin-health_check_controller-rb' into 'master'

Make Admin::HealthCheckController EE-compatible

See merge request gitlab-org/gitlab-ce!23879

Creates index page for releases behind a feature flag

See merge request gitlab-org/gitlab-ce!23687

Signed-off-by: Rémy Coutable <remy@rymai.me>

Make Projects::ImportsController EE-compatible

See merge request gitlab-org/gitlab-ce!23883

Add danger check for duplicate yarn dependencies

Closes #51226

See merge request gitlab-org/gitlab-ce!21591

Fix deprecation: Directly inheriting from ActiveRecord::Migration is deprecated.

See merge request gitlab-org/gitlab-ce!23884