An error occurred fetching the project authors.
  1. 06 Jul, 2017 2 commits
    • Timothy Andrew's avatar
      dbe6cc6e
    • Timothy Andrew's avatar
      Add integration tests around OAuth login. · cd3aa1f5
      Timothy Andrew authored
      - There was previously a test for `saml` login in `login_spec`, but this didn't
        seem to be passing. A lot of things didn't seem right here, and I suspect that
        this test hasn't been running. I'll investigate this further.
      
      - It took almost a whole working day to figure out this line:
      
          OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') }
      
        As always, it's obvious in retrospect, but it took some digging to figure out
        tests were failing and returning 404s during the callback phase.
      
      - Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
      cd3aa1f5
  2. 05 Jul, 2017 1 commit
  3. 04 Jul, 2017 4 commits
    • Timothy Andrew's avatar
      Fix build for !11963. · d4caab38
      Timothy Andrew authored
      - Don't use `request.env['omniauth.params']` if it isn't present.
      
      - Remove the `saml` section from the `gitlab.yml` test section. Some tests
        depend on this section not being initially present, so it can be overridden
        in the test. This MR doesn't add any tests for SAML, so we didn't really need
        this in the first place anyway.
      
      - Clean up the test -> omniauth section of `gitlab.yml`
      d4caab38
    • Timothy Andrew's avatar
      Implement review comments for !11963 from @adamniedzielski. · 37cb1a4d
      Timothy Andrew authored
      - Change double quotes to single quotes.
      - Why is `OmniAuth.config.full_host` being reassigned in the integration test?
      - Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task
      - Other minor changes
      37cb1a4d
    • Timothy Andrew's avatar
      0754a442
    • Timothy Andrew's avatar
      Add integration tests around OAuth login. · d2859f86
      Timothy Andrew authored
      - There was previously a test for `saml` login in `login_spec`, but this didn't
        seem to be passing. A lot of things didn't seem right here, and I suspect that
        this test hasn't been running. I'll investigate this further.
      
      - It took almost a whole working day to figure out this line:
      
          OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') }
      
        As always, it's obvious in retrospect, but it took some digging to figure out
        tests were failing and returning 404s during the callback phase.
      
      - Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
      d2859f86
  4. 26 Jun, 2017 1 commit
  5. 19 Jun, 2017 4 commits
    • Robert Speicher's avatar
      Change `login_with` uses to `gitlab_sign_in` · 018ed2c4
      Robert Speicher authored
      Change single `login_via` use to `gitlab_sign_in_via`
      018ed2c4
    • Robert Speicher's avatar
      Rename methods in the LoginHelpers module · c1cbc273
      Robert Speicher authored
      - [x] Rename `login_as` to `gitlab_sign_in`
      - [x] Rename `login_with` to `gitlab_sign_in_with`
      - [x] Rename `login_via` to `gitlab_sign_in_via`
      - [x] Rename `logout` to `gitlab_sign_out`
      - [x] Rename `logout_direct` to `gitlab_sign_out_direct`
      - [x] Make `gitlab_login_with` (née `login_with`) private
      - [x] Make `mock_auth_hash` private
      c1cbc273
    • Robert Speicher's avatar
      Change `login_with` uses to `gitlab_sign_in` · 0f73a19d
      Robert Speicher authored
      Change single `login_via` use to `gitlab_sign_in_via`
      0f73a19d
    • Robert Speicher's avatar
      Rename methods in the LoginHelpers module · d76b9ceb
      Robert Speicher authored
      - [x] Rename `login_as` to `gitlab_sign_in`
      - [x] Rename `login_with` to `gitlab_sign_in_with`
      - [x] Rename `login_via` to `gitlab_sign_in_via`
      - [x] Rename `logout` to `gitlab_sign_out`
      - [x] Rename `logout_direct` to `gitlab_sign_out_direct`
      - [x] Make `gitlab_login_with` (née `login_with`) private
      - [x] Make `mock_auth_hash` private
      d76b9ceb
  6. 19 Apr, 2017 1 commit
  7. 23 Feb, 2017 6 commits
  8. 12 Dec, 2016 1 commit
  9. 15 Oct, 2016 3 commits
  10. 08 Sep, 2016 1 commit
  11. 11 Jul, 2016 1 commit
  12. 07 Jul, 2016 1 commit
  13. 04 Jul, 2016 2 commits
  14. 28 Jun, 2016 1 commit
  15. 03 Jun, 2016 2 commits
  16. 31 May, 2016 1 commit
  17. 15 Sep, 2015 1 commit
  18. 20 Jun, 2015 1 commit
  19. 13 Jun, 2015 1 commit
  20. 10 Jun, 2015 1 commit
  21. 05 Jun, 2015 1 commit
  22. 03 Oct, 2014 1 commit
  23. 26 Sep, 2014 1 commit
  24. 17 Jul, 2014 1 commit