- 14 Jun, 2019 1 commit
-
-
Stan Hu authored
Consider the scenario: 1. The default visibility level is set to internal 2. A user attempts to create a private project within a private group Previously this would always fail because default_value_for would overwrite the private visibility setting, no matter what visibility_level were specified. This was happening because default_value_for was confused by the default value of 0 specified by the database schema. default_value_for attempts to assign the default value in the block by checking whether the attribute has changed. The problem is that since the default value by the database was 0, and the user requested 0, this appeared as though no changes were made. As a result, default_value_for would always overwrite the user's preference. To fix this, we remove the use of default_value_for and only set the visibility level to the default application setting when no preference has been given at creation time. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63158
-
- 13 Jun, 2019 39 commits
-
-
Stan Hu authored
In production, we've seen the rendering times of the merge request widget increase as a result of loading commit data. BatchLoader attempts to call replace_methods on the lazy object, but this has a significant performance penalty for modules that have many methods. Disabling this mode (https://github.com/exAspArk/batch-loader/pull/45) appears to cut load times by about 50% for MergeRequestsController#show. Relates to https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6941
-
Robert Speicher authored
Omit blocked admins from repository check e-mails Closes #63019 See merge request gitlab-org/gitlab-ce!29507
-
Stan Hu authored
Master i18n See merge request gitlab-org/gitlab-ce!29611
-
Stan Hu authored
Use serialization for project boards See merge request gitlab-org/gitlab-ce!29263
-
Mike Greiling authored
"Add ESLint i18n plugin" Closes #62359 See merge request gitlab-org/gitlab-ce!26789
-
Brandon Labuschagne authored
Unnecessary offences include false positives as well as flagged errors which have follow up issues in order to be addressed. Not all issues have been addressed before this being submitted in the spirit of results and iteration.
-
Stan Hu authored
Remove spec/features/projects/files/user_edits_files_spec.rb from quarantine Closes #60497 See merge request gitlab-org/gitlab-ce!29620
-
Heinrich Lee Yu authored
-
Douglas Barbosa Alexandre authored
Refactor for cleaner caching in dashboards See merge request gitlab-org/gitlab-ce!29444
-
Sarah Yasonik authored
Opts to cache a full list of cached dashboards to better manage removing items from the cache. This also allows dashboards to be stored in the cache that don't necessarily correspond to a single dashboard yml.
-
Trevor Knudsen authored
Update application-security index.md's (SAST,DAST,LM and DS) See merge request gitlab-org/gitlab-ce!29547
-
Douglas Barbosa Alexandre authored
Raise an error if creating the MergeRequestDiff fails See merge request gitlab-org/gitlab-ce!29434
-
Filipa Lacerda authored
Click file row in repository Vue app to view file See merge request gitlab-org/gitlab-ce!29596
-
Nick Thomas authored
-
Stan Hu authored
disable CI variable complex expressions by default See merge request gitlab-org/gitlab-ce!29576
-
GitLab Crowdin Bot authored
[skip ci]
-
GitLab Crowdin Bot authored
[skip ci]
-
GitLab Crowdin Bot authored
[skip ci]
-
GitLab Crowdin Bot authored
[skip ci]
-
drew cimino authored
-
Sean McGivern authored
Backport changes from 'Partially revert d9cb907c: "Avoid loading objects from DB in ES results"' See merge request gitlab-org/gitlab-ce!29597
-
Douwe Maan authored
Process up to 100 commit messages for references when pushing to a new default branch See merge request gitlab-org/gitlab-ce!29511
-
Fabio Papa authored
Commit messages are not processed for references to issues when creating the default branch on push. This was expected behavior (probably to avoid performance problems when first pushing a repository with thousands of commits). However, this is not an issue because we always limit the number of commits to process to 100 regardless of whether we are creating the default branch or not.
-
Bob Van Landuyt authored
Bring propagated SAST ENV vars into parity with docs See merge request gitlab-org/gitlab-ce!29564
-
Nick Thomas authored
-
Nick Thomas authored
This reverts commit d9cb907c.
-
Phil Hughes authored
-
Phil Hughes authored
Moves sp.js to CE repo Closes gitlab-ee#12106 See merge request gitlab-org/gitlab-ce!29545
-
Kamil Trzciński authored
Review roulette excludes mr_author Closes #61157 See merge request gitlab-org/gitlab-ce!28886
-
Phil Hughes authored
Add trackEvent when accessing the Register tab See merge request gitlab-org/gitlab-ce!29336
-
Phil Hughes authored
Added naming convention for .graphql files See merge request gitlab-org/gitlab-ce!29558
-
Natalia Tepluhina authored
-
Achilleas Pipinellis authored
Add quotes to redirect value Closes #63165 See merge request gitlab-org/gitlab-ce!29584
-
Evan Read authored
-
Ash McKenzie authored
This is a no-op for CE.
-
Evan Read authored
Add dependency proxy to permissions.md Closes gitlab-ee#12075 See merge request gitlab-org/gitlab-ce!29497
-
Evan Read authored
Docs: Convert absolute links to relative in /ci docs See merge request gitlab-org/gitlab-ce!29029
-
Evan Read authored
Leave clear notices in docs about after_script execution context Closes gitlab-runner#4146 See merge request gitlab-org/gitlab-ce!29510
-
Evan Read authored
Removed duplicate content on scoped labels See merge request gitlab-org/gitlab-ce!29579
-