1. 13 Feb, 2018 5 commits
    • Yorick Peterse's avatar
      Remove Sentry reporting for query limiting · e3bd674e
      Yorick Peterse authored
      Using Sentry, while useful, poses two problems you have to choose from:
      
      1. All errors are reported separately, making it easy to create issues
         but also making it next to impossible to see other errors (due to the
         sheer volume of threshold errors).
      
      2. Errors can be grouped or merged together, reducing the noise. This
         however also means it's (as far as I can tell) much harder to
         automatically create GitLab issues from Sentry for the offending
         controllers.
      
      Since both solutions are terrible I decided to go with a third option:
      not using Sentry for this at all. Instead we'll investigate using
      Prometheus alerts and Grafana dashboards for this, which has the added
      benefit of being able to more accurately measure the behaviour over
      time.
      
      Note that throwing errors in test environments is still enabled, and
      whitelisting is still necessary to prevent that from happening (and that
      in turn still requires that developers create issues).
      e3bd674e
    • Sean McGivern's avatar
      Merge branch 'sh-no-cache-populate-migration' into 'master' · 4e846c73
      Sean McGivern authored
      Disable caching of tables for migration spec that drops a temporary table
      
      See merge request gitlab-org/gitlab-ce!16965
      4e846c73
    • Sean McGivern's avatar
      Merge branch 'sh-fix-issue-43193' into 'master' · 754d1ec4
      Sean McGivern authored
      Fix Error 500s creating merge requests with external issue tracker
      
      Closes #43193
      
      See merge request gitlab-org/gitlab-ce!17073
      754d1ec4
    • Phil Hughes's avatar
      Merge branch 'winh-new-branch-dropdown-style' into 'master' · 8925671a
      Phil Hughes authored
      Cleanup new branch/merge request form in issues
      
      Closes #41938
      
      See merge request gitlab-org/gitlab-ce!16854
      8925671a
    • Stan Hu's avatar
      Fix Error 500s creating merge requests with external issue tracker · 926002fd
      Stan Hu authored
      When JIRA or Redmine were enabled and the branch name did not match the
      matching regular expression, the `issue_iid` would be `nil`, preventing
      users from creating merge requests.
      
      Closes #43193
      926002fd
  2. 12 Feb, 2018 35 commits