1. 30 Nov, 2018 10 commits
    • Dylan Griffith's avatar
      Make KUBECONFIG nil if KUBE_TOKEN is nil · e7f2be49
      Dylan Griffith authored
      Having an invalid KUBECONFIG without a token in it is not helpful. This
      only became possible recently now that we are creating a separate
      namespace and service account (and hence token) to send to the runners.
      This led to somewhat surprising results when troubleshooting
      https://gitlab.com/gitlab-org/gitlab-ce/issues/53879 as I found that the
      KUBECONFIG was still being passed but KUBE_TOKEN was not. These things
      really should have been linked.
      
      Furthermore now that we are also using the [presence of KUBECONFIG to
      decide whether or not to run build steps in Auto
      DevOps](https://gitlab.com/gitlab-org/gitlab-ce/blob/294d15be3e9497e7b67e1f9131ce9d5c0d68406c/lib/gitlab/ci/templates/Auto-DevOps.gitlab-ci.yml#L164)
      I think it makes even more sense to ensure that KUBECONFIG is a complete
      config if passed to a job.
      e7f2be49
    • Kamil Trzciński's avatar
      Merge branch 'ignore-failed-pipeline-creation-on-pipeline-schedule' into 'master' · 817bb190
      Kamil Trzciński authored
      Remove auto deactivation when failed to create a pipeline via pipeline schedules
      
      Closes #41231
      
      See merge request gitlab-org/gitlab-ce!22243
      817bb190
    • Phil Hughes's avatar
      Merge branch '54218-fix-mergeUrlParams' into 'master' · 9f967ba2
      Phil Hughes authored
      Resolve "mergeUrlParams wrong with fragment url"
      
      Closes #54218
      
      See merge request gitlab-org/gitlab-ce!23193
      9f967ba2
    • Thomas Holder's avatar
      fe76827f
    • Kushal Pandya's avatar
      Merge branch 'winh-timeline-entry-component' into 'master' · b6e70c8a
      Kushal Pandya authored
      Extract shared timeline entry component
      
      See merge request gitlab-org/gitlab-ce!23447
      b6e70c8a
    • Phil Hughes's avatar
      Merge branch '48496-merge-request-refactor-does-not-highlight-selected-line' into 'master' · df027849
      Phil Hughes authored
      Resolve "Merge request refactor does not highlight selected line"
      
      Closes #48496
      
      See merge request gitlab-org/gitlab-ce!23121
      df027849
    • Sam Bigelow's avatar
    • Stan Hu's avatar
      Merge branch 'fix-wrong-grape-version-requirement' into 'master' · 0d5cbd16
      Stan Hu authored
      Currently a dependency for grape `~> 1.1` is defined but gitlab does not work…
      
      See merge request gitlab-org/gitlab-ce!23451
      0d5cbd16
    • Shinya Maeda's avatar
      Squashed commit of the following: · d56d419a
      Shinya Maeda authored
      commit 0c00e52d339f8471a6ea425d5a4a59751a3f4a35
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Fri Nov 30 15:41:46 2018 +0900
      
          Update schedules.md
      
      commit 0ae56bf5a0ba9254d2ebd4c846395113ae72d686
      Merge: c143777c9f2 9ce28bf0
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Fri Nov 30 15:38:01 2018 +0900
      
          Merge branch 'master-ce' into ignore-failed-pipeline-creation-on-pipeline-schedule
      
      commit c143777c9f250c8075355ac07e9bae7b074665c3
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 29 17:18:07 2018 +0900
      
          Fix coding offence
      
      commit 7c816dfa634b5911310c67c285fc3c37d5f03517
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 29 16:12:06 2018 +0900
      
          Improve spec quality
      
      commit f78eed45e991123f8af4a7b24f041529bbb35e91
      Merge: 96d20ce9144 a5f46278
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 29 15:20:16 2018 +0900
      
          Merge branch 'master-ce' into ignore-failed-pipeline-creation-on-pipeline-schedule
      
      commit 96d20ce914458f86e68b57bc1bb88ab8d27f010b
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 27 16:25:42 2018 +0900
      
          Print pipeline error
      
      commit 97842068b6cf1432cd400ead749843946b4f51ee
      Merge: c2b015949af 2ee8c40f
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 27 15:51:49 2018 +0900
      
          Merge branch 'master-ce' into ignore-failed-pipeline-creation-on-pipeline-schedule
      
      commit c2b015949afb3ecc70cb057e2d13672f378c0d03
      Merge: 3435137c17b fbbe5ccd
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Mon Nov 26 15:26:17 2018 +0900
      
          Merge branch 'master-ce' into ignore-failed-pipeline-creation-on-pipeline-schedule
      
      commit 3435137c17b0ef03003e39dd08c7370fe916c626
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 20 17:45:38 2018 +0900
      
          Track exception with Sentry
      
      commit 3f01f10d3b7380f0e8ceb3a379d8b6c602e9d6ca
      Merge: 5749c62355f 8a581d53
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Tue Nov 20 17:12:41 2018 +0900
      
          Merge branch 'master-ce' into ignore-failed-pipeline-creation-on-pipeline-schedule
      
      commit 5749c62355f8de62bb4e36ba1e351a78350607c1
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Nov 1 11:14:26 2018 +0900
      
          Create a pipeline even if it is corrupted
      
      commit e01789890b6949b346d40fadef41aa133191cc43
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Wed Oct 31 14:26:09 2018 +0900
      
          Improve production log message
      
      commit f20d698a535f1dc70d5437c20b629fd1d956fb27
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Fri Oct 19 17:11:20 2018 +0900
      
          Fix typo
      
      commit 01323b02ac41ec50bcf237409f2e3c5c214bbfc1
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Thu Oct 18 14:46:44 2018 +0900
      
          Update documents
      
      commit 460337bf4a7e67a35d6c342678b4cfe66710ad56
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Wed Oct 10 13:21:26 2018 +0900
      
          Add changelog
      
      commit a3c4711752fedebfacbdf52da94058524af3c9f4
      Author: Shinya Maeda <shinya@gitlab.com>
      Date:   Wed Oct 10 09:20:06 2018 +0900
      
          Ignore failed pipeline creation in pipeline schedule worker. Instead, logging the event.
      d56d419a
    • Matthias Fechner's avatar
  2. 29 Nov, 2018 30 commits