- 18 Dec, 2019 40 commits
-
-
Alex Kalderimis authored
This adds a new model entity `DesignManagement::DesignAtVersion`, which wraps a design and an associated version. Mechanisms are provided for lazy-finding and validation. These do not have mutable properties, and validate the important constraint that they share an issue Finding DesignManagement::DesignAtVersion objects requires querying both the designs and the versions tables, and is at present more expensive than a single fetch. It also returns an Array instead of a relation, since this is not a ActiveModel object. We validate invariants in find, this ensures we never fetch invalid objects. * Validations: - checking that there is both a design and a version - checking that the design and the version have the same issue - checking that both the design and the version have an issue These validations are checked during `find` and when calling `instantiate` * ID It is important for GraphQL and the front-end that the model has an ID that can be used to lookup each combination, and be used to store this identity on the client. * deleted? and status methods These supplement their analogues in DesignManagement::Design with an awareness of the current version. Thus a DesignManagement::DesignAtVersion as of a version in which is was deleted will respond to `deleted?` appropriately. Callers should be be careful to distinguish between `dav.state == :current` and `!dav.deleted?` - as of a version before a design has been created it will respond with: * `#deleted? == false` * `#status == :not_created_yet` Reflecting the fact that this is not deleted because it has not been created yet. This requires changes to the design and version factories to be able to create valid objects with nil issues, a condition that is found when these objects are being imported.
-
Alex Kalderimis authored
-
Alex Kalderimis authored
-
Alex Kalderimis authored
-
Alex Kalderimis authored
Also includes more namespacing for better readibility and determinism. The presence of a diff_refs method on Version allows us to have better code in Design that does not violate the laws of Demeter so much.
-
Alex Kalderimis authored
This adds a new scope `by_sha` to DesignManagement::Version, and allows it to be used in the version finder.
-
Achilleas Pipinellis authored
Improve the Tags and Releases documentation (OKR) See merge request gitlab-org/gitlab!21755
-
Marcin Sedlak-Jakubowski authored
Previous versions, although named `*12_5`, showed UI from 2016.
-
Thong Kuah authored
Allow shas that are nil to compare to nil shas See merge request gitlab-org/gitlab!21991
-
Achilleas Pipinellis authored
Updated link to prod architecture in the docs See merge request gitlab-org/gitlab!21974
-
Kushal Pandya authored
Disable ESLint rule no-jquery/no-fade inline See merge request gitlab-org/gitlab!21939
-
Winnie Hellmann authored
Ignore all existing offenses of no-jquery/no-fade.
-
Kushal Pandya authored
Added Conan recipe to package details See merge request gitlab-org/gitlab!21247
-
Kushal Pandya authored
Design Repo Sync Status - Filtering/Search See merge request gitlab-org/gitlab!19589
-
Zack Cuddy authored
This sets up vuex actions/mutations Filter bar component This adds the vue compoenent to filter Also had a Typo in template
-
Rémy Coutable authored
Add support for Rust Cargo.toml dependency vizualisation to file blob view See merge request gitlab-org/gitlab!21374
-
Grzegorz Bizon authored
Adds created at to package See merge request gitlab-org/gitlab!20816
-
Grzegorz Bizon authored
Don't show keep path for non archive artifacts See merge request gitlab-org/gitlab!21553
-
Phil Hughes authored
Aligns the autodevops banner with the gl-ui banner See merge request gitlab-org/gitlab!21552
-
Alex Kalderimis authored
Previously, nil == nil was being treated as false. This is both clearly wrong and more seriously broke the equality contract of `DiffRefs`, since the same object would not compare equal to itself it any of its components was nil. Adds a test for commit.diff_refs equality, the motivating case.
-
Heinrich Lee Yu authored
Fix diff file creation See merge request gitlab-org/gitlab!21034
-
Achilleas Pipinellis authored
Added AWS Docker image documentation See merge request gitlab-org/gitlab!21509
-
Etienne Baqué authored
Added doc about providing awscli in a Docker image. Created this documentation as a new CI/ CD page.
-
Natalia Tepluhina authored
Improve error list UI on mobile viewports See merge request gitlab-org/gitlab!21192
-
Olena Horal-Koretska authored
Create adaptive layout for xs viewport
-
Phil Hughes authored
#33543 Videos are not stopped when submitting comment See merge request gitlab-org/gitlab!19556
-
Jannik Lehmann authored
-
Marcel Amirault authored
Add credentials inventory to Admin Area index See merge request gitlab-org/gitlab!21985
-
Evan Read authored
-
Kamil Trzciński authored
Add global rules to match herokuish detect for Auto-DevOps See merge request gitlab-org/gitlab!20267
-
Marcel Amirault authored
Add doco for add resource removal feature See merge request gitlab-org/gitlab!21982
-
Evan Read authored
-
Kamil Trzciński authored
Extract issue details from Sentry::Client See merge request gitlab-org/gitlab!21844
-
Vitali Tatarintev authored
Extract `Sentry::Client#issue_details` into a separate module
-
Marcel Amirault authored
Fix version text See merge request gitlab-org/gitlab!21979
-
Thong Kuah authored
Add liquid template support for Prometheus variable substitution See merge request gitlab-org/gitlab!20793
-
Reuben Pereira authored
Use the liquid template engine since it is designed to be securely used by users to modify template files themselves. Add a render_score_limit so that a user cannot take up all server resources by writing a template that requires a lot of resources to render.
-
James Lopez authored
GraphQL group access avoids SSO session checks Closes #35795 See merge request gitlab-org/gitlab!21922
-
Natalia Tepluhina authored
Merge branch '35073-refactor-design_management-pages-index-vue-to-use-apollomutation-component' into 'master' Refactor design_management/pages/index.vue to use ApolloMutation component See merge request gitlab-org/gitlab!21022
-
Tom Quirk authored
-