- 20 Jul, 2017 1 commit
-
-
Lin Jen-Shin authored
-
- 19 Jul, 2017 6 commits
-
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
I realized where the N+1 queries were actually coming from project.protected_branches, but how come we cannot preload this, or cache this at all? Then I found that this is somehow a Rails limitation. What we're doing before, eventually come to: project.protected_branches.matching But why it's not cached? (project.protected_branches.loaded? is always false) It's because matching is a class method, which is called on the proxy. In this case, Rails cannot cache the result. I don't know if this is possible to implement or not, because clearly this would require some tricks to implement class methods on associations. So instead, we could just pass project.protected_branches to ProtectedRef.matching, then it would work regularly. With this change, there's no more N+1 queries.
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
- 18 Jul, 2017 21 commits
-
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
Also make sure pipeline would also check against tag as well
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
* upstream/master: (25 commits) Remove unneeded asserts and add tests for inactive RequestStore Rename the methods to make it fit with current name Follow feedback on the merge request Make sure it checks against the tag only when it's a tag Renamed Gitaly services fix transient rspec failure due to Poll.js race condition Refactor variables initialization in dropzone_input.js cache the cache key... avoid #respond_to? in Cache.id_for cache DeclarativePolicy.class_for at the class level Update 9.3-to-9.4.md fix padding on filtered search dropdown. Styles should only apply to li in list Cache Note#notable for commits and fix tests Add changelog entry Update the comments for the new functionality Use RequestStoreWrap for Commit#author Skip dead jobs queue for web hooks and project services Add RequestStoreWrap to cache via RequestStore Don't track cached queries in Gitlab::PerformanceBar::PeekQueryTracker Add changelog entry ...
-
Rémy Coutable authored
Add RequestCache to cache via RequestStore See merge request !12920
-
Lin Jen-Shin authored
-
Grzegorz Bizon authored
Protect manual actions against protected tag too Closes #34927 See merge request !12908
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Sean McGivern authored
Perf: Improve performance of basic ruby ops in DeclarativePolicy See merge request !12922
-
Phil Hughes authored
fix transient rspec failure due to Poll.js race condition Closes #35225 See merge request !12930
-
Lin Jen-Shin authored
-
Sean McGivern authored
Renamed Gitaly services Closes gitaly#379 See merge request !12854
-
Andrew Newdigate authored
-
Sean McGivern authored
Update 9.3-to-9.4.md See merge request !12925
-
Simon Knox authored
don't treat aborted requests as failures, they are often triggered during unload (e.g after clicking a link)
-
Clement Ho authored
Refactor variables initialization in dropzone_input.js Closes #29901 See merge request !12768
-
Brandon Everett authored
-
- 17 Jul, 2017 12 commits
-
-
http://jneen.net/ authored
-
http://jneen.net/ authored
-
http://jneen.net/ authored
-
Andrew Newdigate authored
-
Jacob Schatz authored
Remove coffee-rails gem Closes #34831 See merge request !12715
-
Annabel Dunstone Gray authored
fix padding on filtered search Closes #35177 See merge request !12913
-
Simon Knox authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
We also try to use instance variable to cache the result if RequestStore is not available, so we could keep the same logic, using the same cache key. Also introduce a way to specify method specific cache key
-
Sean McGivern authored
Resolve "Peek performance bar doesn't count cached queries, but shows them" Closes #34940 See merge request !12915
-