1. 14 Jul, 2016 4 commits
    • Sean McGivern's avatar
      Ensure MR approvals don't get stuck · ee751a59
      Sean McGivern authored
      The potential approvers of an MR are:
      
      - The users in the approvers list (excluding other permissions, as long
        as they can see the MR).
      - Users with developer access or higher on the project or the group
        containing the project.
      
      This number is reduced by:
      
      - The author not being able to approve their own MR.
      - Users who have already approved the MR.
      
      If the number of potential approvers is less than the number of
      approvals left by the normal count, pick the number of potential
      approvers instead, so the MR isn't 'stuck' in a state where it needs
      approval but no-one can approve it.
      ee751a59
    • Sean McGivern's avatar
      Prevent author from approving their own MR · a250142c
      Sean McGivern authored
      - Don't include the author when checking approvers remaining.
      - Don't allow the author to be added as an approver when editing an MR.
      - Don't allow the current user (who will be the author) to be added as
        an approver when creating an MR.
      a250142c
    • Sean McGivern's avatar
      Allow skipping users in autocomplete · 3758f751
      Sean McGivern authored
      Pass an array of user IDs in the `skip_users` param to have them
      excluded from the results (unless they are explicitly included through
      the `current_user` or `author_id` params).
      3758f751
    • Sean McGivern's avatar
      Fix suggested approvers · 8bdf633f
      Sean McGivern authored
      Previously, this would pick the least-frequent contributors to the
      changed files, rather than the most frequent.
      8bdf633f
  2. 13 Jul, 2016 11 commits
  3. 12 Jul, 2016 25 commits