1. 14 Jan, 2020 1 commit
  2. 27 Dec, 2019 24 commits
  3. 26 Dec, 2019 9 commits
  4. 25 Dec, 2019 6 commits
    • Lin Jen-Shin's avatar
      Merge branch 'sh-speed-up-build-artifact-entry' into 'master' · 5a8ca1cb
      Lin Jen-Shin authored
      Speed up path generation with build artifacts
      
      Closes #121929
      
      See merge request gitlab-org/gitlab!22257
      5a8ca1cb
    • Stan Hu's avatar
      Merge branch '121714-fix-sentry-stack-trace-highlight-for-php' into 'master' · 4c2e2ad4
      Stan Hu authored
      Fix stack trace highlight for PHP
      
      Closes #121714
      
      See merge request gitlab-org/gitlab!22258
      4c2e2ad4
    • Justin Ho's avatar
      Replace FA cog icon with GitLab settings icon · 18cdc044
      Justin Ho authored
      18cdc044
    • Vitali Tatarintev's avatar
      Add a change log entry · 6edd208b
      Vitali Tatarintev authored
      6edd208b
    • Vitali Tatarintev's avatar
      Fix stack trace highlight for PHP · 707d2dcd
      Vitali Tatarintev authored
      Pick a first alternative language for Sentry stack trace highlight,
      when Rouge can't decide which lexer to choose.
      
      `StackTraceHighlightDecorator` now works with PHP and Hack languages
      707d2dcd
    • Stan Hu's avatar
      Speed up path generation with build artifacts · a11551c2
      Stan Hu authored
      Previously it would take seconds to render the pipeline index JSON
      (/gitlab-org/gitlab/pipelines.json) in the GitLab project. Apparently,
      we render over 5000 paths for `BuildArtifactEntity`, and generation of
      these paths dominated the request time.
      
      The Rails path helpers are slow because they check the namespace and
      project parameters against large regular expressions, which include
      `TOP_LEVEL_ROUTES` and `PROJECT_WILDCARD_ROUTES`, respectively.
      
      We can speed this up by generating the paths directly with
      strings. While this isn't ideal, this results in a 10x improvement in
      speed:
      
      ```
      Calculating -------------------------------------
                      orig    86.000  i/100ms
                       new     1.272k i/100ms
      -------------------------------------------------
                      orig      1.343k (±13.8%) i/s -      6.536k
                       new     13.756k (±15.3%) i/s -     67.416k
      
      Comparison:
                       new:    13756.3 i/s
                      orig:     1343.3 i/s - 10.24x slower
      ```
      
      To prevent these helper methods from breaking if the routes ever change,
      we add tests to ensure that the results are the same.
      
      Closes https://gitlab.com/gitlab-org/gitlab/issues/121929
      a11551c2