CE upstream - Wednesday

Closes gitaly#402, omnibus-gitlab#2658, gitaly#443, gitaly#437, gitlab-com/infrastructure#1946, and gitaly#416

See merge request !2645

Fix line numbers not matching up to code in code viewer.

Closes #29811

See merge request !13403

Remove affix plugin from issuable sidebar with new navigation

See merge request !13449

Render new issue link in failed job as a regular link instead of a UJS one

Closes #36158

See merge request !13450

Added a template for database changes

See merge request !12355

Add comment for lfs-enabled

See merge request !2653

Fix conflicting redirect search

See merge request !13357

This template includes a rather large (but fairly easy to follow)
checklist. This checklist should hopefully take away quite a bit of work
from database specialists by requiring authors to provide all the
necessary info.

[ci skip]

Re-enable RSpec/FilePath cops for EE spec files

See merge request !2652

Aligns OR separater to center properly

Closes #36185

See merge request !13446

Include RE2 in the upgrade docs

See merge request !13448

Remove unused `redirect_to_external_issue_tracker` method

See merge request !13444

Updating Gemfile.lock for rubocop-rspec dependecy.

See merge request !13410

This isn't required with the new navigation as it is always position fixed so we are just creating a scroll event listener that will never actually do anything

Since after we moved them into the standalone directory,
we could again follow the rule. Also, move a file which
was misplaced.

The wrong resolution was in 5eae5f38.
Signed-off-by: Rémy Coutable <remy@rymai.me>

Fix wrong resolution of app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_wip.js

The wrong resoluation was from e2c085aa.
Signed-off-by: Rémy Coutable <remy@rymai.me>

alternative route for download archive

See merge request !13439

Signed-off-by: Rémy Coutable <remy@rymai.me>

Fix the sticky changes bar on commits page

See merge request !13343

Signed-off-by: Rémy Coutable <remy@rymai.me>

Removed display styles when hiding the fly out navigation

Closes #36224

See merge request !13431

Its usage has been removed at 2fa22a07.

Add missing command to compile GetText files

See merge request !13437

Signed-off-by: Rémy Coutable <remy@rymai.me>

In gitlab-org/gitlab-ce!13283 extra properties were added to
BasicProjectDetails. This entity is used by the Board entity and the
API boards spec verifies the JSON schema for the
`/projects/:id/boards` endpoint.

So add the extra properties to the schema file.

A better solution would have been to extract the project into a
separate file. But that is outside the current scope.

This also correctly fixes the conflict introduced in 3c8b2ae1, and
resolved in 55a5f2ab49.

Based on:

1. 0e85c50252dd43148488eacde57a882bd0b0a4ec
2. d19eaaed2d48e008abf94301a98e8ee806219071
3. 44c7f872219659d107fc01a62c8b5d6778ebbd74
Signed-off-by: Rémy Coutable <remy@rymai.me>

Based on d19eaaed2d48e008abf94301a98e8ee806219071.
Signed-off-by: Rémy Coutable <remy@rymai.me>

Based on d19eaaed2d48e008abf94301a98e8ee806219071.
Signed-off-by: Rémy Coutable <remy@rymai.me>

Based on d19eaaed2d48e008abf94301a98e8ee806219071.
Signed-off-by: Rémy Coutable <remy@rymai.me>