An error occurred fetching the project authors.
- 18 Feb, 2020 1 commit
-
-
Oswaldo Ferreira authored
This commit's goal is to add a cop (Scalability::IdempotentWorker) that will catch all workers that don't call idempotent! in its scope. Calling it will label the worker as idempotent, which will end up in our Sidekiq logs for further visibility. This also introduces a shared example and a perform_multiple helper method for executing jobs multiple times through unit tests. Also in this commit we set an example in an already idempotent worker ExpireJobCacheWorker. For this worker we call idempotent! in its scope and add tests with the new test helpers.
-
- 06 Feb, 2020 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 05 Feb, 2020 2 commits
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Simply set `RETRIES=1 bin/rspec ...` and the example will be retried once. This can be useful when locally debugging examples that only pass on retries on the CI, without having to set `CI=1`, which has side-effects. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 03 Feb, 2020 1 commit
-
-
Bob Van Landuyt authored
The `with_request_store` metadata already lived inside `spec_helper` so we don't need another one. This also replaces the `before` and `after` blocks for handling the request store with a single around block. The advantage of that is that this `around` block would be wrapped around any `around` blocks defined inside the specs. Which I think is more predictable behaviour.
-
- 03 Jan, 2020 1 commit
-
-
Bob Van Landuyt authored
This provides context to all requests made to Rails controllers or grape endpoints. Doing this starts a new `Labkit::Context`, to which we can provide a namespace, project and user. We're currently setting the following values: - Web requests: In the ApplicationController we wrap the entire request in a `with_context`. - user: based on the `auth_user` if there is one - project: We try to read the @project instance variable of the controller. - namespace: We try to read the @group instance variable of the controller. If there was none, but the project was set, we'll use that path to set the namespace - API requests: The application context is pushed in a before block setting the following values: - user: to `current_user` if there is one - project: to `@project` - namespace: to `@group` - Internal API requests: the application context is pushed in a before block: - user: When to the user set in `Api::Support::GitAccessActor` - project: to @project if it was available The 3 supported attributes for a context are read lazily when required. This also replaces the existing correlation middlewares with the new Labkit::Context middlewares. The rack middleware wraps each rack request in an overarching context that adds the correlation id. The context is cleaned up after the request, so we're sure all child contexts are cleaned up as well. The sidekiq client middleware will write the context into the job that goes into redis when a job is scheduled. The sidekiq server middleware will then re-instantiate this context so the job gets executed with the same context that was alive when it was scheduled. This means that any new job scheduled from sidekiq would also have this context.
-
- 13 Dec, 2019 1 commit
-
-
Balakumar authored
-
- 19 Nov, 2019 1 commit
-
-
bogdanvlviv authored
Since the app supports PostgreSQL only there is no need in this variable.
-
- 05 Nov, 2019 1 commit
-
-
Robert Speicher authored
Only enabled outside of CI environments.
-
- 21 Oct, 2019 1 commit
-
-
allison.browne authored
-
- 17 Oct, 2019 2 commits
-
-
Alex Buijs authored
Signing up fails in tests when the signup form is submitted to quick, so disable it by default in tests.
-
Alex Buijs authored
instead of a custom helper
-
- 15 Oct, 2019 1 commit
-
-
Kushal Pandya authored
Adds Vue Issuablr Sidebar app containing wrapper component for Right Sidebar.
-
- 10 Oct, 2019 2 commits
-
-
Arturo Herrero authored
expect_next_instance_of and allow_next_instance_of use the same code expect the target (expect or allow).
-
Arturo Herrero authored
-
- 06 Oct, 2019 1 commit
-
-
gfyoung authored
Partially addresses: https://gitlab.com/gitlab-org/gitlab/issues/27703
-
- 04 Oct, 2019 1 commit
-
-
Heinrich Lee Yu authored
Use let_it_be and before_all to reduce queries in specs
-
- 02 Oct, 2019 1 commit
-
-
Gabriel Mazetto authored
-
- 01 Oct, 2019 1 commit
-
-
Thong Kuah authored
Mass-replace set for let_it_be.
-
- 26 Sep, 2019 1 commit
-
-
Diego Louzán authored
Require admins to enter admin-mode by re-authenticating before performing administrative operations
-
- 17 Sep, 2019 1 commit
-
-
Igor authored
Extract the logic into a separate service and stub it It speeds up the creating of merge requests
-
- 05 Sep, 2019 2 commits
-
-
Ash McKenzie authored
RailsHelpers.stub_rails_env takes care of stubbing Rails.env
-
Ash McKenzie authored
RailsHelpers.stub_rails_env takes care of stubbing Rails.env
-
- 03 Sep, 2019 1 commit
-
-
Igor authored
It performs an expensive operation, but isn't required in most of tests
-
- 02 Sep, 2019 1 commit
-
-
Igor Drozdov authored
It performs an expensive operation, but isn't required in most of tests
-
- 30 Aug, 2019 1 commit
-
-
Yorick Peterse authored
-
- 11 Aug, 2019 1 commit
-
-
Giorgenes Gelatti authored
-
- 02 Aug, 2019 1 commit
-
-
Toon Claes authored
In f59438c0 we changed how quarantined specs are excluded. But that made it impossible to run them by providing `--tag quarantine`, this changes that.
-
- 25 Jul, 2019 3 commits
-
-
Heinrich Lee Yu authored
These are not required because MySQL is not supported anymore
-
Heinrich Lee Yu authored
These are not required because MySQL is not supported anymore
-
Francisco Javier López authored
When we can't resolve the hostname or it is invalid, we shouldn't even perform the request. This fix also fixes the problem the SSRF rebinding attack. We can't stub feature flags outside example blocks. Nevertheless, there are some actions that calls the UrlBlocker, that are performed outside example blocks, ie: `set` instruction. That's why we have to use some signalign mechanism outside the scope of the specs.
-
- 23 Jul, 2019 2 commits
-
-
Nick Thomas authored
None of this code can be reached any more, so it can all be removed
-
Nick Thomas authored
None of this code can be reached any more, so it can all be removed
-
- 18 Jul, 2019 1 commit
-
-
Markus Koller authored
When passing start_branch on committing from the WebIDE, it's possible that the branch has changed since editing started, which results in the change being applied on top of the latest commit in the branch and overwriting the new changes. By passing the start_sha instead we can make sure that the change is applied on top of the commit which the user started editing from.
-
- 16 Jul, 2019 1 commit
-
-
John Cai authored
Whenever we use the rugged implementation, we are going straight to disk so we want to bypass the disk access check.
-
- 15 Jul, 2019 1 commit
-
-
Francisco Javier López authored
When we can't resolve the hostname or it is invalid, we shouldn't even perform the request. This fix also fixes the problem the SSRF rebinding attack. We can't stub feature flags outside example blocks. Nevertheless, there are some actions that calls the UrlBlocker, that are performed outside example blocks, ie: `set` instruction. That's why we have to use some signalign mechanism outside the scope of the specs.
-
- 12 Jul, 2019 4 commits
-
-
Aleksei Lipniagov authored
Log memory stats after running each spec file and compile the report.
-
Aleksei Lipniagov authored
Log memory stats after running each spec file and compile the report.
-
Heinrich Lee Yu authored
Uses Rails transactional tests instead of DatabaseCleaner transaction strategy because that doesn't work with JS tests
-
Heinrich Lee Yu authored
Uses Rails transactional tests instead of DatabaseCleaner transaction strategy because that doesn't work with JS tests
-