An error occurred fetching the project authors.
- 01 Aug, 2017 1 commit
-
-
Gabriel Mazetto authored
-
- 24 Jul, 2017 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by:
Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 17 Jul, 2017 1 commit
-
-
Filipa Lacerda authored
-
- 14 Jul, 2017 1 commit
-
-
Filipa Lacerda authored
-
- 29 Jun, 2017 1 commit
-
-
Douwe Maan authored
-
- 28 Jun, 2017 1 commit
-
-
Douwe Maan authored
-
- 23 Jun, 2017 1 commit
-
-
Nick Thomas authored
-
- 21 Jun, 2017 2 commits
-
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
- 14 Jun, 2017 2 commits
-
-
Robert Speicher authored
-
Robert Speicher authored
-
- 09 Jun, 2017 2 commits
-
-
Oswaldo Ferreira authored
-
Oswaldo Ferreira authored
-
- 08 Jun, 2017 4 commits
-
-
Oswaldo Ferreira authored
-
Oswaldo Ferreira authored
-
Sean McGivern authored
When an MR or issue and there's a conflict, we rescue the StaleObjectError and render the edit page again. However, for MRs in EE, we need to ensure that @suggested_approvers is set before that happens, otherwise the view will fail to render.
-
Sean McGivern authored
This reverts commit b34bc6fe, reversing changes made to e9fcae37.
-
- 07 Jun, 2017 3 commits
-
-
Oswaldo Ferreira authored
-
Oswaldo Ferreira authored
-
Oswaldo Ferreira authored
-
- 06 Jun, 2017 2 commits
-
-
Paul Charlton authored
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 02 Jun, 2017 1 commit
-
-
Nick Thomas authored
Various Rails initializers (metrics, sentry, etc) are run before migrations, which can lead to a mismatch between app/models/application_settings.rb and schema.
-
- 26 May, 2017 1 commit
-
-
Nick Thomas authored
-
- 25 May, 2017 1 commit
-
-
Nick Thomas authored
-
- 23 May, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 22 May, 2017 2 commits
-
-
Felipe Artur authored
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 20 May, 2017 2 commits
-
-
Oswaldo Ferreira authored
-
Oswaldo Ferreira authored
-
- 19 May, 2017 2 commits
-
-
Oswaldo Ferreira authored
-
Oswaldo Ferreira authored
-
- 18 May, 2017 1 commit
-
-
Oswaldo Ferreira authored
-
- 17 May, 2017 1 commit
-
-
Yorick Peterse authored
This commit introduces the usage of Common Table Expressions (CTEs) to efficiently retrieve nested group hierarchies, without having to rely on the "routes" table (which is an _incredibly_ inefficient way of getting the data). This requires a patch to ActiveRecord (found in the added initializer) to work properly as ActiveRecord doesn't support WITH statements properly out of the box. Unfortunately MySQL provides no efficient way of getting nested groups. For example, the old routes setup could easily take 5-10 seconds depending on the amount of "routes" in a database. Providing vastly different logic for both MySQL and PostgreSQL will negatively impact the development process. Because of this the various nested groups related methods return empty relations when used in combination with MySQL. For project authorizations the logic is split up into two classes: * Gitlab::ProjectAuthorizations::WithNestedGroups * Gitlab::ProjectAuthorizations::WithoutNestedGroups Both classes get the fresh project authorizations (= as they should be in the "project_authorizations" table), including nested groups if PostgreSQL is used. The logic of these two classes is quite different apart from their public interface. This complicates development a bit, but unfortunately there is no way around this. This commit also introduces Gitlab::GroupHierarchy. This class can be used to get the ancestors and descendants of a base relation, or both by using a UNION. This in turn is used by methods such as: * Namespace#ancestors * Namespace#descendants * User#all_expanded_groups Again this class relies on CTEs and thus only works on PostgreSQL. The Namespace methods will return an empty relation when MySQL is used, while User#all_expanded_groups will return only the groups a user is a direct member of. Performance wise the impact is quite large. For example, on GitLab.com Namespace#descendants used to take around 580 ms to retrieve data for a particular user. Using CTEs we are able to reduce this down to roughly 1 millisecond, returning the exact same data. == On The Fly Refreshing Refreshing of authorizations on the fly (= when users.authorized_projects_populated was not set) is removed with this commit. This simplifies the code, and ensures any queries used for authorizations are not mutated because they are executed in a Rails scope (e.g. Project.visible_to_user). This commit includes a migration to schedule refreshing authorizations for all users, ensuring all of them have their authorizations in place. Said migration schedules users in batches of 5000, with 5 minutes between every batch to smear the load around a bit. == Spec Changes This commit also introduces some changes to various specs. For example, some specs for ProjectTeam assumed that creating a personal project would _not_ lead to the owner having access, which is incorrect. Because we also no longer refresh authorizations on the fly for new users some code had to be added to the "empty_project" factory. This chunk of code ensures that the owner's permissions are refreshed after creating the project, something that is normally done in Projects::CreateService.
-
- 12 May, 2017 2 commits
-
-
Sean McGivern authored
I don't know why this happens exactly, but given an upstream and fork repository from a customer, both of which required GC, resolving conflicts would corrupt the fork so badly that it couldn't be cloned. This isn't a perfect fix for that case, because the MR may still need to be merged manually, but it does ensure that the repository is at least usable. My best guess is that when we generate the index for the conflict resolution (which we previously did in the target project), we obtain a reference to an OID that doesn't exist in the source, even though we already fetch the refs from the target into the source. Explicitly setting the source project as the place to get the merge index from seems to prevent repository corruption in this way.
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 09 May, 2017 1 commit
-
-
Fatih Acet authored
-
- 08 May, 2017 3 commits
-
-
Felipe Artur authored
-
Felipe Artur authored
-
Dmitriy Zaporozhets authored
-