1. 04 Jun, 2020 1 commit
  2. 03 Jun, 2020 2 commits
  3. 02 Jun, 2020 3 commits
    • Nick Thomas's avatar
      Test the behaviour of SendURL with less-common upstreams · c21c2cbf
      Nick Thomas authored
      Two cases in particular, lacking a `Content-Type`,  gave us trouble:
      
      * Transfer-Encoding: chunked
      * No content-type and no transfer-encoding
      
      Both of these are permitted by the HTTP RFC (cases 3 and 7), and we
      can talk to arbitrary HTTP servers via sendurl, so it's imperative that
      we handle them correctly. This commit adds tests for both cases.
      
      Responses of the latter type are transparently converted to responses
      of the former type. This is an automatic behaviour of the Go stdlib,
      which doesn't really support making the second type of response
      directly. Since Transfer-Encoding is a hop-by-hop header, this type of
      encoding is extremely common, and we're still streaming, instead of
      accumulating, the data, I think this is acceptable.
      c21c2cbf
    • Georges-Etienne Legendre's avatar
    • Igor Drozdov's avatar
      Send hover tokens instead of raw html · c02e372a
      Igor Drozdov authored
      It's a more secure way to display documentation hovers
      Rendering html is also a natural task for frontend
      c02e372a
  4. 01 Jun, 2020 3 commits
  5. 29 May, 2020 5 commits
  6. 28 May, 2020 7 commits
  7. 27 May, 2020 6 commits
  8. 26 May, 2020 3 commits
  9. 22 May, 2020 2 commits
  10. 21 May, 2020 6 commits
  11. 19 May, 2020 1 commit
  12. 18 May, 2020 1 commit
    • Sami Hiltunen's avatar
      delay PostUploadPack response until request is fully read · 2fe99f66
      Sami Hiltunen authored
      Git and Gitaly stream upload-pack response data as soon as it is
      available. Some HTTP clients do not support the response being streamed
      back while the server is still reading from the request body. To avoid
      this, the request was buffered in to a temporary file before passing it
      to Gitaly for handling. The buffer had a maximum size of 10MB, which is
      now reached by requests to large repositories. These requests were then
      truncated, causing Git to fail.
      
      This commit fixes the problem by removing the request buffering and the
      maximum size. Instead, the response is buffered in to a temporary file
      until the request body is fully read, thus avoiding the problem of
      streaming the request and the response simultaneously.
      2fe99f66