• Robert Speicher's avatar
    Merge branch 'rs-fix-ldap-2fa-login' into 'master' · 00cae51e
    Robert Speicher authored
    Fix 2FA-based login for LDAP users
    
    The OTP input form is shared by both LDAP and standard logins, but when
    coming from an LDAP-based form, the form parameters aren't nested in a
    Hash based on the `resource_name` value.
    
    Now we check for a nested `remember_me` parameter and use that if it
    exists, or fall back to the non-nested parameters if it doesn't.
    
    Somewhat confusingly, the OTP input form _does_ nest parameters under
    the `resource_name`, regardless of what type of login we're coming from,
    so that allows everything else to work as normal.
    
    Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/18185
    
    See merge request !4493
    00cae51e
Name
Last commit
Last update
app Loading commit data...
bin Loading commit data...
builds Loading commit data...
config Loading commit data...
db Loading commit data...
doc Loading commit data...
docker Loading commit data...
features Loading commit data...
fixtures/emojis Loading commit data...
generator_templates/active_record/migration Loading commit data...
lib Loading commit data...
log Loading commit data...
public Loading commit data...
scripts Loading commit data...
shared Loading commit data...
spec Loading commit data...
tmp Loading commit data...
vendor Loading commit data...
.csscomb.json Loading commit data...
.flayignore Loading commit data...
.foreman Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitlab-ci.yml Loading commit data...
.hound.yml Loading commit data...
.pkgr.yml Loading commit data...
.rspec Loading commit data...
.rubocop.yml Loading commit data...
.ruby-version Loading commit data...
.scss-lint.yml Loading commit data...
.simplecov Loading commit data...
.teatro.yml Loading commit data...
CHANGELOG Loading commit data...
CONTRIBUTING.md Loading commit data...
GITLAB_SHELL_VERSION Loading commit data...
GITLAB_WORKHORSE_VERSION Loading commit data...
Gemfile Loading commit data...
Gemfile.lock Loading commit data...
LICENSE Loading commit data...
MAINTENANCE.md Loading commit data...
PROCESS.md Loading commit data...
Procfile Loading commit data...
README.md Loading commit data...
Rakefile Loading commit data...
VERSION Loading commit data...
config.ru Loading commit data...
doc_styleguide.md Loading commit data...
docker-compose.yml Loading commit data...