• Douwe Maan's avatar
    Merge branch 'todos-filter-project-delete' into 'master' · a834be61
    Douwe Maan authored
    Ensure we don't show TODOS for projects pending delete
    
    Joins the todos on the projects table in order to run the default scope. Also includes a where clause because the default scope is being removed soon.
    
    An alternative approach, more like the Issues page, would be to filter down the list by passing user.authorized_projects into the where clause.
    
    Or we could just be more defensive in the view when iterating.
    
    Todos page throws 500 error for users with todos in a project pending deletion.
    
    Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/17813
    
    cc\ @stanhu
    
    See merge request !4300
    a834be61
Name
Last commit
Last update
app Loading commit data...
bin Loading commit data...
builds Loading commit data...
config Loading commit data...
db Loading commit data...
doc Loading commit data...
docker Loading commit data...
features Loading commit data...
fixtures/emojis Loading commit data...
generator_templates/active_record/migration Loading commit data...
lib Loading commit data...
log Loading commit data...
public Loading commit data...
scripts Loading commit data...
shared Loading commit data...
spec Loading commit data...
tmp Loading commit data...
vendor Loading commit data...
.csscomb.json Loading commit data...
.flayignore Loading commit data...
.foreman Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitlab-ci.yml Loading commit data...
.hound.yml Loading commit data...
.pkgr.yml Loading commit data...
.rspec Loading commit data...
.rubocop.yml Loading commit data...
.ruby-version Loading commit data...
.scss-lint.yml Loading commit data...
.simplecov Loading commit data...
.teatro.yml Loading commit data...
CHANGELOG Loading commit data...
CONTRIBUTING.md Loading commit data...
GITLAB_SHELL_VERSION Loading commit data...
GITLAB_WORKHORSE_VERSION Loading commit data...
Gemfile Loading commit data...
Gemfile.lock Loading commit data...
LICENSE Loading commit data...
MAINTENANCE.md Loading commit data...
PROCESS.md Loading commit data...
Procfile Loading commit data...
README.md Loading commit data...
Rakefile Loading commit data...
VERSION Loading commit data...
config.ru Loading commit data...
doc_styleguide.md Loading commit data...
docker-compose.yml Loading commit data...