- 21 Aug, 2018 1 commit
-
-
Kirill Smelkov authored
[ Sent upstream: https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/40 This was filed upstream but decided the better way to go is to configure default git templates to be just empty. Until we implement that, we continue to carry this patch as NXD ] gitlab-shell uses completely own whole set of git hooks and just symlinks repo.git/hooks to path/to/gitlab-shell/hooks/. Original hooks that git added there - when initializing repository - from its template, and which are by default deactivated, are currently moved to repos.git/hooks.old.<timestamp>, e.g. $ ls -F nexedi/helloweb.git/ config description HEAD hooks@ --> ...path/to/gitlab-shell/hooks/ hooks.old.1446564288/ info/ packed-refs refs/ $ ls -F nexedi/helloweb.git/hooks.old.1446564288/ applypatch-msg.sample* post-update.sample* pre-commit.sample* pre-push.sample* update.sample* commit-msg.sample* pre-applypatch.sample* prepare-commit-msg.sample* pre-rebase.sample* On the other hand, hooks.old.<timestamp> are not used anywhere and are left there "just in case". But what is the point to keep those pristine samples git creates by default? And we are sure those files are always results of gitlab-shell initializing a repository, as it is gitlab-shell's job to create/remove/update/etc repositories. So do not keep old hooks, remove them. P.S. The patch that introduced whole-hooks-dir-symlinking is db81327b (Symlink the whole hooks directory). /cc @dzaporozhets, @jacobvosmaer
-
- 09 Aug, 2018 4 commits
-
-
Nick Thomas authored
-
Stan Hu authored
Fix two regressions in SSH certificate support (8.1) See merge request gitlab-org/gitlab-shell!226
-
Nick Thomas authored
-
Nick Thomas authored
-
- 08 Aug, 2018 1 commit
-
-
Ævar Arnfjörð Bjarmason authored
Fix two regressions in my 2e8b6702 ("Add support for SSH certificate authentication", 2018-06-14) merged in gitlab-org/gitlab-shell!207. This fixes the issue noted in gitlab-org/gitlab-shell#145 where the command-line contains things other than the key/user/username, and also a regression where SSH certificates are being used, and the username presented in the key is unknown to GitLab. In that case, we should log the user in as "Anonymous" (on an instance that allows public access), but because of how the error checking around api.discover() was implemented we ended up erroring out instead.
-
- 01 Aug, 2018 6 commits
-
-
Nick Thomas authored
Release v8.1.0 See merge request gitlab-org/gitlab-shell!219
-
Nick Thomas authored
-
Nick Thomas authored
Add Git protocol v2 See merge request gitlab-org/gitlab-shell!217
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
- 31 Jul, 2018 3 commits
-
-
Nick Thomas authored
Release GitLab Shell v8.0.0 See merge request gitlab-org/gitlab-shell!218
-
Nick Thomas authored
-
Nick Thomas authored
Add support for ssh certificates Closes gitlab-ce#34572 See merge request gitlab-org/gitlab-shell!207
-
- 27 Jul, 2018 3 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
Update gitaly-proto to 0.109.0 See merge request gitlab-org/gitlab-shell!216
-
James Lopez authored
-
- 26 Jul, 2018 1 commit
-
-
Ævar Arnfjörð Bjarmason authored
This along with the code submitted to gitlab-ce in the gitlab-org/gitlab-ce! MR implements SSH certificate authentication. See the docs added to gitlab-ce for why and how to enable this. This, along with that MR, closes gitlab-org/gitlab-ce#3457 Implementation notes: - Because it's easy to do, and because an earlier nascent version of this would pass user-ID to gitlab-shell, that's now supported, even though the SSH certificate authentication uses username-USERNAME. - The astute reader will notice that not all the API calls in gitlab-ce's lib/api/internal.rb support a "username" argument, some only support "user_id". There's a few reasons for this: a) For this to be efficient, I am bending over backwards to avoid extra API calls when using SSH certificates. Therefore the /allowed API call will now return a "user id" to us if we're allowed to proceed further. This is then fed to existing APIs that would only be called after a successful call to /allowed. b) Not all of the git-shell codepaths go through /internal/allowed, or ever deal with a repository, e.g. the argument-less "Welcome to GitLab", and /internal/2fa_recovery_codes. These need to use /internal/discover to figure out details about the user, so support looking that up by username. c) Once we have the "user id", the GL_ID gets passed down to e.g. user-authored hooks. I don't want to have those all break by having to handle a third GL_ID mode of "username" in addition to the current "key id" and "user id".
-
- 24 Jul, 2018 2 commits
-
-
Rémy Coutable authored
Add script to update vendored go libs See merge request gitlab-org/gitlab-shell!212
-
Jacob Vosmaer (GitLab) authored
-
- 23 Jul, 2018 1 commit
-
-
Robert Speicher authored
Refactor for re-usability for future MR's See merge request gitlab-org/gitlab-shell!210
-
- 20 Jul, 2018 8 commits
-
-
Ash McKenzie authored
-
Ash McKenzie authored
This was not posing an issue during CI, but was an issue locally.
-
Ash McKenzie authored
-
Ash McKenzie authored
-
Ash McKenzie authored
-
Ash McKenzie authored
-
Ash McKenzie authored
-
Ash McKenzie authored
-
- 11 Jul, 2018 1 commit
-
-
Stan Hu authored
-
- 20 Jun, 2018 2 commits
-
-
Nick Thomas authored
Run go tests in CI with Go 1.9 and 1.10 See merge request gitlab-org/gitlab-shell!208
-
Jacob Vosmaer authored
-
- 13 Jun, 2018 1 commit
-
-
Douwe Maan authored
Resolve "NoMethodError for nil in pre-receive hook" Closes #138 See merge request gitlab-org/gitlab-shell!206
-
- 12 Jun, 2018 1 commit
-
-
Nick Thomas authored
-
- 11 Jun, 2018 2 commits
-
-
Robert Speicher authored
Update LICENSE year to 2018 [ci skip] See merge request gitlab-org/gitlab-shell!205
-
Winnie Hellmann authored
-
- 04 Jun, 2018 1 commit
-
-
Douwe Maan authored
allow long strings to remain intact while parsing broadcast message See merge request gitlab-org/gitlab-shell!202
-
- 01 Jun, 2018 1 commit
-
-
Cameron Crockett authored
Added fix for msg nil edge case. fixed comment wording code review issues, bumped version and changelog entry Fixed rebase issues Moved strip out of the function Fixes for code review comments Removed trailing whitespaces
-
- 28 May, 2018 1 commit
-
-
Douwe Maan authored
Display the username instead of fullname Closes #131 See merge request gitlab-org/gitlab-shell!204
-