edac_device_sysfs.c 19.9 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
/*
 * file for managing the edac_device class of devices for EDAC
 *
 * (C) 2007 SoftwareBitMaker(http://www.softwarebitmaker.com)
 * This file may be distributed under the terms of the
 * GNU General Public License.
 *
 * Written Doug Thompson <norsk5@xmission.com>
 *
 */

#include <linux/ctype.h>

#include "edac_core.h"
#include "edac_module.h"

#define EDAC_DEVICE_SYMLINK	"device"

#define to_edacdev(k) container_of(k, struct edac_device_ctl_info, kobj)
#define to_edacdev_attr(a) container_of(a, struct edacdev_attribute, attr)

/************************** edac_device sysfs code and data **************/

/*
 * Set of edac_device_ctl_info attribute store/show functions
 */

/* 'log_ue' */
29 30
static ssize_t edac_device_ctl_log_ue_show(struct edac_device_ctl_info
					   *ctl_info, char *data)
31
{
32
	return sprintf(data, "%u\n", ctl_info->log_ue);
33 34
}

35 36 37
static ssize_t edac_device_ctl_log_ue_store(struct edac_device_ctl_info
					    *ctl_info, const char *data,
					    size_t count)
38 39
{
	/* if parameter is zero, turn off flag, if non-zero turn on flag */
40
	ctl_info->log_ue = (simple_strtoul(data, NULL, 0) != 0);
41

42
	return count;
43 44 45
}

/* 'log_ce' */
46 47
static ssize_t edac_device_ctl_log_ce_show(struct edac_device_ctl_info
					   *ctl_info, char *data)
48
{
49
	return sprintf(data, "%u\n", ctl_info->log_ce);
50 51
}

52 53 54
static ssize_t edac_device_ctl_log_ce_store(struct edac_device_ctl_info
					    *ctl_info, const char *data,
					    size_t count)
55 56
{
	/* if parameter is zero, turn off flag, if non-zero turn on flag */
57
	ctl_info->log_ce = (simple_strtoul(data, NULL, 0) != 0);
58

59
	return count;
60 61 62
}

/* 'panic_on_ue' */
63 64
static ssize_t edac_device_ctl_panic_on_ue_show(struct edac_device_ctl_info
						*ctl_info, char *data)
65
{
66
	return sprintf(data, "%u\n", ctl_info->panic_on_ue);
67 68
}

69 70 71
static ssize_t edac_device_ctl_panic_on_ue_store(struct edac_device_ctl_info
						 *ctl_info, const char *data,
						 size_t count)
72 73
{
	/* if parameter is zero, turn off flag, if non-zero turn on flag */
74
	ctl_info->panic_on_ue = (simple_strtoul(data, NULL, 0) != 0);
75 76 77 78 79

	return count;
}

/* 'poll_msec' show and store functions*/
80 81
static ssize_t edac_device_ctl_poll_msec_show(struct edac_device_ctl_info
					      *ctl_info, char *data)
82
{
83
	return sprintf(data, "%u\n", ctl_info->poll_msec);
84 85
}

86 87 88
static ssize_t edac_device_ctl_poll_msec_store(struct edac_device_ctl_info
					       *ctl_info, const char *data,
					       size_t count)
89 90 91 92 93 94 95 96
{
	unsigned long value;

	/* get the value and enforce that it is non-zero, must be at least
	 * one millisecond for the delay period, between scans
	 * Then cancel last outstanding delay for the work request
	 * and set a new one.
	 */
97 98
	value = simple_strtoul(data, NULL, 0);
	edac_device_reset_delay_period(ctl_info, value);
99

100
	return count;
101 102 103 104
}

/* edac_device_ctl_info specific attribute structure */
struct ctl_info_attribute {
105 106 107
	struct attribute attr;
	 ssize_t(*show) (struct edac_device_ctl_info *, char *);
	 ssize_t(*store) (struct edac_device_ctl_info *, const char *, size_t);
108 109 110 111 112 113 114
};

#define to_ctl_info(k) container_of(k, struct edac_device_ctl_info, kobj)
#define to_ctl_info_attr(a) container_of(a,struct ctl_info_attribute,attr)

/* Function to 'show' fields from the edac_dev 'ctl_info' structure */
static ssize_t edac_dev_ctl_info_show(struct kobject *kobj,
115
				      struct attribute *attr, char *buffer)
116
{
117 118
	struct edac_device_ctl_info *edac_dev = to_ctl_info(kobj);
	struct ctl_info_attribute *ctl_info_attr = to_ctl_info_attr(attr);
119

120 121 122
	if (ctl_info_attr->show)
		return ctl_info_attr->show(edac_dev, buffer);
	return -EIO;
123 124 125 126
}

/* Function to 'store' fields into the edac_dev 'ctl_info' structure */
static ssize_t edac_dev_ctl_info_store(struct kobject *kobj,
127 128
				       struct attribute *attr,
				       const char *buffer, size_t count)
129
{
130 131
	struct edac_device_ctl_info *edac_dev = to_ctl_info(kobj);
	struct ctl_info_attribute *ctl_info_attr = to_ctl_info_attr(attr);
132

133 134 135
	if (ctl_info_attr->store)
		return ctl_info_attr->store(edac_dev, buffer, count);
	return -EIO;
136 137 138 139
}

/* edac_dev file operations for an 'ctl_info' */
static struct sysfs_ops device_ctl_info_ops = {
140 141
	.show = edac_dev_ctl_info_show,
	.store = edac_dev_ctl_info_store
142 143 144 145 146 147 148 149 150 151
};

#define CTL_INFO_ATTR(_name,_mode,_show,_store)        \
static struct ctl_info_attribute attr_ctl_info_##_name = {      \
        .attr = {.name = __stringify(_name), .mode = _mode },   \
        .show   = _show,                                        \
        .store  = _store,                                       \
};

/* Declare the various ctl_info attributes here and their respective ops */
152 153 154 155 156 157 158 159 160
CTL_INFO_ATTR(log_ue, S_IRUGO | S_IWUSR,
	      edac_device_ctl_log_ue_show, edac_device_ctl_log_ue_store);
CTL_INFO_ATTR(log_ce, S_IRUGO | S_IWUSR,
	      edac_device_ctl_log_ce_show, edac_device_ctl_log_ce_store);
CTL_INFO_ATTR(panic_on_ue, S_IRUGO | S_IWUSR,
	      edac_device_ctl_panic_on_ue_show,
	      edac_device_ctl_panic_on_ue_store);
CTL_INFO_ATTR(poll_msec, S_IRUGO | S_IWUSR,
	      edac_device_ctl_poll_msec_show, edac_device_ctl_poll_msec_store);
161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184

/* Base Attributes of the EDAC_DEVICE ECC object */
static struct ctl_info_attribute *device_ctrl_attr[] = {
	&attr_ctl_info_panic_on_ue,
	&attr_ctl_info_log_ue,
	&attr_ctl_info_log_ce,
	&attr_ctl_info_poll_msec,
	NULL,
};

/* Main DEVICE kobject release() function */
static void edac_device_ctrl_master_release(struct kobject *kobj)
{
	struct edac_device_ctl_info *edac_dev;

	edac_dev = to_edacdev(kobj);

	debugf1("%s()\n", __func__);
	complete(&edac_dev->kobj_complete);
}

static struct kobj_type ktype_device_ctrl = {
	.release = edac_device_ctrl_master_release,
	.sysfs_ops = &device_ctl_info_ops,
185
	.default_attrs = (struct attribute **)device_ctrl_attr,
186 187 188 189 190 191 192 193 194 195 196 197
};

/**************** edac_device main kobj ctor/dtor code *********************/

/*
 * edac_device_register_main_kobj
 *
 *	perform the high level setup for the new edac_device instance
 *
 * Return:  0 SUCCESS
 *         !0 FAILURE
 */
198
static int edac_device_register_main_kobj(struct edac_device_ctl_info *edac_dev)
199 200 201 202 203 204
{
	int err = 0;
	struct sysdev_class *edac_class;

	debugf1("%s()\n", __func__);

205 206 207 208 209 210
	/* get the /sys/devices/system/edac reference */
	edac_class = edac_get_edac_class();
	if (edac_class == NULL) {
		debugf1("%s() no edac_class error=%d\n", __func__, err);
		return err;
	}
211 212 213 214 215

	/* Point to the 'edac_class' this instance 'reports' to */
	edac_dev->edac_class = edac_class;

	/* Init the devices's kobject */
216
	memset(&edac_dev->kobj, 0, sizeof(struct kobject));
217 218 219 220 221 222
	edac_dev->kobj.ktype = &ktype_device_ctrl;

	/* set this new device under the edac_class kobject */
	edac_dev->kobj.parent = &edac_class->kset.kobj;

	/* generate sysfs "..../edac/<name>"   */
223 224
	debugf1("%s() set name of kobject to: %s\n", __func__, edac_dev->name);
	err = kobject_set_name(&edac_dev->kobj, "%s", edac_dev->name);
225 226 227 228 229
	if (err)
		return err;
	err = kobject_register(&edac_dev->kobj);
	if (err) {
		debugf1("%s()Failed to register '.../edac/%s'\n",
230
			__func__, edac_dev->name);
231 232 233 234 235 236 237 238 239 240 241 242 243
		return err;
	}

	debugf1("%s() Registered '.../edac/%s' kobject\n",
		__func__, edac_dev->name);

	return 0;
}

/*
 * edac_device_unregister_main_kobj:
 *	the '..../edac/<name>' kobject
 */
244 245
static void edac_device_unregister_main_kobj(struct edac_device_ctl_info
					     *edac_dev)
246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265
{
	debugf0("%s()\n", __func__);
	debugf1("%s() name of kobject is: %s\n",
		__func__, kobject_name(&edac_dev->kobj));

	init_completion(&edac_dev->kobj_complete);

	/*
	 * Unregister the edac device's kobject and
	 * wait for reference count to reach 0.
	 */
	kobject_unregister(&edac_dev->kobj);
	wait_for_completion(&edac_dev->kobj_complete);
}

/*************** edac_dev -> instance information ***********/

/*
 * Set of low-level instance attribute show functions
 */
266 267
static ssize_t instance_ue_count_show(struct edac_device_instance *instance,
				      char *data)
268
{
269
	return sprintf(data, "%u\n", instance->counters.ue_count);
270 271
}

272 273
static ssize_t instance_ce_count_show(struct edac_device_instance *instance,
				      char *data)
274
{
275
	return sprintf(data, "%u\n", instance->counters.ce_count);
276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293
}

#define to_instance(k) container_of(k, struct edac_device_instance, kobj)
#define to_instance_attr(a) container_of(a,struct instance_attribute,attr)

/* DEVICE instance kobject release() function */
static void edac_device_ctrl_instance_release(struct kobject *kobj)
{
	struct edac_device_instance *instance;

	debugf1("%s()\n", __func__);

	instance = to_instance(kobj);
	complete(&instance->kobj_complete);
}

/* instance specific attribute structure */
struct instance_attribute {
294 295 296
	struct attribute attr;
	 ssize_t(*show) (struct edac_device_instance *, char *);
	 ssize_t(*store) (struct edac_device_instance *, const char *, size_t);
297 298 299 300
};

/* Function to 'show' fields from the edac_dev 'instance' structure */
static ssize_t edac_dev_instance_show(struct kobject *kobj,
301
				      struct attribute *attr, char *buffer)
302
{
303 304
	struct edac_device_instance *instance = to_instance(kobj);
	struct instance_attribute *instance_attr = to_instance_attr(attr);
305

306 307 308
	if (instance_attr->show)
		return instance_attr->show(instance, buffer);
	return -EIO;
309 310 311 312
}

/* Function to 'store' fields into the edac_dev 'instance' structure */
static ssize_t edac_dev_instance_store(struct kobject *kobj,
313 314
				       struct attribute *attr,
				       const char *buffer, size_t count)
315
{
316 317
	struct edac_device_instance *instance = to_instance(kobj);
	struct instance_attribute *instance_attr = to_instance_attr(attr);
318

319 320 321
	if (instance_attr->store)
		return instance_attr->store(instance, buffer, count);
	return -EIO;
322 323 324 325
}

/* edac_dev file operations for an 'instance' */
static struct sysfs_ops device_instance_ops = {
326 327
	.show = edac_dev_instance_show,
	.store = edac_dev_instance_store
328 329 330 331 332 333 334 335 336 337 338 339 340 341
};

#define INSTANCE_ATTR(_name,_mode,_show,_store)        \
static struct instance_attribute attr_instance_##_name = {      \
        .attr = {.name = __stringify(_name), .mode = _mode },   \
        .show   = _show,                                        \
        .store  = _store,                                       \
};

/*
 * Define attributes visible for the edac_device instance object
 *	Each contains a pointer to a show and an optional set
 *	function pointer that does the low level output/input
 */
342 343
INSTANCE_ATTR(ce_count, S_IRUGO, instance_ce_count_show, NULL);
INSTANCE_ATTR(ue_count, S_IRUGO, instance_ue_count_show, NULL);
344 345 346 347 348 349 350 351 352 353 354 355

/* list of edac_dev 'instance' attributes */
static struct instance_attribute *device_instance_attr[] = {
	&attr_instance_ce_count,
	&attr_instance_ue_count,
	NULL,
};

/* The 'ktype' for each edac_dev 'instance' */
static struct kobj_type ktype_instance_ctrl = {
	.release = edac_device_ctrl_instance_release,
	.sysfs_ops = &device_instance_ops,
356
	.default_attrs = (struct attribute **)device_instance_attr,
357 358 359 360 361 362 363
};

/*************** edac_dev -> instance -> block information *********/

/*
 * Set of low-level block attribute show functions
 */
364
static ssize_t block_ue_count_show(struct edac_device_block *block, char *data)
365
{
366
	return sprintf(data, "%u\n", block->counters.ue_count);
367 368
}

369
static ssize_t block_ce_count_show(struct edac_device_block *block, char *data)
370
{
371
	return sprintf(data, "%u\n", block->counters.ce_count);
372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389
}

#define to_block(k) container_of(k, struct edac_device_block, kobj)
#define to_block_attr(a) container_of(a,struct block_attribute,attr)

/* DEVICE block kobject release() function */
static void edac_device_ctrl_block_release(struct kobject *kobj)
{
	struct edac_device_block *block;

	debugf1("%s()\n", __func__);

	block = to_block(kobj);
	complete(&block->kobj_complete);
}

/* block specific attribute structure */
struct block_attribute {
390 391 392
	struct attribute attr;
	 ssize_t(*show) (struct edac_device_block *, char *);
	 ssize_t(*store) (struct edac_device_block *, const char *, size_t);
393 394 395 396
};

/* Function to 'show' fields from the edac_dev 'block' structure */
static ssize_t edac_dev_block_show(struct kobject *kobj,
397
				   struct attribute *attr, char *buffer)
398
{
399 400
	struct edac_device_block *block = to_block(kobj);
	struct block_attribute *block_attr = to_block_attr(attr);
401

402 403 404
	if (block_attr->show)
		return block_attr->show(block, buffer);
	return -EIO;
405 406 407 408
}

/* Function to 'store' fields into the edac_dev 'block' structure */
static ssize_t edac_dev_block_store(struct kobject *kobj,
409 410
				    struct attribute *attr,
				    const char *buffer, size_t count)
411
{
412 413
	struct edac_device_block *block = to_block(kobj);
	struct block_attribute *block_attr = to_block_attr(attr);
414

415 416 417
	if (block_attr->store)
		return block_attr->store(block, buffer, count);
	return -EIO;
418 419 420 421
}

/* edac_dev file operations for a 'block' */
static struct sysfs_ops device_block_ops = {
422 423
	.show = edac_dev_block_show,
	.store = edac_dev_block_store
424 425 426 427 428 429 430 431 432
};

#define BLOCK_ATTR(_name,_mode,_show,_store)        \
static struct block_attribute attr_block_##_name = {                       \
        .attr = {.name = __stringify(_name), .mode = _mode },   \
        .show   = _show,                                        \
        .store  = _store,                                       \
};

433 434
BLOCK_ATTR(ce_count, S_IRUGO, block_ce_count_show, NULL);
BLOCK_ATTR(ue_count, S_IRUGO, block_ue_count_show, NULL);
435 436 437 438 439 440 441 442 443 444 445 446

/* list of edac_dev 'block' attributes */
static struct block_attribute *device_block_attr[] = {
	&attr_block_ce_count,
	&attr_block_ue_count,
	NULL,
};

/* The 'ktype' for each edac_dev 'block' */
static struct kobj_type ktype_block_ctrl = {
	.release = edac_device_ctrl_block_release,
	.sysfs_ops = &device_block_ops,
447
	.default_attrs = (struct attribute **)device_block_attr,
448 449 450 451 452 453 454
};

/************** block ctor/dtor  code ************/

/*
 * edac_device_create_block
 */
455 456 457
static int edac_device_create_block(struct edac_device_ctl_info *edac_dev,
				    struct edac_device_instance *instance,
				    int idx)
458 459 460 461 462 463 464
{
	int err;
	struct edac_device_block *block;

	block = &instance->blocks[idx];

	debugf1("%s() Instance '%s' block[%d] '%s'\n",
465
		__func__, instance->name, idx, block->name);
466 467

	/* init this block's kobject */
468
	memset(&block->kobj, 0, sizeof(struct kobject));
469 470 471
	block->kobj.parent = &instance->kobj;
	block->kobj.ktype = &ktype_block_ctrl;

472
	err = kobject_set_name(&block->kobj, "%s", block->name);
473 474 475 476 477 478
	if (err)
		return err;

	err = kobject_register(&block->kobj);
	if (err) {
		debugf1("%s()Failed to register instance '%s'\n",
479
			__func__, block->name);
480 481 482 483 484 485 486 487 488
		return err;
	}

	return 0;
}

/*
 * edac_device_delete_block(edac_dev,j);
 */
489 490 491
static void edac_device_delete_block(struct edac_device_ctl_info *edac_dev,
				     struct edac_device_instance *instance,
				     int idx)
492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508
{
	struct edac_device_block *block;

	block = &instance->blocks[idx];

	/* unregister this block's kobject */
	init_completion(&block->kobj_complete);
	kobject_unregister(&block->kobj);
	wait_for_completion(&block->kobj_complete);
}

/************** instance ctor/dtor  code ************/

/*
 * edac_device_create_instance
 *	create just one instance of an edac_device 'instance'
 */
509 510
static int edac_device_create_instance(struct edac_device_ctl_info *edac_dev,
				       int idx)
511 512 513 514 515 516 517 518
{
	int i, j;
	int err;
	struct edac_device_instance *instance;

	instance = &edac_dev->instances[idx];

	/* Init the instance's kobject */
519
	memset(&instance->kobj, 0, sizeof(struct kobject));
520 521 522 523 524

	/* set this new device under the edac_device main kobject */
	instance->kobj.parent = &edac_dev->kobj;
	instance->kobj.ktype = &ktype_instance_ctrl;

525
	err = kobject_set_name(&instance->kobj, "%s", instance->name);
526 527 528 529 530 531
	if (err)
		return err;

	err = kobject_register(&instance->kobj);
	if (err != 0) {
		debugf2("%s() Failed to register instance '%s'\n",
532
			__func__, instance->name);
533 534 535 536
		return err;
	}

	debugf1("%s() now register '%d' blocks for instance %d\n",
537
		__func__, instance->nr_blocks, idx);
538 539

	/* register all blocks of this instance */
540 541
	for (i = 0; i < instance->nr_blocks; i++) {
		err = edac_device_create_block(edac_dev, instance, i);
542 543
		if (err) {
			for (j = 0; j < i; j++) {
544
				edac_device_delete_block(edac_dev, instance, j);
545 546 547 548 549 550 551 552 553 554 555 556 557 558 559
			}
			return err;
		}
	}

	debugf1("%s() Registered instance %d '%s' kobject\n",
		__func__, idx, instance->name);

	return 0;
}

/*
 * edac_device_remove_instance
 *	remove an edac_device instance
 */
560 561
static void edac_device_delete_instance(struct edac_device_ctl_info *edac_dev,
					int idx)
562 563 564 565 566 567 568 569
{
	int i;
	struct edac_device_instance *instance;

	instance = &edac_dev->instances[idx];

	/* unregister all blocks in this instance */
	for (i = 0; i < instance->nr_blocks; i++) {
570
		edac_device_delete_block(edac_dev, instance, i);
571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591
	}

	/* unregister this instance's kobject */
	init_completion(&instance->kobj_complete);
	kobject_unregister(&instance->kobj);
	wait_for_completion(&instance->kobj_complete);
}

/*
 * edac_device_create_instances
 *	create the first level of 'instances' for this device
 *	(ie  'cache' might have 'cache0', 'cache1', 'cache2', etc
 */
static int edac_device_create_instances(struct edac_device_ctl_info *edac_dev)
{
	int i, j;
	int err;

	debugf0("%s()\n", __func__);

	/* iterate over creation of the instances */
592 593
	for (i = 0; i < edac_dev->nr_instances; i++) {
		err = edac_device_create_instance(edac_dev, i);
594 595 596
		if (err) {
			/* unwind previous instances on error */
			for (j = 0; j < i; j++) {
597
				edac_device_delete_instance(edac_dev, j);
598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614
			}
			return err;
		}
	}

	return 0;
}

/*
 * edac_device_delete_instances(edac_dev);
 *	unregister all the kobjects of the instances
 */
static void edac_device_delete_instances(struct edac_device_ctl_info *edac_dev)
{
	int i;

	/* iterate over creation of the instances */
615 616
	for (i = 0; i < edac_dev->nr_instances; i++) {
		edac_device_delete_instance(edac_dev, i);
617 618 619 620 621
	}
}

/******************* edac_dev sysfs ctor/dtor  code *************/

622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649
/*
 * edac_device_add_sysfs_attributes
 *	add some attributes to this instance's main kobject
 */
static int edac_device_add_sysfs_attributes(
			struct edac_device_ctl_info *edac_dev)
{
	int err;
        struct edac_dev_sysfs_attribute *sysfs_attrib;

        /* point to the start of the array and iterate over it
         * adding each attribute listed to this mci instance's kobject
         */
        sysfs_attrib = edac_dev->sysfs_attributes;

        while (sysfs_attrib->attr.name != NULL) {
                err = sysfs_create_file(&edac_dev->kobj,
                                        (struct attribute*) sysfs_attrib);
                if (err) {
                        return err;
                }

                sysfs_attrib++;
        }

	return 0;
}

650 651 652 653 654 655 656 657 658 659 660 661
/*
 * edac_device_create_sysfs() Constructor
 *
 * Create a new edac_device kobject instance,
 *
 * Return:
 *	0	Success
 *	!0	Failure
 */
int edac_device_create_sysfs(struct edac_device_ctl_info *edac_dev)
{
	int err;
662
	struct kobject *edac_kobj = &edac_dev->kobj;
663 664 665 666 667 668 669 670

	/* register this instance's main kobj with the edac class kobj */
	err = edac_device_register_main_kobj(edac_dev);
	if (err)
		return err;

	debugf0("%s() idx=%d\n", __func__, edac_dev->dev_idx);

671 672 673 674 675 676 677 678 679 680 681 682
	/* If the low level driver requests some sysfs entries
	 * then go create them here
	 */
	if (edac_dev->sysfs_attributes != NULL) {
		err = edac_device_add_sysfs_attributes(edac_dev);
		if (err) {
			debugf0("%s() failed to add sysfs attribs\n",
				__func__);
			goto err_unreg_object;
		}
	}

683 684 685 686
	/* create a symlink from the edac device
	 * to the platform 'device' being used for this
	 */
	err = sysfs_create_link(edac_kobj,
687
				&edac_dev->dev->kobj, EDAC_DEVICE_SYMLINK);
688 689 690
	if (err) {
		debugf0("%s() sysfs_create_link() returned err= %d\n",
			__func__, err);
691
		goto err_unreg_object;
692 693 694 695 696 697 698 699
	}

	debugf0("%s() calling create-instances, idx=%d\n",
		__func__, edac_dev->dev_idx);

	/* Create the first level instance directories */
	err = edac_device_create_instances(edac_dev);
	if (err) {
700
		goto err_remove_link;
701 702 703 704 705
	}

	return 0;

	/* Error unwind stack */
706 707 708
err_remove_link:
	/* remove the sym link */
	sysfs_remove_link(&edac_dev->kobj, EDAC_DEVICE_SYMLINK);
709

710
err_unreg_object:
711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732
	edac_device_unregister_main_kobj(edac_dev);

	return err;
}

/*
 * edac_device_remove_sysfs() destructor
 *
 * remove a edac_device instance
 */
void edac_device_remove_sysfs(struct edac_device_ctl_info *edac_dev)
{
	debugf0("%s()\n", __func__);

	edac_device_delete_instances(edac_dev);

	/* remove the sym link */
	sysfs_remove_link(&edac_dev->kobj, EDAC_DEVICE_SYMLINK);

	/* unregister the instance's main kobj */
	edac_device_unregister_main_kobj(edac_dev);
}