• Bart Van Assche's avatar
    IB/core: Fix two kernel warnings triggered by rxe registration · 02ee9da3
    Bart Van Assche authored
    Eliminate the WARN_ONs that create following two warnings when
    registering an rxe device:
    
    WARNING: CPU: 2 PID: 1005 at drivers/infiniband/core/device.c:449 ib_register_device+0x591/0x640 [ib_core]
    CPU: 2 PID: 1005 Comm: run_tests Not tainted 4.15.0-rc4-dbg+ #2
    Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.0.0-prebuilt.qemu-project.org 04/01/2014
    RIP: 0010:ib_register_device+0x591/0x640 [ib_core]
    Call Trace:
     rxe_register_device+0x3c6/0x470 [rdma_rxe]
     rxe_add+0x543/0x5e0 [rdma_rxe]
     rxe_net_add+0x37/0xb0 [rdma_rxe]
     rxe_param_set_add+0x5a/0x120 [rdma_rxe]
     param_attr_store+0x5e/0xc0
     module_attr_store+0x19/0x30
     sysfs_kf_write+0x3d/0x50
     kernfs_fop_write+0x116/0x1a0
     __vfs_write+0x23/0x120
     vfs_write+0xbe/0x1b0
     SyS_write+0x44/0xa0
     entry_SYSCALL_64_fastpath+0x23/0x9a
    
    WARNING: CPU: 2 PID: 1005 at drivers/infiniband/core/sysfs.c:1279 ib_device_register_sysfs+0x11d/0x160 [ib_core]
    CPU: 2 PID: 1005 Comm: run_tests Tainted: G        W        4.15.0-rc4-dbg+ #2
    Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.0.0-prebuilt.qemu-project.org 04/01/2014
    RIP: 0010:ib_device_register_sysfs+0x11d/0x160 [ib_core]
    Call Trace:
     ib_register_device+0x3f7/0x640 [ib_core]
     rxe_register_device+0x3c6/0x470 [rdma_rxe]
     rxe_add+0x543/0x5e0 [rdma_rxe]
     rxe_net_add+0x37/0xb0 [rdma_rxe]
     rxe_param_set_add+0x5a/0x120 [rdma_rxe]
     param_attr_store+0x5e/0xc0
     module_attr_store+0x19/0x30
     sysfs_kf_write+0x3d/0x50
     kernfs_fop_write+0x116/0x1a0
     __vfs_write+0x23/0x120
     vfs_write+0xbe/0x1b0
     SyS_write+0x44/0xa0
     entry_SYSCALL_64_fastpath+0x23/0x9a
    
    The code should accept either a parent pointer or a fully specified DMA
    specification without producing warnings.
    
    Fixes: 99db9494 ("IB/core: Remove ib_device.dma_device")
    Signed-off-by: default avatarBart Van Assche <bart.vanassche@wdc.com>
    Cc: Leon Romanovsky <leon@kernel.org>
    Cc: stable@vger.kernel.org # v4.11
    Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
    02ee9da3
sysfs.c 34.4 KB