• Kars de Jong's avatar
    scsi: zorro_esp: Limit DMA transfers to 65536 bytes (except on Fastlane) · 02f7e9f3
    Kars de Jong authored
    When using this driver on a Blizzard 1260, there were failures whenever DMA
    transfers from the SCSI bus to memory of 65535 bytes were followed by a DMA
    transfer of 1 byte. This caused the byte at offset 65535 to be overwritten
    with 0xff. The Blizzard hardware can't handle single byte DMA transfers.
    
    Besides this issue, limiting the DMA length to something that is not a
    multiple of the page size is very inefficient on most file systems.
    
    It seems this limit was chosen because the DMA transfer counter of the ESP
    by default is 16 bits wide, thus limiting the length to 65535 bytes.
    However, the value 0 means 65536 bytes, which is handled by the ESP and the
    Blizzard just fine. It is also the default maximum used by esp_scsi when
    drivers don't provide their own dma_length_limit() function.
    
    The limit of 65536 bytes can be used by all boards except the Fastlane. The
    old driver used a limit of 65532 bytes (0xfffc), which is reintroduced in
    this patch.
    
    Fixes: b7ded0e8 ("scsi: zorro_esp: Limit DMA transfers to 65535 bytes")
    Link: https://lore.kernel.org/r/20191112175523.23145-1-jongk@linux-m68k.orgSigned-off-by: default avatarKars de Jong <jongk@linux-m68k.org>
    Reviewed-by: default avatarFinn Thain <fthain@telegraphics.com.au>
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    02f7e9f3
zorro_esp.c 24.8 KB