• Arnd Bergmann's avatar
    ARM: samsung: improve static dma_mask definition · 4cb54493
    Arnd Bergmann authored
    When no DMA master devices are part of the kernel configuration,
    we get a warning about the unused dma mask definition:
    
    arch/arm/plat-samsung/devs.c:71:12: error: 'samsung_device_dma_mask' defined but not used [-Werror=unused-variable]
     static u64 samsung_device_dma_mask = DMA_BIT_MASK(32);
    
    We could simply mark this as __maybe_unused to shut up that warning,
    but a nicer solution seems to be to have a separate mask for each
    device. The advantage is that a driver that happens to call
    dma_set_mask() on one device doesn't implicitly change the mask
    for the other devices as well. This is more of a theoretical
    problem, as obviously nothing does it for the devices in this
    file (or they would have always been broken), but it feels
    cleaner that way.
    
    The definition works by creating an array in place so we can take
    the address of it and let the compiler generate a hidden symbol
    for it at compile time.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
    4cb54493
devs.c 29.6 KB