• William Cohen's avatar
    Correct the race condition in aarch64_insn_patch_text_sync() · 899d5933
    William Cohen authored
    When experimenting with patches to provide kprobes support for aarch64
    smp machines would hang when inserting breakpoints into kernel code.
    The hangs were caused by a race condition in the code called by
    aarch64_insn_patch_text_sync().  The first processor in the
    aarch64_insn_patch_text_cb() function would patch the code while other
    processors were still entering the function and incrementing the
    cpu_count field.  This resulted in some processors never observing the
    exit condition and exiting the function.  Thus, processors in the
    system hung.
    
    The first processor to enter the patching function performs the
    patching and signals that the patching is complete with an increment
    of the cpu_count field. When all the processors have incremented the
    cpu_count field the cpu_count will be num_cpus_online()+1 and they
    will return to normal execution.
    
    Fixes: ae164807 arm64: introduce interfaces to hotpatch kernel and module code
    Signed-off-by: default avatarWilliam Cohen <wcohen@redhat.com>
    Acked-by: default avatarWill Deacon <will.deacon@arm.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
    899d5933
insn.c 22.4 KB