• Rusty Russell's avatar
    x86: fix pte_flags() to only return flags, fix lguest (updated) · c2e3277f
    Rusty Russell authored
    (Jeremy said:
    	rusty: use PTE_MASK
    	rusty: use PTE_MASK
    	rusty: use PTE_MASK
     When I asked:
    	jsgf: does that include the NX flag?
     He responded eloquently:
    	rusty: use PTE_MASK
    	rusty: use PTE_MASK
    	yes, it's the official constant of masking flags out of ptes
    )
    
    Change a15af1c9 'x86/paravirt: add
    pte_flags to just get pte flags' removed lguest's private pte_flags()
    in favor of a generic one.
    
    Unfortunately, the generic one doesn't filter out the non-flags bits:
    this results in lguest creating corrupt shadow page tables and blowing
    up host memory.
    
    Since noone is supposed to use the pfn part of pte_flags(), it seems
    safest to always do the filtering.
    Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
    Acked-by: default avatarJeremy Fitzhardinge <jeremy@goop.org>
    Signed-off-and-morning-tea-spilled-by: default avatarIngo Molnar <mingo@elte.hu>
    c2e3277f
paravirt.c 11.9 KB