• Anton Blanchard's avatar
    RxRPC: Allocate tokens with kzalloc to avoid oops in rxrpc_destroy · 0a93ea2e
    Anton Blanchard authored
    With slab poisoning enabled, I see the following oops:
    
      Unable to handle kernel paging request for data at address 0x6b6b6b6b6b6b6b73
      ...
      NIP [c0000000006bc61c] .rxrpc_destroy+0x44/0x104
      LR [c0000000006bc618] .rxrpc_destroy+0x40/0x104
      Call Trace:
      [c0000000feb2bc00] [c0000000006bc618] .rxrpc_destroy+0x40/0x104 (unreliable)
      [c0000000feb2bc90] [c000000000349b2c] .key_cleanup+0x1a8/0x20c
      [c0000000feb2bd40] [c0000000000a2920] .process_one_work+0x2f4/0x4d0
      [c0000000feb2be00] [c0000000000a2d50] .worker_thread+0x254/0x468
      [c0000000feb2bec0] [c0000000000a868c] .kthread+0xbc/0xc8
      [c0000000feb2bf90] [c000000000020e00] .kernel_thread+0x54/0x70
    
    We aren't initialising token->next, but the code in destroy_context relies
    on the list being NULL terminated. Use kzalloc to zero out all the fields.
    Signed-off-by: default avatarAnton Blanchard <anton@samba.org>
    Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    0a93ea2e
ar-key.c 27.9 KB