• Cong Wang's avatar
    net: correct error path in rtnl_newlink() · 0e0eee24
    Cong Wang authored
    I saw the following BUG when ->newlink() fails in rtnl_newlink():
    
    [   40.240058] kernel BUG at net/core/dev.c:6438!
    
    this is due to free_netdev() is not supposed to be called before
    netdev is completely unregistered, therefore it is not correct
    to call free_netdev() here, at least for ops->newlink!=NULL case,
    many drivers call it in ->destructor so that rtnl_unlock() will
    take care of it, we probably don't need to do anything here.
    
    Cc: David S. Miller <davem@davemloft.net>
    Cc: Eric Dumazet <eric.dumazet@gmail.com>
    Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
    Signed-off-by: default avatarCong Wang <cwang@twopensource.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    0e0eee24
rtnetlink.c 69.2 KB