• Francesco Ruggeri's avatar
    net: use exponential backoff in netdev_wait_allrefs · 0e4be9e5
    Francesco Ruggeri authored
    The combination of aca_free_rcu, introduced in commit 2384d025
    ("net/ipv6: Add anycast addresses to a global hashtable"), and
    fib6_info_destroy_rcu, introduced in commit 9b0a8da8 ("net/ipv6:
    respect rcu grace period before freeing fib6_info"), can result in
    an extra rcu grace period being needed when deleting an interface,
    with the result that netdev_wait_allrefs ends up hitting the msleep(250),
    which is considerably longer than the required grace period.
    This can result in long delays when deleting a large number of interfaces,
    and it can be observed with this script:
    
    ns=dummy-ns
    NIFS=100
    
    ip netns add $ns
    ip netns exec $ns ip link set lo up
    ip netns exec $ns sysctl net.ipv6.conf.default.disable_ipv6=0
    ip netns exec $ns sysctl net.ipv6.conf.default.forwarding=1
    
    for ((i=0; i<$NIFS; i++))
    do
            if=eth$i
            ip netns exec $ns ip link add $if type dummy
            ip netns exec $ns ip link set $if up
            ip netns exec $ns ip -6 addr add 2021:$i::1/120 dev $if
    done
    
    for ((i=0; i<$NIFS; i++))
    do
            if=eth$i
            ip netns exec $ns ip link del $if
    done
    
    ip netns del $ns
    
    Instead of using a fixed msleep(250), this patch tries an extra
    rcu_barrier() followed by an exponential backoff.
    
    Time with this patch on a 5.4 kernel:
    
    real	0m7.704s
    user	0m0.385s
    sys	0m1.230s
    
    Time without this patch:
    
    real    0m31.522s
    user    0m0.438s
    sys     0m1.156s
    
    v2: use exponential backoff instead of trying to wake up
        netdev_wait_allrefs.
    v3: preserve reverse christmas tree ordering of local variables
    v4: try an extra rcu_barrier before the backoff, plus some
        cosmetic changes.
    Signed-off-by: default avatarFrancesco Ruggeri <fruggeri@arista.com>
    Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    0e4be9e5
dev.c 275 KB