• Sergey Senozhatsky's avatar
    printk: do not preliminary split up cont buffer · 0e96a19c
    Sergey Senozhatsky authored
    We have a proper 'overflow' check which tells us that we need to
    split up existing cont buffer in separate records:
    
    	if (cont.len + len > sizeof(cont.buf))
    		cont_flush();
    
    At the same time we also have one extra flush: "if cont buffer is
    80% full then split it up" in cont_add():
    
    	if (cont.len > (sizeof(cont.buf) * 80) / 100)
    		cont_flush();
    
    This looks to be redundant, since the existing "overflow" check
    should work just fine, so remove this 80% check and wait for either
    a normal cont termination \n, for preliminary flush due to
    possible buffer overflow or for preliminary flush due to cont race.
    
    Link: http://lkml.kernel.org/r/20181002023836.4487-4-sergey.senozhatsky@gmail.com
    To: Steven Rostedt <rostedt@goodmis.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Dmitriy Vyukov <dvyukov@google.com>
    Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
    Cc: Tejun Heo <tj@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: LKML <linux-kernel@vger.kernel.org>
    Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
    Signed-off-by: default avatarSergey Senozhatsky <sergey.senozhatsky@gmail.com>
    Signed-off-by: default avatarPetr Mladek <pmladek@suse.com>
    0e96a19c
printk.c 82.4 KB