• James Smart's avatar
    [SCSI] scsi_transport_fc: Clear Devloss Callback Done flag in fc_remote_port_rolechg · 0eecee41
    James Smart authored
    This patch fixes a bug where devloss is not called on fc_host teardown.
    The issue is seen if the LLDD uses rport_rolechg to add the target role
    to an rport.
    
    When an rport goes away, the LLDD will call fc_remote_port_delete, which
    will start the devloss timer.  If the timer expires, the transport will
    call the devloss callback and set the FC_RPORT_DEVLOSS_CALLBK_DONE flag.
    However, the rport structure is not deleted, it is retained to store the
    SCSI id mappings for the rport in case it comes back. In the scenario
    where it does come back, and the driver calls fc_remote_port_add, but does
    not indicate the "target" role for the rport - the create will clear the
    structure, but forgets to clear FC_RPORT_DEVLOSS_CALLBK_DONE flag (which
    is cleared if it's added with the target role). The secondary call, of
    fc_remote_port_rolechg to add the target role also does not clear the flag.
    Thus, the next time the rport goes away, the resulting devloss timer
    expiration will not call the driver callback as the flag is still set.
    
    This patch adds the FC_RPORT_DEVLOSS_CALLBK_DONE flags to the list of
    those that are cleared upon reuse of the rport structure.
    Signed-off-by: default avatarAlex Iannicelli <alex.iannicelli@emulex.com>
    Signed-off-by: default avatarJames Smart <james.smart@emulex.com>
    Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
    0eecee41
scsi_transport_fc.c 120 KB