• Daniel Vetter's avatar
    drm/vmwgfx: remove ->firstopen callback · 0faa4a87
    Daniel Vetter authored
    So if we survey kms drivers there's a bunch of things they commonly do
    in ->lastclose
    - delayed processing of vga switcheroo requests (i915, nouveau,
      radeon)
    - force-restoring the fbcon (most)
    - resetting a bunch properties to make fbcon work better (omap)
    - disabling all outputs (vmwgfx)
    
    In short besides the semantically important vga switcheroo stuff they
    all try very hard to keep fbcon working in case X dies.
    
    But none of them try to not do this at driver unload time safe for
    vmwgfx, and digging through logs I couldn't find any reason for why
    vmwgfx is special.
    
    Since ->firstopen has lots of potential for abuse with kms drivers
    (like delaying driver setup to pamper over races in the load sequence)
    it's imo very much worth it to remove this logic so that we can
    stop using the ->firstopen callback for kms drivers.
    
    Also module unloading is rather a debug feature and developers should
    know how to restore the display to a sane configuration.
    
    Cc: Jakob Bornecrantz <jakob@vmware.com>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
    0faa4a87
vmwgfx_drv.c 32.8 KB