• Nicholas Bellinger's avatar
    tcm_vhost: Post-merge review changes requested by MST · 101998f6
    Nicholas Bellinger authored
    This patch contains the post RFC-v5 (post-merge) changes, this includes:
    
    - Add locking comment
    - Move vhost_scsi_complete_cmd ahead of TFO callbacks in order to
      drop forward declarations
    - Drop extra '!= NULL' usage in vhost_scsi_complete_cmd_work()
    - Change vhost_scsi_*_handle_kick() to use pr_debug
    - Fix possible race in vhost_scsi_set_endpoint() for vs->vs_tpg checking
      + assignment.
    - Convert tv_tpg->tpg_vhost_count + ->tv_tpg_port_count from atomic_t ->
      int, and make sure reference is protected by ->tv_tpg_mutex.
    - Drop unnecessary vhost_scsi->vhost_ref_cnt
    - Add 'err:' label for exception path in vhost_scsi_clear_endpoint()
    - Add enum for VQ numbers, add usage in vhost_scsi_open()
    - Add vhost_scsi_flush() + vhost_scsi_flush_vq() following
      drivers/vhost/net.c
    - Add smp_wmb() + vhost_scsi_flush() call during vhost_scsi_set_features()
    - Drop unnecessary copy_from_user() usage with GET_ABI_VERSION ioctl
    - Add missing vhost_scsi_compat_ioctl() caller for vhost_scsi_fops
    - Fix function parameter definition first line to follow existing
      vhost code style
    - Change 'vHost' usage -> 'vhost' in handful of locations
    - Change -EPERM -> -EBUSY usage for two failures in tcm_vhost_drop_nexus()
    - Add comment for tcm_vhost_workqueue in tcm_vhost_init()
    - Make GET_ABI_VERSION return 'int' + add comment in tcm_vhost.h
    Reported-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Cc: Michael S. Tsirkin <mst@redhat.com>
    Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
    Cc: Anthony Liguori <aliguori@us.ibm.com>
    Cc: Zhi Yong Wu <wuzhy@cn.ibm.com>
    Cc: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
    101998f6
tcm_vhost.h 3.37 KB