• Maciej S. Szmigiero's avatar
    ASoC: fsl_ssi: add 20-bit sample format for AC'97 and use it for capture · 10582635
    Maciej S. Szmigiero authored
    When testing AC'97 capture on UDOO board (currently the only user of
    fsl_ssi driver in the AC'97 mode) it become obvious that there is a massive
    distortion above certain, small input signal.
    
    This problem has been traced to silicon errata ERR003778:
    "In AC97, 16-bit mode, received data is shifted by 4-bit locations" that
    has "No fix scheduled".
    This errata suggests a workaround of doing a 4-bit shift back in SDMA
    script for this specific operation mode, however our SDMA scripts are
    shared between various SoC peripherals so we can't really modify them.
    
    There is a simple way to avoid this problem, however, that is to disallow
    recording in 16-bit mode and only support it in AC'97-native 20-bit mode.
    We have to use a 4-byte format for this since SSI FIFOs do not allow 3-byte
    accesses (and these aren't supported by imx-sdma driver anyway).
    With this change the capture distortion is gone.
    
    We can also add this format as an additional one supported for playback,
    using this opportunity to make sure that we use CPU-endian-native formats
    in AC'97 mode as we already do in I2S mode.
    
    There is no problem in using different bit widths in playback and capture
    in AC'97 mode so allow this, too.
    Signed-off-by: default avatarMaciej S. Szmigiero <mail@maciej.szmigiero.name>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    10582635
fsl_ssi.c 50.9 KB