• Arnd Bergmann's avatar
    ARM: pxa/raumfeld: use PROPERTY_ENTRY_INTEGER to define props · 4d2508a5
    Arnd Bergmann authored
    gcc-6.0 notices that the use of the property_entry in this file that
    was recently introduced cannot work right, as we initialize the wrong
    field:
    
    raumfeld.c:387:3: error: the address of 'raumfeld_rotary_encoder_steps' will always evaluate as 'true' [-Werror=address]
       DEV_PROP_U32, 1, &raumfeld_rotary_encoder_steps, },
       ^~~~~~~~~~~~
    raumfeld.c:389:3: error: the address of 'raumfeld_rotary_encoder_axis' will always evaluate as 'true' [-Werror=address]
       DEV_PROP_U32, 1, &raumfeld_rotary_encoder_axis, },
       ^~~~~~~~~~~~
    raumfeld.c:391:3: error: the address of 'raumfeld_rotary_encoder_relative_axis' will always evaluate as 'true' [-Werror=address]
       DEV_PROP_U32, 1, &raumfeld_rotary_encoder_relative_axis, },
       ^~~~~~~~~~~~
    
    The problem appears to stem from relying on an old definition of
    'struct property', but it has changed several times since the code
    could have last been correct.
    
    This changes the code to use the PROPERTY_ENTRY_INTEGER() macro instead,
    which works fine for the current definition and is a safer way of doing
    the initialization.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Fixes: a9e340dc ("Input: rotary_encoder - move away from platform data structure")
    Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
    4d2508a5
raumfeld.c 25.9 KB