This function was recently converted to use rwsem locking.  But it is called
from interrupts in (at least) buffer_io_error().

And we do want a function like this to be robust and atomic.  So convert it
to use spinlocking.